On 08/04/11 01:24, Samuel Thibault wrote: > Could you rather look at the top of this page? > > http://people.debian.org/~sthibault/graph-total-top.txt > > This is what is mostly needed. A lot of them will however not be > trivial so you'll have to sort it out a bit by checking what kind of > failure is happening in the Failed page (lockf, SA_SIGINFO, ghc6, etc. > are definitely difficult, for instance). >
Ah thanks. I was thinking of something similar before. In particular, I
was thinking about sorting the failed packages using Debian Popcon data
or something similar. I will try to do more important packages from now
on, now that I know which ones are important.
>
>> - char buffer[PATH_MAX];
>> - snprintf(buffer, PATH_MAX, "%s/", project_directory);
>> + gchar *buffer = g_strdup_printf ("%s/", project_directory);
>>
>> gtk_file_selection_set_filename(GTK_FILE_SELECTION(file_selection),
>> buffer);
>> + g_free (buffer);
>
> Looks good, please submit.
>
>> - snprintf(patches_tmp_filename, PATH_MAX, "%s/WhySynth_patches-%s",
>> dir, path);
>> + if (patches_tmp_filename != NULL)
>> + g_free(patches_tmp_filename);
>> + patches_tmp_filename = g_strdup_printf ("%s/WhySynth_patches-%s",
>> dir, path);
>
> Looks good, please submit.
>
Submit where? Upstream or to Debian Alioth or ...?
>
> [...] Now, since it's actually Linux-only, it's probably also not
> really useful to port this one...
>
You're probably right about this. It was being compiled for hurd-i386 so
I assumed that it might have a use.
>> err:
>> + free(path);
>
> Please take care to keep the same indentation style as upstream uses.
>
> You'll find a lot of various styles. Stick to everyone of them, to make
> patch acceptance better.
>
Oops, I'm not sure why it suddenly used spaces for that line. I think
it's because they used spaces for the label and I didn't notice that. My
editor automatically uses (for a new line) whatever used on the line
where I append a newline.
In all other cases the indentation should be correct so this was just a
mistake. Thanks for pointing it out though.
/Patrik
signature.asc
Description: OpenPGP digital signature
