>From dd032b7115d3ed903ba97ff9bb98135e1033d715 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov
Date: Sun, 5 Jul 2009 22:39:09 +0300
Subject: [PATCH 1/3] Add the ``--mount'' command line option.
* Makefile (OBJS): Add mount.o
* options.h (OPT_MOUNT, OPT_LONG_MOUNT): Define
Hello,
On Fri, Aug 07, 2009 at 09:30:22PM +0200, olafbuddenha...@gmx.net wrote:
> On Mon, Aug 03, 2009 at 08:41:15PM +0300, Sergiu Ivanov wrote:
>
> > + if ((err = asprintf (&buf, "%s=\"%s\"", OPT_LONG (OPT_LONG_MOUNT),
> > + mountee_cl)) == -1)
> > + {
> > + free
Hi,
On Mon, Aug 03, 2009 at 08:41:15PM +0300, Sergiu Ivanov wrote:
> + if ((err = asprintf (&buf, "%s=\"%s\"", OPT_LONG (OPT_LONG_MOUNT),
> +mountee_cl)) == -1)
> + {
> + free (mountee_cl);
> + return ENOMEM;
> + }
> +
> + err = argz_add (argz
>From bdc96e0a5589ad9b7b6568b4a00c15d470522d05 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov
Date: Sun, 5 Jul 2009 22:39:09 +0300
Subject: [PATCH 1/3] Add the ``--mount'' command line option.
* Makefile (OBJS): Add mount.o
* options.h (OPT_MOUNT, OPT_LONG_MOUNT): Define
Hello,
On Fri, Jul 17, 2009 at 04:05:42AM +0200, olafbuddenha...@gmx.net wrote:
> On Tue, Jul 14, 2009 at 12:27:02PM +0300, Sergiu Ivanov wrote:
> > +
> > + /* The mountee command line converted to a 0-terminated string
> > +form. */
> > + char * mountee_cl = malloc (mountee_argz_le
Hi,
On Tue, Jul 14, 2009 at 12:21:20PM +0300, Sergiu Ivanov wrote:
> On Fri, Jul 10, 2009 at 03:23:29AM +0200, olafbuddenha...@gmx.net
> wrote:
> > On Sun, Jul 05, 2009 at 07:17:33PM +0300, Sergiu Ivanov wrote:
> > > On Fri, Jul 03, 2009 at 06:52:37AM +0200, olafbuddenha...@gmx.net
> > > wrote:
>
Hi,
On Tue, Jul 14, 2009 at 12:27:02PM +0300, Sergiu Ivanov wrote:
> + /* Add the --mount option to the result. */
> + if (mountee_argz)
> +{
> + /* The string describing the value of the ``--mount'' option. */
> + char * opt = NULL;
The comment is confusing: this does not desc
>From 5f0ae10564d3f9fe6b0fefd8766d118c3c1b880b Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov
Date: Sun, 5 Jul 2009 22:39:09 +0300
Subject: [PATCH] Add the ``--mount'' command line option.
* Makefile (OBJS): Add mount.o
* options.h (OPT_MOUNT, OPT_LONG_MOUNT): Define.
* options.c (argp_common_optio
Hello,
On Fri, Jul 10, 2009 at 03:23:29AM +0200, olafbuddenha...@gmx.net wrote:
> On Sun, Jul 05, 2009 at 07:17:33PM +0300, Sergiu Ivanov wrote:
> > On Fri, Jul 03, 2009 at 06:52:37AM +0200, olafbuddenha...@gmx.net
> > wrote:
>
> > > This surely needs some special handling in netfs_append_args()
Hello,
On Fri, Jul 10, 2009 at 04:25:26AM +0200, olafbuddenha...@gmx.net wrote:
> On Sun, Jul 05, 2009 at 03:59:25PM +0300, Sergiu Ivanov wrote:
>
> > diff --git a/mount.h b/mount.h
> [...]
> > +#ifndef INCLUDED_UNIONMOUNT_H
>
> You forgot to rename the guard macro when renaming the file...
Yea
Hi,
On Sun, Jul 05, 2009 at 03:59:25PM +0300, Sergiu Ivanov wrote:
> diff --git a/mount.h b/mount.h
[...]
> +#ifndef INCLUDED_UNIONMOUNT_H
You forgot to rename the guard macro when renaming the file...
-antrik-
Hi,
On Sun, Jul 05, 2009 at 07:17:33PM +0300, Sergiu Ivanov wrote:
> On Fri, Jul 03, 2009 at 06:52:37AM +0200, olafbuddenha...@gmx.net
> wrote:
> > This surely needs some special handling in netfs_append_args() as
> > well?...
>
> Yes, it does, of course. I didn't implement it right here becaus
Hello,
On Fri, Jul 03, 2009 at 06:52:37AM +0200, olafbuddenha...@gmx.net wrote:
> On Thu, Jun 18, 2009 at 11:14:41PM +0300, Sergiu Ivanov wrote:
> > @@ -124,6 +132,13 @@ argp_parse_common_options (int key, char *arg, struct
> > argp_state *state)
> >ulfs_match = 0;
> >break;
> >
Hello,
On Fri, Jul 03, 2009 at 07:01:37AM +0200, olafbuddenha...@gmx.net wrote:
> On Mon, Jun 29, 2009 at 09:14:56PM +0300, Sergiu Ivanov wrote:
> > Also, I'd still stand for creating a ``stand-alone'' unionmount
> > translator
>
> That's definitely still an option, but I refuse to decide on that
>From 880a92b0dc13834fc08d541a9d936e0b0b83a220 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov
Date: Thu, 18 Jun 2009 22:51:58 +0300
Subject: [PATCH] Add the ``--mount'' command line option.
* Makefile (OBJS): Add mount.o
* options.h (OPT_MOUNT, OPT_LONG_MOUNT): Define.
* options.c (argp_common_opti
Hi,
On Thu, Jun 18, 2009 at 11:14:41PM +0300, Sergiu Ivanov wrote:
> @@ -124,6 +132,13 @@ argp_parse_common_options (int key, char *arg, struct
> argp_state *state)
>ulfs_match = 0;
>break;
>
> +case OPT_MOUNT:
> + /* TODO: Improve the mountee command line parsing mech
Hi,
On Mon, Jun 29, 2009 at 09:14:56PM +0300, Sergiu Ivanov wrote:
> On Mon, Jun 29, 2009 at 01:44:41AM +0200, olafbuddenha...@gmx.net
> wrote:
> > On Wed, Jun 17, 2009 at 01:43:42AM +0200, Thomas Schwinge wrote:
> > > If only one --mount option is allowed, what about a syntax like
> > > this one
Hello,
On Mon, Jun 29, 2009 at 01:44:41AM +0200, olafbuddenha...@gmx.net wrote:
> On Wed, Jun 17, 2009 at 01:43:42AM +0200, Thomas Schwinge wrote:
> > On Mon, Jun 15, 2009 at 10:39:22PM +0300, Sergiu Ivanov wrote:
>
> > > --- a/options.c
> > > +++ b/options.c
> > > @@ -124,6 +131,13 @@ argp_parse
Hello,
On Mon, Jun 29, 2009 at 01:53:24AM +0200, olafbuddenha...@gmx.net wrote:
> On Mon, Jun 15, 2009 at 09:01:55PM +0300, Sergiu Ivanov wrote:
> > On Sat, Jun 13, 2009 at 03:53:27PM +0200, Carl Fredrik Hammar wrote:
> > > On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
>
> > > >
Hi,
On Mon, Jun 15, 2009 at 09:01:55PM +0300, Sergiu Ivanov wrote:
> On Sat, Jun 13, 2009 at 03:53:27PM +0200, Carl Fredrik Hammar wrote:
> > On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
> > > diff --git a/unionmount.c b/unionmount.c
> > > new file mode 100644
> > > index 00
Hi,
On Wed, Jun 17, 2009 at 01:43:42AM +0200, Thomas Schwinge wrote:
> On Mon, Jun 15, 2009 at 10:39:22PM +0300, Sergiu Ivanov wrote:
> > --- a/options.c
> > +++ b/options.c
> > @@ -124,6 +131,13 @@ argp_parse_common_options (int key, char *arg, struct
> > argp_state *state)
> >ulfs_matc
Hello,
On Fri, Jun 19, 2009 at 01:00:03PM +0200, Thomas Schwinge wrote:
> On Thu, Jun 18, 2009 at 11:10:19PM +0300, Sergiu Ivanov wrote:
> > On Wed, Jun 17, 2009 at 01:43:42AM +0200, Thomas Schwinge wrote:
> > > On Mon, Jun 15, 2009 at 10:39:22PM +0300, Sergiu Ivanov wrote:
> > > > * options.h (OP
Hello,
On Fri, Jun 19, 2009 at 01:18:19PM +0200, Thomas Schwinge wrote:
> On Thu, Jun 18, 2009 at 11:10:19PM +0300, Sergiu Ivanov wrote:
> > All .c files in unionfs define _GNU_SOURCE explicitly (though, true,
> > they do only #define _GNU_SOURCE /*(no 1)*/, and I've changed my new
> > patch accor
Hello!
On Thu, Jun 18, 2009 at 11:10:19PM +0300, Sergiu Ivanov wrote:
> On Wed, Jun 17, 2009 at 01:43:42AM +0200, Thomas Schwinge wrote:
> > So, instead of your version...
> >
> > [...]
> > (argp_parse_common_options): Add the code for handling option
> > ``--mount''.
> > [...]
>
Hello!
On Thu, Jun 18, 2009 at 11:10:19PM +0300, Sergiu Ivanov wrote:
> On Wed, Jun 17, 2009 at 01:43:42AM +0200, Thomas Schwinge wrote:
> > On Mon, Jun 15, 2009 at 10:39:22PM +0300, Sergiu Ivanov wrote:
> > > * options.h (OPT_MOUNT): Add the definition.
> > > (OPT_LONG_MOUNT): Likewise.
> > > Upd
>From c1c3a03c95a750c2388d7a7a443a6ff898b94b56 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov
Date: Thu, 18 Jun 2009 22:51:58 +0300
Subject: [PATCH] Add the ``--mount'' command line option.
* Makefile (OBJS): Add unionmount.o
* options.h (OPT_MOUNT, OPT_LONG_MOUNT): Define.
* options.c (argp_common
Hello,
On Wed, Jun 17, 2009 at 01:43:42AM +0200, Thomas Schwinge wrote:
> On Sat, Jun 13, 2009 at 03:53:27PM +0200, Carl Fredrik Hammar wrote:
> > On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -1,6 +1,10 @@
> > > # Hurd unionfs
>
Hello!
On Fri, Jun 12, 2009 at 04:40:12PM +0300, Sergiu Ivanov wrote:
> On Fri, Jun 12, 2009 at 08:53:50AM +0200, Carl Fredrik Hammar wrote:
> > On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
> > > >From d0f0f5c41d9046aec765a7264914c19642adead9 Mon Sep 17 00:00:00 2001
> > > From:
Hello,
On Tue, Jun 16, 2009 at 08:46:31AM +0200, Carl Fredrik Hammar wrote:
> On Mon, Jun 15, 2009 at 09:01:55PM +0300, Sergiu Ivanov wrote:
> > On Sat, Jun 13, 2009 at 03:53:27PM +0200, Carl Fredrik Hammar wrote:
> > > On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
> > > > @@ -0,0
Hi,
On Mon, Jun 15, 2009 at 09:01:55PM +0300, Sergiu Ivanov wrote:
> On Sat, Jun 13, 2009 at 03:53:27PM +0200, Carl Fredrik Hammar wrote:
> > On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
> > > diff --git a/unionmount.c b/unionmount.c
> > > new file mode 100644
> > > index 000
>From 87963e32b39b8bc8f6a29f5033d99e7f0583c5b4 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov
Date: Thu, 11 Jun 2009 15:22:24 +0300
Subject: [PATCH] Add the ``--mount'' command line option.
* Makefile: Add unionmount.c to the list of compiled
object files.
Update copyright information.
* options.h
Hello,
I'll comment only on those issues which I feel reluctant to decide on
my own.
On Sat, Jun 13, 2009 at 03:53:27PM +0200, Carl Fredrik Hammar wrote:
> On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
> > diff --git a/unionmount.c b/unionmount.c
> > new file mode 100644
> > inde
>From d0f0f5c41d9046aec765a7264914c19642adead9 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov
Date: Thu, 11 Jun 2009 15:22:24 +0300
Subject: [PATCH] Add the ``--mount'' command line option.
* Makefile: Add unionmount.c to the list of compiled
object files.
Update copyright information.
* options.h
Hi,
This time around I'll review your patch more thoroughly.
On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
> >From d0f0f5c41d9046aec765a7264914c19642adead9 Mon Sep 17 00:00:00 2001
> From: Sergiu Ivanov
> Date: Thu, 11 Jun 2009 15:22:24 +0300
> Subject: [PATCH] Add the ``--mount
Hello,
On Fri, Jun 12, 2009 at 08:53:50AM +0200, Carl Fredrik Hammar wrote:
> I skimmed through this patch and noticed some issues with the license.
>
> On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
> > >From d0f0f5c41d9046aec765a7264914c19642adead9 Mon Sep 17 00:00:00 2001
> > F
Hi,
I skimmed through this patch and noticed some issues with the license.
On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
> >From d0f0f5c41d9046aec765a7264914c19642adead9 Mon Sep 17 00:00:00 2001
> From: Sergiu Ivanov
> Date: Thu, 11 Jun 2009 15:22:24 +0300
> Subject: [PATCH] Add
>From d0f0f5c41d9046aec765a7264914c19642adead9 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov
Date: Thu, 11 Jun 2009 15:22:24 +0300
Subject: [PATCH] Add the ``--mount'' command line option.
* Makefile: Add unionmount.c to the list of compiled
object files.
Update copyright information.
* options.h
37 matches
Mail list logo
