Hello,
On Fri, Jul 17, 2009 at 04:05:42AM +0200, [email protected] wrote:
> On Tue, Jul 14, 2009 at 12:27:02PM +0300, Sergiu Ivanov wrote:
> > +
> > + /* The mountee command line converted to a 0-terminated string
> > + form. */
> > + char * mountee_cl = malloc (mountee_argz_len);
>
> [...]
> BTW, does unionfs use this style (malloc right in the variable
> definition) in other places? It's discouraged by GCS...
No, it does not. I'd suppose I was being lazy when I used such style :-(
> > +
> > + err = argz_add (argz, argz_len, opt);
> > + }
> > +
> > ulfs_iterate
> > {
> > if (! err)
>
> You forgot to free the temporary strings...
Great :-( I'll try to avoid such silly mistakes in the future.
Regards,
scolobb
