Re: [PATCH] symlink lookups in ext2fs

2001-12-08 Thread Roland McGrath
Thanks. I've put the fix in, done slightly differently. Your change introduced a new bug because it didn't make sure the buffer was large enough to hold the trailing slash. (Also, strcat makes me cringe.) I don't recall what the state of the whole trailing slash question was last time we went

Re: [PATCH] symlink lookups in ext2fs

2001-12-06 Thread Thomas Bushnell, BSG
Moritz Schulte <[EMAIL PROTECTED]> writes: > Hi, hmm, is there anything wrong with that patch? Please tell me if > that is the case, so that I can fix it. Um, well, the behavior you see is certainly inconsistent. But one problem here is that the user-level behavior is *always* supposed to be to

Re: [PATCH] symlink lookups in ext2fs

2001-12-06 Thread Moritz Schulte
Hi, hmm, is there anything wrong with that patch? Please tell me if that is the case, so that I can fix it. moritz -- [EMAIL PROTECTED] - http://duesseldorf.ccc.de/~moritz/ GPG fingerprint = 3A14 3923 15BE FD57 FC06 B501 0841 2D7B 6F98 4199 _

Re: [PATCH] symlink lookups in ext2fs

2001-12-03 Thread Moritz Schulte
Roland McGrath <[EMAIL PROTECTED]> writes: > A patch without a bug report is almost always ignored. Sorry, I thought it was obvious, since it's a little change. Here the bug, now in verbose mode: moritz@hurd:~$ touch foo moritz@hurd:~$ ln -s foo foo2 moritz@hurd:~$ ln -s $PWD/foo foo3 moritz@h

Re: [PATCH] symlink lookups in ext2fs

2001-12-03 Thread Roland McGrath
A patch without a bug report is almost always ignored. ___ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd

Re: [PATCH] symlink lookups in ext2fs

2001-12-03 Thread Thomas Bushnell, BSG
Moritz Schulte <[EMAIL PROTECTED]> writes: > Hi, > > 2001-12-03 Moritz Schulte <[EMAIL PROTECTED]> > > * libdiskfs/dir-lookup.c (diskfs_S_dir_lookup): Don't forget > the trailing slash when looking up absolute symlinks. > > --- dir-lookup.c.orig Mon Dec 3 17:35:09 2001 > +++

[PATCH] symlink lookups in ext2fs

2001-12-03 Thread Moritz Schulte
Hi, 2001-12-03 Moritz Schulte <[EMAIL PROTECTED]> * libdiskfs/dir-lookup.c (diskfs_S_dir_lookup): Don't forget the trailing slash when looking up absolute symlinks. --- dir-lookup.c.orig Mon Dec 3 17:35:09 2001 +++ dir-lookup.cMon Dec 3 17:36:04 2001 @@ -361,6 +3