[PATCH 16/17] XXX this looks wrong to me, please have a look

2013-07-11 Thread Justus Winter
--- libfshelp/start-translator-long.c |1 + 1 file changed, 1 insertion(+) diff --git a/libfshelp/start-translator-long.c b/libfshelp/start-translator-long.c index 55fb0ff..9680871 100644 --- a/libfshelp/start-translator-long.c +++ b/libfshelp/start-translator-long.c @@ -293,6 +293,7 @@ fshe

[PATCH 15/17] hurd: add fsys_get_source

2013-07-11 Thread Justus Winter
--- hurd/fsys.defs |8 1 file changed, 8 insertions(+) diff --git a/hurd/fsys.defs b/hurd/fsys.defs index 4b649d9..4f89946 100644 --- a/hurd/fsys.defs +++ b/hurd/fsys.defs @@ -135,3 +135,11 @@ routine fsys_get_children ( server: fsys_t; RPT out children: data

[PATCH 13/17] libtrivfs: add fsys_get_source

2013-07-11 Thread Justus Winter
--- libtrivfs/Makefile |4 ++-- libtrivfs/fsys-get-source.c | 34 ++ libtrivfs/get-source.c | 28 libtrivfs/trivfs.h |6 ++ 4 files changed, 70 insertions(+), 2 deletions(-) create mode 100644 libt

[PATCH 17/17] add mtab prototype

2013-07-11 Thread Justus Winter
--- trans/Makefile |8 +- trans/mtab.c | 541 2 files changed, 546 insertions(+), 3 deletions(-) create mode 100644 trans/mtab.c diff --git a/trans/Makefile b/trans/Makefile index b3210b6..6eb51d0 100644 --- a/trans/Makefile +++ b/t

[PATCH 07/17] libnetfs: add fsys_get_children

2013-07-11 Thread Justus Winter
--- libnetfs/Makefile |2 +- libnetfs/file-set-translator.c | 19 ++ libnetfs/fsys-get-children.c | 53 3 files changed, 73 insertions(+), 1 deletion(-) create mode 100644 libnetfs/fsys-get-children.c diff --git a/libnet

[PATCH 06/17] libdiskfs: add fsys_get_children

2013-07-11 Thread Justus Winter
--- libdiskfs/Makefile|3 ++- libdiskfs/dead-name.c |4 +++- libdiskfs/file-set-trans.c| 19 +++ libdiskfs/fsys-get-children.c | 51 + 4 files changed, 75 insertions(+), 2 deletions(-) create mode 100644 libdi

[PATCH 08/17] libtrivfs: add fsys_get_children

2013-07-11 Thread Justus Winter
--- libtrivfs/Makefile|3 ++- libtrivfs/fsys-get-children.c | 36 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 libtrivfs/fsys-get-children.c diff --git a/libtrivfs/Makefile b/libtrivfs/Makefile index 1c6fd5e..3163777 1

[PATCH 12/17] libnetfs: add fsys_get_source

2013-07-11 Thread Justus Winter
--- libnetfs/Makefile |4 ++-- libnetfs/fsys-get-source.c | 35 +++ libnetfs/get-source.c | 28 libnetfs/netfs.h |6 ++ 4 files changed, 71 insertions(+), 2 deletions(-) create mode 100644 libnetf

[PATCH 11/17] libdiskfs: add fsys_get_source

2013-07-11 Thread Justus Winter
--- libdiskfs/Makefile |4 ++-- libdiskfs/diskfs.h |6 ++ libdiskfs/fsys-get-source.c | 35 +++ libdiskfs/get-source.c | 29 + 4 files changed, 72 insertions(+), 2 deletions(-) create mode 100644 li

[PATCH 04/17] libnetfs: track file name in struct peropen

2013-07-11 Thread Justus Winter
--- libnetfs/dir-lookup.c |5 + libnetfs/fsys-getroot.c|6 +- libnetfs/make-peropen.c|8 libnetfs/netfs.h |2 ++ libnetfs/release-peropen.c |1 + 5 files changed, 21 insertions(+), 1 deletion(-) diff --git a/libnetfs/dir-lookup.c b/libne

[PATCH 03/17] libdiskfs: track file name in struct peropen

2013-07-11 Thread Justus Winter
--- libdiskfs/dir-lookup.c |5 + libdiskfs/diskfs.h |3 +++ libdiskfs/fsys-getroot.c |3 ++- libdiskfs/peropen-make.c |8 libdiskfs/peropen-rele.c |1 + 5 files changed, 19 insertions(+), 1 deletion(-) diff --git a/libdiskfs/dir-lookup.c b/libdiskfs/dir-lo

[PATCH 14/17] trans/symlink.c: add fsys_get_source

2013-07-11 Thread Justus Winter
--- trans/symlink.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/trans/symlink.c b/trans/symlink.c index 5e9e09a..946c950 100644 --- a/trans/symlink.c +++ b/trans/symlink.c @@ -229,3 +229,10 @@ S_fsys_get_children (mach_port_t server, { return EOPNOTSUPP; } + +error_t +S_fsys

[PATCH 05/17] libfshelp: add translator-list.c

2013-07-11 Thread Justus Winter
--- libfshelp/Makefile |3 +- libfshelp/fshelp.h | 18 ++ libfshelp/translator-list.c | 143 +++ 3 files changed, 163 insertions(+), 1 deletion(-) create mode 100644 libfshelp/translator-list.c diff --git a/libfshelp/Makefile b

[PATCH 02/17] libnetfs: fix consistency check

2013-07-11 Thread Justus Winter
passive is not a zero terminated string but a char * combined with a length. If passivelen == 0, passive may very well be not NULL, and dereferencing that pointer might not be safe. At the very least the consistency check is wrong. Fix that by checking passivelen instead of passive. * libnetfs/fil

[PATCH 10/17] hurd: add fsys_get_children

2013-07-11 Thread Justus Winter
--- hurd/fsys.defs |8 1 file changed, 8 insertions(+) diff --git a/hurd/fsys.defs b/hurd/fsys.defs index 979a6cf..4b649d9 100644 --- a/hurd/fsys.defs +++ b/hurd/fsys.defs @@ -127,3 +127,11 @@ routine fsys_get_options ( server: fsys_t; RPT out options: data_t,

[PATCH 09/17] trans/symlink.c: add fsys_get_children

2013-07-11 Thread Justus Winter
--- trans/symlink.c |8 1 file changed, 8 insertions(+) diff --git a/trans/symlink.c b/trans/symlink.c index 03b5100..5e9e09a 100644 --- a/trans/symlink.c +++ b/trans/symlink.c @@ -221,3 +221,11 @@ S_fsys_forward (mach_port_t server, mach_port_t requestor, { return EOPNOTSUPP; }

get_translator_{children,source} (v2)

2013-07-11 Thread Justus Winter
Hi, this is an updated and broken up version of my mtab prototype. [PATCH 01/17] libdiskfs: fix consistency check [PATCH 02/17] libnetfs: fix consistency check These are bug fixes. Please have a look. [PATCH 03/17] libdiskfs: track file name in struct peropen [PATCH 04/17] libnetfs: track file

[PATCH 01/17] libdiskfs: fix consistency check

2013-07-11 Thread Justus Winter
passive is not a zero terminated string but a char * combined with a length. If passivelen == 0, passive may very well be not NULL, and dereferencing that pointer might not be safe. At the very least the consistency check is wrong. Fix that by checking passivelen instead of passive. * libdiskfs/fi

Re: [PATCH 4/4] ddb: cleanup db_command.c

2013-07-11 Thread Richard Braun
On Thu, Jul 11, 2013 at 03:49:56PM +0200, Marin Ramesa wrote: > I noticed that these four patches are very similar to what was done in > XNU. Now, I don't know if they should be applied to GNU Mach, I'm not > a legal expert, so I don't know if this patches are a copyright > violation of some kin

Re: [PATCH 4/4] ddb: cleanup db_command.c

2013-07-11 Thread Marin Ramesa
On 10.07.2013 14:14:29, Marin Ramesa wrote: > Use new .h files in cleanup of db_command.c. I noticed that these four patches are very similar to what was done in XNU. Now, I don't know if they should be applied to GNU Mach, I'm not a legal expert, so I don't know if this patches are a copyright

Re: [PATCH 8/8] sysvinit: Fix getty path in /etc/inittab on Hurd.

2013-07-11 Thread Ivan Shmakov
> Justus Winter <4win...@informatik.uni-hamburg.de> writes: > Quoting Ivan Shmakov (2013-07-09 12:59:01) > Justus Winter <4win...@informatik.uni-hamburg.de> writes: […] >>> +if [ "$(uname)" = GNU ]; then >>> +sed -i -e 's|/libexec/getty|/sbin/getty|' /etc/inittab >> I don’t se