DDE - Commit fb489ff causes FTBFS

2011-06-29 Thread Stephen Gilles
Hi, I had been trying to build DDE packages for Arch Hurd for a while, and after some discussion in #hurd, we found that in hurd/incubator.git, commit fb489ff7a7989b85ae4f3c1deaf5dbf816de6545 , "drop generated files", prevents building from source. If I add 'git revert --no-edit fb489ff' to our

Re: [PATCH 15/15] Hurd signals: Use POSIX sigcodes

2011-06-29 Thread Samuel Thibault
Jérémie Koenig, le Wed 29 Jun 2011 23:17:49 +, a écrit : > On Wed, Jun 29, 2011 at 10:59 PM, Samuel Thibault > wrote: > > Jérémie Koenig, le Wed 29 Jun 2011 22:55:48 +, a écrit : > >> The old !SA_SIGINFO case was a non-standard (BSD-based?) extension. Is > >> there really anything using it

Re: [PATCH 15/15] Hurd signals: Use POSIX sigcodes

2011-06-29 Thread Jérémie Koenig
On Wed, Jun 29, 2011 at 10:59 PM, Samuel Thibault wrote: > Jérémie Koenig, le Wed 29 Jun 2011 22:55:48 +, a écrit : >> The old !SA_SIGINFO case was a non-standard (BSD-based?) extension. Is >> there really anything using it? > > You can never know.  And thus probably have to keep it. Would ma

Re: [PATCH 00/15] Hurd signals: please review

2011-06-29 Thread Jérémie Koenig
On Wed, Jun 29, 2011 at 4:30 PM, Jeremie Koenig wrote: > Hi, > > I believe my signal-related series of patches for Hurd are mature enough > to be reviewed and considered for inclusion. > (...) Samuel pointed out my ChangeLog entries were badly formatted. A version of the series with corrected com

Re: [PATCH 15/15] Hurd signals: Use POSIX sigcodes

2011-06-29 Thread Samuel Thibault
Jérémie Koenig, le Wed 29 Jun 2011 22:55:48 +, a écrit : > On Wed, Jun 29, 2011 at 10:27 PM, Samuel Thibault > wrote: > > I don't think you can do that. I'm afraid you need to keep both the old > > values for the !SA_SIGINFO case and the POSIX values for the SA_SIGINFO > > case: > > The old !

Re: [PATCH 15/15] Hurd signals: Use POSIX sigcodes

2011-06-29 Thread Jérémie Koenig
On Wed, Jun 29, 2011 at 10:27 PM, Samuel Thibault wrote: > I don't think you can do that. I'm afraid you need to keep both the old > values for the !SA_SIGINFO case and the POSIX values for the SA_SIGINFO > case: The old !SA_SIGINFO case was a non-standard (BSD-based?) extension. Is there really

Re: [PATCH 15/15] Hurd signals: Use POSIX sigcodes

2011-06-29 Thread Samuel Thibault
Jeremie Koenig, le Wed 29 Jun 2011 18:30:27 +0200, a écrit : > * sysdeps/mach/hurd/i386/bits/sigcontext.h: Remove the constants formerly > used as sigcodes. I don't think you can do that. I'm afraid you need to keep both the old values for the !SA_SIGINFO case and the POSIX values for the SA_SIGIN

[PATCH 12/15] Hurd signals: fix global untraced signals.

2011-06-29 Thread Jeremie Koenig
Delivering global signals by making them temporarily pending in the global mask looses their untracedness status, so we need to deliver them directly whenever we can. * hurd/hurdsig.c (post_signal): Attempt to find a receiver thread right away for global signals. --- hurd/hurdsig.c | 46 +++

[PATCH 07/15] Hurd signals: fix uninitialized value.

2011-06-29 Thread Jeremie Koenig
* hurd/hurdsig.c (post_signal): Don't call resume() with ACT uninitialized, as it might result in the target thread being left suspended. --- hurd/hurdsig.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hurd/hurdsig.c b/hurd/hurdsig.c index 0ec0f27..74a01a6 100644

[PATCH 10/15] Hurd signals: provide a sigstate destructor

2011-06-29 Thread Jeremie Koenig
We can no longer afford to keep stale sigstate structures in the _hurd_sigstates list if some of them are marked as global receivers, otherwise we might try to use them to deliver signals. * hurd/hurdsig.c (_hurd_sigstate_delete): New function. Remove a sigstate from the list and release its memor

[PATCH 02/15] _hurd_internal_post_signal: Scope variables more restrictively

2011-06-29 Thread Jeremie Koenig
* hurd/hurdsig.c (_hurd_internal_post_signal): Move the variable declarations into the first-level inner functions which actually use them. --- hurd/hurdsig.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/hurd/hurdsig.c b/hurd/hurdsig.c index 63418ea..320cb

[PATCH 00/15] Hurd signals: please review

2011-06-29 Thread Jeremie Koenig
Hi, I believe my signal-related series of patches for Hurd are mature enough to be reviewed and considered for inclusion. They are relatively complicated and I understand the review could take a while. It would be useful, however, if we could agree in principle on the public interfaces they intro

[PATCH 15/15] Hurd signals: Use POSIX sigcodes

2011-06-29 Thread Jeremie Koenig
* sysdeps/mach/hurd/i386/bits/sigcontext.h: Remove the constants formerly used as sigcodes. * manual/signal.texi: "GNU systems" no longer use them. * hurd/hurdinit.c (_hurd_new_proc_init): Use sigcode TRAP_TRACE for SIGTRAP on exec. * sysdeps/mach/hurd/i386/exc2signal.c (_hurd_exception2signal): Us

[PATCH 09/15] Hurd signals: implement global signal dispositions

2011-06-29 Thread Jeremie Koenig
Currently each thread has a full "sigstate" structure which keeps track of the signal dispositions, blocking mask and pending signals for this thread. Process-wide signals are delivered to the main thread. However, the semantics for POSIX threads is that all of them share the same signal dispositi

[PATCH 03/15] _hurd_internal_post_signal: Split out inner functions

2011-06-29 Thread Jeremie Koenig
By having post_signal and check_pending_signal as top-level functions, the way they communicate with the outside is made more transparent. * hurd/hurdsig.c (_hurd_internal_post_signal): Make post_signal and check_pending_signal top-level static helper functions. (check_pending_signal): Fix the gen

[PATCH 04/15] Hurd signals: refactor check_pending_signals

2011-06-29 Thread Jeremie Koenig
* hurd/hurdsig.c (check_pending_signals): Split into pending_signals, post_pending and post_all_pending_signals. (_hurd_internal_post_signal): Handle the distinction between poll requests and real signals there. --- hurd/hurdsig.c | 134 +--- 1

[PATCH 13/15] Hurd signals: Copy bits/sigaction.h

2011-06-29 Thread Jeremie Koenig
* sysdeps/mach/hurd/bits/sigaction.h: New file, start with a copy of bits/sigaction.h. --- sysdeps/mach/hurd/bits/sigaction.h | 78 1 files changed, 78 insertions(+), 0 deletions(-) create mode 100644 sysdeps/mach/hurd/bits/sigaction.h diff --git a/sysdeps/

[PATCH 14/15] Hurd signals: SA_SIGINFO support

2011-06-29 Thread Jeremie Koenig
Based on a preliminary patch by Samuel Thibault. * sysdeps/mach/hurd/bits/sigaction.h: Define SA_SIGINFO. * sysdeps/mach/hurd/i386/trampoline.c (fill_siginfo): New function, fill in a siginfo_t structure. (fill_ucontext): New function, fill in a ucontext_t structure. (_hurd_setup_sighandler): Add

[PATCH 06/15] Hurd signals: make sigsuspend POSIX-conformant.

2011-06-29 Thread Jeremie Koenig
* hurd/hurdsig.c (wake_sigsuspend): New function. (post_signal): wake up sigsuspend calls in the "handle" case. (post_signals): no longer wake up sigsuspend calls indiscriminately. --- hurd/hurdsig.c | 46 -- 1 files changed, 28 insertions(+), 18 delet

[PATCH 01/15] _hurd_internal_post_signal: Split into more functions

2011-06-29 Thread Jeremie Koenig
* hurd/hurdsig.c (_hurd_internal_post_signal): Use inner functions instead of gotos for the overall flow control. This patch should change nothing besides replacing gotos with function calls and return statements. Note that the "signo == 0" test at the beginning of post_signal, is now done on eve

[PATCH 05/15] Hurd signals: reindent

2011-06-29 Thread Jeremie Koenig
* hurd/hurdsig.c (post_pending): reindent. --- hurd/hurdsig.c | 64 1 files changed, 32 insertions(+), 32 deletions(-) diff --git a/hurd/hurdsig.c b/hurd/hurdsig.c index 2715d37..c8cae6a 100644 --- a/hurd/hurdsig.c +++ b/hurd/hurdsig.c @@

[PATCH 11/15] Hurd signals: fix sigwait() for global signals

2011-06-29 Thread Jeremie Koenig
* sysdeps/mach/hurd/sigwait.c (__sigwait): Change the blocking mask temporarily so that we catch global as well as thread-specific signals. --- sysdeps/mach/hurd/sigwait.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/sysdeps/mach/hurd/sigwait.c b/sysdeps/mach

[PATCH 08/15] Versions.def: add GLIBC_2.15

2011-06-29 Thread Jeremie Koenig
* Versions.def: add GLIBC_2.15 --- Versions.def |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Versions.def b/Versions.def index 666ea73..98c2800 100644 --- a/Versions.def +++ b/Versions.def @@ -31,6 +31,7 @@ libc { GLIBC_2.12 GLIBC_2.13 GLIBC_2.14 + GLIBC_2.15