Re: test-poll vs ioctl

2008-10-21 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Sure, that's due to the missing dependency to 'ioctl' in modules/poll-tests > and modules/select-tests. When you add that dependency, as you said in your > previous mail, compilation works fine. Ah, I forgot these... > To get out of this confusion, I'm

Re: test-poll vs ioctl

2008-10-21 Thread Bruno Haible
Hi Simon, > >> The current situation breaks simple test-cases like this: > >> > >> rm -rf m;gnulib-tool --create-testdir --with-tests --dir m poll; cd m; > >> ./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu; make check; > >> cd .. > >> > >> Regardless of the solution, I think the

Re: test-poll vs ioctl

2008-10-21 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> The current situation breaks simple test-cases like this: >> >> rm -rf m;gnulib-tool --create-testdir --with-tests --dir m poll; cd m; >> ./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu; make check; >> cd .. >>

Re: test-poll vs ioctl

2008-10-20 Thread Paolo Bonzini
> a) Rename winsock.c to w32sock.h. > Create a file connect.c containing > >#define GNULIB_CONNECT 1 >#include "w32sock.h" > > and similarly for the other modules that make up winsock.c. > > Remove the gl_MODULE_INDICATOR([$1]) line from the definition of >

Re: test-poll vs ioctl

2008-10-20 Thread Bruno Haible
Simon Josefsson wrote: > The current situation breaks simple test-cases like this: > > rm -rf m;gnulib-tool --create-testdir --with-tests --dir m poll; cd m; > ./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu; make check; cd > .. > > Regardless of the solution, I think the above co

Re: test-poll vs ioctl

2008-10-20 Thread Simon Josefsson
Paolo Bonzini <[EMAIL PROTECTED]> writes: >> There is no -I for the $gltests/ directory in $gl/, so this fails. >> >> I think the ioctl replacement function should be moved out from >> winsock.c to a new ioctl.c. >> >> What do you think of the patch below? > > Before applying something like this

Re: test-poll vs ioctl

2008-10-20 Thread Paolo Bonzini
> There is no -I for the $gltests/ directory in $gl/, so this fails. > > I think the ioctl replacement function should be moved out from > winsock.c to a new ioctl.c. > > What do you think of the patch below? Before applying something like this, it would make sense to understand if the root pro

test-poll vs ioctl

2008-10-20 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > This defines a module for the 'ioctl' function, and moves its declaration > from to . The poll-tests module uses sys/ioctl.h and ioctl, even though poll doesn't need them, so I added these modules to the poll-tests module dependencies. However that doe