[PATCH v2 0/3] quotearg improvements

2011-12-20 Thread bonzini
From: Paolo Bonzini Here is what I'm pushing. Thanks for the remarks. I'll follow-up patching standards.texi. These patches implement the quoting standard that has been in use for seven years in GCC. In UTF-8 and GB-18030 locales, the second replaces quotes with the Unicode LEFT SINGLE QUOTAT

Re: [PATCH 0/4] quotearg improvements

2011-12-19 Thread Paolo Bonzini
On Tue, Dec 20, 2011 at 01:22, Bruno Haible wrote: > > I am very fond of my ` characters and hate the fact that stupid > > standards broke what was the obviously useful thing to do ... > > I don't know what you consider to be the "obviously useful thing". > I find Markus Kuhn's write-ups at > htt

Re: [PATCH 0/4] quotearg improvements

2011-12-19 Thread Bruno Haible
Hi Karl, > > In non-Unicode locales, the left-pointing > > grave accent is replaced by the closing quote. > > > > I am very fond of my ` characters and hate the fact that stupid > > standards broke what was the obviously useful thing to do ... > > I don't kn

Re: [PATCH 0/4] quotearg improvements

2011-12-19 Thread Karl Berry
very convincing. I find the tone quite high-handed. But never mind. I don't want to debate Markus' web pages, it's not germane. Now, in this particular case, GCC has been doing the experiment: I know. And no one I've seen has complained about it (even me; not that I'm happy about it,

Re: [PATCH 0/4] quotearg improvements

2011-12-19 Thread Bruno Haible
Hi Karl, > In non-Unicode locales, the left-pointing > grave accent is replaced by the closing quote. > > I am very fond of my ` characters and hate the fact that stupid > standards broke what was the obviously useful thing to do ... I don't know what you consider to be the "obviously

Re: [PATCH 0/4] quotearg improvements

2011-12-19 Thread Karl Berry
In non-Unicode locales, the left-pointing grave accent is replaced by the closing quote. I am very fond of my ` characters and hate the fact that stupid standards broke what was the obviously useful thing to do ... but have nothing substantive to add to the discussion. If the patch

Re: [PATCH 0/4] quotearg improvements

2011-12-19 Thread Paolo Bonzini
On 12/19/2011 09:11 AM, Paolo Bonzini wrote: For more information, seehttp://www.cl.cam.ac.uk/~mgk25/ucs/apostrophe.html Oops, see http://www.cl.cam.ac.uk/~mgk25/ucs/quotes.html :) Paolo

[PATCH 0/4] quotearg improvements

2011-12-19 Thread Paolo Bonzini
From: Paolo Bonzini The first two patches are improvement in documentation. The first fixes a broken link, the second avoids the distinction between British and American locales: most people are unaware of the different typographic conventions and also there is usually no English translation fil

Re: quotearg and trigraphs [was: quotearg improvements]

2008-02-16 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 2/13/2008 9:50 PM: | Independently of whether c_maybe_quoting_style makes sense as the | recommended style for error messages, what do people think about this | patch? I'll install in a couple of days unless I get a review

quotearg and trigraphs [was: quotearg improvements]

2008-02-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 2/13/2008 8:57 PM: | Because the quotearg module _already_ did trigraph quoting (try ls | --quoting-style=c for an example). The question is whether the new | c_maybe style (or if we come up with a better name for it), desi

Re: quotearg improvements [was: filenames in error messages]

2008-02-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Karl Berry on 2/13/2008 7:18 PM: | In a nutshell, if the source file name contains : or \ or " or any | control character, we enclose it in quotes and escape as needed. | Otherwise, no quotes needed. Wdyt? If my QA_SPLIT_TRIGRAPHS patch

Re: quotearg improvements [was: filenames in error messages]

2008-02-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 2/13/2008 8:13 PM: | Sorry, but you lost me here. Where did the C trigraphs come into play? Because the quotearg module _already_ did trigraph quoting (try ls - --quoting-style=c for an example). The question is whether

Re: quotearg improvements [was: filenames in error messages]

2008-02-13 Thread Bruno Haible
Eric Blake wrote: > Consider the original filename of `dir??/file'. Before my patch, the > c_quoting_style converted it to `"dir?\?/file"', since `??/' is a trigraph > for `\', but that is not a valid C string. Right now, the output is > `"dir?""?/file"', i.e. two concatenated C strings, so that

Re: quotearg improvements [was: filenames in error messages]

2008-02-13 Thread Karl Berry
Consider the original filename of `dir??/file'. Thanks, I see now. Now I think rms's implicit desire not to map this too strongly to C strings is a a good thing. The goal is to make it easy/unambiguous for programs like Emacs to parse the filenames out of the message. Doing full parsing o

Re: quotearg improvements [was: filenames in error messages]

2008-02-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Karl Berry on 2/13/2008 5:45 PM: | | the "c" quoting style now outputs "\"?\"\"?/\"" | ("?""?/") rather than "\"?\\?/\"" ("?\?/"), | | Sorry, I'm not following this. What's the original filename? Consider the original filename o

Re: quotearg improvements [was: filenames in error messages]

2008-02-13 Thread Karl Berry
quotearg_colon("a:b") should result in "\"a:b\"" ("a:b") rather than "\"a\\:b\"" ("a\:b") (ie. keep the displayed output as a valid C string literal Definitely desirable. the "c" quoting style now outputs "\"?\"\"?/\"" ("?""?/") rather than "\"?\\?/\"" ("?\?/"), Sorry, I'm n

Re: quotearg improvements

2008-02-13 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > present in . When coupled with your warning fixes, does this > work for you instead? Yep. Thanks.

Re: quotearg improvements

2008-02-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 2/13/2008 4:00 AM: | I noticed that something about these changes causes | trouble with coreutils builds (albeit merely because it | runs the new test-quotearg program from gnulib): Aargh. I tested ENABLE_NLS on cygwin,

Re: quotearg improvements

2008-02-13 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > I'm committing these three patches as is, plus a fourth. This patch adds ... Hi Eric, Thanks for doing that. I noticed that something about these changes causes trouble with coreutils builds (albeit merely because it runs the new test-quotearg program from

quotearg improvements [was: filenames in error messages]

2008-02-12 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 2/7/2008 5:22 PM: | | 2008-02-07 Eric Blake <[EMAIL PROTECTED]> | | Quotearg part 3: add flag to control outer quote elision. | * lib/quotearg.h (c_maybe_quoting_style): New style. | (enum quoting_flags):