Re: pwrite module

2010-05-18 Thread Peter O'Gorman
On Tue, May 18, 2010 at 08:36:28PM +0200, Simon Josefsson wrote: > The pwrite self-test fails under Cygwin, is this a known issue? No :) > > http://autobuild.josefsson.org/gnulib/log-201005172227940062000.txt Hmm, it succeeds writing a byte at (off_t)-1? I guess you end up with a very large spa

Re: pwrite module

2010-05-18 Thread Simon Josefsson
The pwrite self-test fails under Cygwin, is this a known issue? http://autobuild.josefsson.org/gnulib/log-201005172227940062000.txt /Simon

Re: pwrite module

2010-05-10 Thread Peter O'Gorman
On Tue, May 11, 2010 at 12:57:20AM +0200, Bruno Haible wrote: > Hi Peter, > > > Attached. Also noticed that I declare read_buf, but never use it > > Thanks, I applied it, only fixing up the ChangeLog entries (wrong file names). Oh, bah! Thank you! > > > (good job, really, as it's one byte too

Re: pwrite module

2010-05-10 Thread Bruno Haible
Hi Peter, > Attached. Also noticed that I declare read_buf, but never use it Thanks, I applied it, only fixing up the ChangeLog entries (wrong file names). > (good job, really, as it's one byte too short). Huh? No, it had the right size. When you call read() with argument N, the buffer has to b

Re: pwrite module

2010-05-10 Thread Peter O'Gorman
On Sat, May 08, 2010 at 10:04:44AM +0200, Bruno Haible wrote: > Peter O'Gorman wrote: > > The Written Word, Inc. already has an assignment for gnulib. Look for > > 'GNULIB The Written Word' in copyright.list. > > Yes, indeed. It wasn't clear to me whether the patch was owned by you or > by The Wr

Re: pwrite module

2010-05-08 Thread Bruno Haible
Peter O'Gorman wrote: > The Written Word, Inc. already has an assignment for gnulib. Look for > 'GNULIB The Written Word' in copyright.list. Yes, indeed. It wasn't clear to me whether the patch was owned by you or by The Written Word. > > - tests/test-pwrite.sh: Removed the pipe, since the test

Re: pwrite module

2010-05-07 Thread Peter O'Gorman
On Wed, May 05, 2010 at 09:43:56PM +0200, Bruno Haible wrote: > Hi Peter, > > > There is a pread module, but no pwrite. This is a mostly mechanical > > patch, copying the pread bits and s/read/write/ and copying pwrite.c > > from glibc. > > Thanks. I committed this in your name. Thank you for fi

Re: pwrite module

2010-05-05 Thread Bruno Haible
Hi Peter, > There is a pread module, but no pwrite. This is a mostly mechanical > patch, copying the pread bits and s/read/write/ and copying pwrite.c > from glibc. Thanks. I committed this in your name. You certainly hate paperwork as much as I do. I don't see a copyright assignment for you and

pwrite module

2010-05-05 Thread Peter O'Gorman
Hi, There is a pread module, but no pwrite. This is a mostly mechanical patch, copying the pread bits and s/read/write/ and copying pwrite.c from glibc. 2010-05-05 Peter O'Gorman New module pwrite * doc/posix-functions/pread.texi: Mention gnulib module. * doc/posix-fun