On Sat, May 08, 2010 at 10:04:44AM +0200, Bruno Haible wrote:
> Peter O'Gorman wrote:
> > The Written Word, Inc. already has an assignment for gnulib. Look for
> > 'GNULIB The Written Word' in copyright.list.
>
> Yes, indeed. It wasn't clear to me whether the patch was owned by you or
> by The Written Word.
>
> > > - tests/test-pwrite.sh: Removed the pipe, since the test program does not
> > > access stdin. This file could be removed now, leaving only
> > > test-pwrite.c.
>
> Would you like to submit a patch that removes the unnecessary file?
Attached. Also noticed that I declare read_buf, but never use it (good
job, really, as it's one byte too short).
Peter
--
Peter O'Gorman
po...@thewrittenword.com
>From 336a9f419541dfb2cf917cded9b486feace10e26 Mon Sep 17 00:00:00 2001
From: Peter O'Gorman <po...@thor.il.thewrittenword.com>
Date: Mon, 10 May 2010 14:58:57 +0000
Subject: [PATCH 1/2] Remove useless test-pwrite.sh file.
* test/test-pwrite.sh: Delete file.
* module/pwrite-tests: Remove references.
---
ChangeLog | 6 ++++++
modules/pwrite-tests | 3 +--
tests/test-pwrite.sh | 7 -------
3 files changed, 7 insertions(+), 9 deletions(-)
delete mode 100644 tests/test-pwrite.sh
diff --git a/ChangeLog b/ChangeLog
index 5510f68..03f174e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-05-10 Peter O'Gorman <po...@thewrittenword.com>
+
+ Remove useless test-pwrite.sh file.
+ * test/test-pwrite.sh: Delete file.
+ * module/pwrite-tests: Remove references.
+
2010-05-10 Jim Meyering <meyer...@redhat.com>
maint.mk: avoid using a temporary file in the always-defined-macros
check
diff --git a/modules/pwrite-tests b/modules/pwrite-tests
index 6249a8e..5654822 100644
--- a/modules/pwrite-tests
+++ b/modules/pwrite-tests
@@ -1,5 +1,4 @@
Files:
-tests/test-pwrite.sh
tests/test-pwrite.c
tests/init.sh
tests/signature.h
@@ -10,5 +9,5 @@ Depends-on:
configure.ac:
Makefile.am:
-TESTS += test-pwrite.sh
+TESTS += test-pwrite
check_PROGRAMS += test-pwrite
diff --git a/tests/test-pwrite.sh b/tests/test-pwrite.sh
deleted file mode 100644
index 94f0f38..0000000
--- a/tests/test-pwrite.sh
+++ /dev/null
@@ -1,7 +0,0 @@
-#!/bin/sh
-. "${srcdir=.}/init.sh"; path_prepend_ .
-
-fail=0
-test-pwrite || fail=1
-
-Exit $fail
--
1.6.3.3
>From 40c9ad1465f95758743cfafe9454010749e6b2ac Mon Sep 17 00:00:00 2001
From: Peter O'Gorman <po...@thor.il.thewrittenword.com>
Date: Mon, 10 May 2010 15:02:30 +0000
Subject: [PATCH 2/2] test-pwrite.c: Remove unused variable declaration.
* test/test-pwrite.c: Remove read_buf declaration.
---
ChangeLog | 3 +++
tests/test-pwrite.c | 1 -
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 03f174e..fb0804f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
2010-05-10 Peter O'Gorman <po...@thewrittenword.com>
+ test-pwrite.c: Remove unused variable declaration.
+ * test/test-pwrite.c: Remove read_buf declaration.
+
Remove useless test-pwrite.sh file.
* test/test-pwrite.sh: Delete file.
* module/pwrite-tests: Remove references.
diff --git a/tests/test-pwrite.c b/tests/test-pwrite.c
index 073f6a3..549be10 100644
--- a/tests/test-pwrite.c
+++ b/tests/test-pwrite.c
@@ -69,7 +69,6 @@ main (void)
ASSERT (close (fd) == 0);
{
- char read_buf[N];
fd = open (file, O_RDONLY);
ASSERT (0 <= fd);
ASSERT (read (fd, buf, N) == N);
--
1.6.3.3
