Re: proposed patch for bootstrap

2011-04-06 Thread Gary V. Vaughan
Howdy Bruce! On Wed, Apr 06, 2011 at 10:28:28AM -0700, Bruce Korb wrote: > On 04/06/11 09:50, Gary V. Vaughan wrote: > >>1. gnulib_non_module_files ought to be dependent upon not being set > >> by bootstrap.conf (as is the case), but also $build_aux. > >> if configure.ac or bootstrap.conf

Re: proposed patch for bootstrap

2011-04-06 Thread Bruce Korb
On 04/06/11 09:50, Gary V. Vaughan wrote: I'd suggest a couple of tweaks: 1. gnulib_non_module_files ought to be dependent upon not being set by bootstrap.conf (as is the case), but also $build_aux. if configure.ac or bootstrap.conf changes it, this variable will not be correct.

Re: proposed patch for bootstrap

2011-04-06 Thread Gary V. Vaughan
Howdy Bruce! On Wed, Apr 06, 2011 at 08:41:43AM -0700, Bruce Korb wrote: > On 04/05/11 21:06, Gary V. Vaughan wrote: > >AFAICT, very little (if anything) remains to be done short of actually > >commiting it to the repository. I did stall on the horrid slurp function > >shared among a few projects

Re: proposed patch for bootstrap

2011-04-06 Thread Bruce Korb
On 04/05/11 21:06, Gary V. Vaughan wrote: AFAICT, very little (if anything) remains to be done short of actually commiting it to the repository. I did stall on the horrid slurp function shared among a few projects with slight divergences, but that is an issue for bootstrap.conf files (if they hav

Re: proposed patch for bootstrap

2011-04-05 Thread Bruce Korb
On 04/05/11 13:40, Eric Blake wrote: The order-that-I-put-them-in rule. In general, I think I understand stuff better than a computer, so why am I being over-ruled? I tend to like sorted files (if nothing else, the human brain is much better at finding lines in a sorted file than a random one,

Re: proposed patch for bootstrap

2011-04-05 Thread Eric Blake
On 04/05/2011 02:19 PM, Bruce Korb wrote: >> What order-dependent sorting rules do you have, that would not already >> be covered by sinking ! lines to the bottom of the .gitignore file per >> the patch I just posted there? > > The order-that-I-put-them-in rule. In general, I think I understand >

Re: proposed patch for bootstrap

2011-04-05 Thread Bruce Korb
On 04/05/11 12:58, Eric Blake wrote: On 04/05/2011 01:19 PM, Bruce Korb wrote: This fixes two things: 1. "gnulib_extra_files" should not be computed before sourcing the bootstrap.conf file, unless you intend that overriding build_aux forces overriding gnulib_extra_files, too. I don't t

Re: proposed patch for bootstrap

2011-04-05 Thread Eric Blake
On 04/05/2011 01:19 PM, Bruce Korb wrote: > This fixes two things: > > 1. "gnulib_extra_files" should not be computed before sourcing the >bootstrap.conf file, unless you intend that overriding build_aux >forces overriding gnulib_extra_files, too. I don't think so, so >I deferred its

proposed patch for bootstrap

2011-04-05 Thread Bruce Korb
This fixes two things: 1. "gnulib_extra_files" should not be computed before sourcing the bootstrap.conf file, unless you intend that overriding build_aux forces overriding gnulib_extra_files, too. I don't think so, so I deferred its computation until afterward. 2. I also ran into a pr