On 04/05/2011 01:19 PM, Bruce Korb wrote: > This fixes two things: > > 1. "gnulib_extra_files" should not be computed before sourcing the > bootstrap.conf file, unless you intend that overriding build_aux > forces overriding gnulib_extra_files, too. I don't think so, so > I deferred its computation until afterward. > > 2. I also ran into a problem with auto-sorting of an order-dependent > file. Below simply appends a file name if it is not found, leaving > the original order above the newly inserted entry. Changed the > function name, too.
These should be split into two separate commits, since they touch two separate issues. I think I'm okay with your resolution for the first issue. However, > > If approved, I'll make it an official patch with two commits and > ChangeLog entries. your solution for the second issue conflicts with my proposed patch for: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/25869 What order-dependent sorting rules do you have, that would not already be covered by sinking ! lines to the bottom of the .gitignore file per the patch I just posted there? -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
