Re: program_name in error.c

2006-09-09 Thread Sergey Poznyakoff
Eric Blake <[EMAIL PROTECTED]> wrote: > Careful. error.c is (mostly) synced upstream with glibc (right now, all > but the comments and a couple of #include order issues), but this would > widen the gap. Yes, I see that the matter is not as simple as it seemed at the first glance. > As it is, er

Re: [bug-gnulib] program_name in error.c

2006-09-09 Thread Bruno Haible
Sergey Poznyakoff wrote: > If it is called before argp_parse it will > surely coredump. But then, we cannot guarantee that whoever is using > this interface will set program_name before calling error(), can we? We need to document it somewhere, in error.h or argp.h. Bruno

Re: [bug-gnulib] program_name in error.c

2006-09-09 Thread Sergey Poznyakoff
Bruno Haible <[EMAIL PROTECTED]> wrote: > - Why do you use HAVE_PROGRAM_INVOCATION_NAME here, whereas argp.m4 > defines GNULIB_PROGRAM_INVOCATION_NAME ? Yes, I meant GNULIB_PROGRAM_INVOCATION_NAME, of course. > - If the #ifdef condition is true, you'll be using the > program_invocation_name

Re: program_name in error.c

2006-09-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Sergey Poznyakoff on 9/8/2006 11:42 PM: > Hello, > > I'd like to install the following change to error.c in order to > better cooperate with argp. Any objections? Careful. error.c is (mostly) synced upstream with glibc (right now, all

Re: [bug-gnulib] program_name in error.c

2006-09-09 Thread Bruno Haible
Sergey Poznyakoff wrote: > --- error.c 29 Aug 2006 16:58:34 - 1.46 > +++ error.c 9 Sep 2006 05:39:50 - > @@ -92,9 +92,13 @@ extern void __error_at_line (int status, > char *strerror_r (); > # endif > > +#ifdef HAVE_PROGRAM_INVOCATION_NAME > +# define program_name program_invoca

program_name in error.c

2006-09-08 Thread Sergey Poznyakoff
Hello, I'd like to install the following change to error.c in order to better cooperate with argp. Any objections? Regards, Sergey Index: error.c === RCS file: /cvsroot/gnulib/gnulib/lib/error.c,v retrieving revision 1.46 diff -p -