Eric Blake wrote on 2009-12-31:
> * lib/spawn.in.h (posix_spawn, posix_spawnp, posix_spawnattr_init)
> (posix_spawnattr_destroy, posix_spawnattr_getsigdefault)
> (posix_spawnattr_setsigdefault, posix_spawnattr_getsigmask)
> (posix_spawnattr_setsigmask, posix_spawnattr_getflags)
> (posix_spawnattr_s
Eric Blake wrote on 2009-12-31:
> Date: Thu, 24 Dec 2009 12:06:48 -0700
> Subject: [PATCH 4/4] link-warning: always build headers with link warnings
>
> Replacement headers must be built unconditionally if they use
> GL_LINK_WARNING, if the warning is to ever trigger on a
> glibc system during CFL
Eric Blake wrote:
> >> + headers: make check of system header explicit
> >> + * m4/netdb_h.m4 (gl_HEADER_NETDB): Don't exploit knowledge of
> >> + gl_CHECK_NEXT_HEADER internals, but call AC_CHECK_HEADERS_ONCE
> >> + ourselves.
> >
> > This looks fine.
>
> Pushed (after rebasing to pick up the
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 1/1/2010 5:47 AM:
> Eric Blake wrote:
>> +2009-12-31 Eric Blake
>> +
>> +headers: make check of system header explicit
>> +* m4/netdb_h.m4 (gl_HEADER_NETDB): Don't exploit knowledge of
>> +gl_CHECK_NEXT_HEADE
Eric Blake wrote:
> +2009-12-31 Eric Blake
> +
> + headers: make check of system header explicit
> + * m4/netdb_h.m4 (gl_HEADER_NETDB): Don't exploit knowledge of
> + gl_CHECK_NEXT_HEADER internals, but call AC_CHECK_HEADERS_ONCE
> + ourselves.
> + * m4/search_h.m4 (gl_SEARCH
Eric Blake byu.net> writes:
> > Reducing two invocations of AC_CHECK_HEADERS_ONCE to a single one will
> > IMO not bring large benefits.
>
> Then how about a patch in the converse direction, that ensures
> AC_CHECK_HEADERS_ONCE is called prior to any use of ac_cv_header_xxx_h,
rather
> than t
Bruno Haible clisp.org> writes:
> > gl_CHECK_NEXT_HEADERS invokes AC_CHECK_HEADERS under the hood.
>
> Well, it does, but it's not documented. It's an abstraction violation to
> exploit this knowledge (even though we do in some places).
>
> > That means several other .m4 file can probably be si
Eric Blake wrote:
> gl_CHECK_NEXT_HEADERS invokes AC_CHECK_HEADERS under the hood.
Well, it does, but it's not documented. It's an abstraction violation to
exploit this knowledge (even though we do in some places).
> That means several other .m4 file can probably be simplified:
Reducing two invo
Eric Blake wrote:
> But your fix is also incomplete. For example:
>
> > --- 306,315
> >__THROW _GL_ARG_NONNULL ((1, 2));
> > # endif
> > #elif defined GNULIB_POSIXCHECK
> > ! # undef posix_spawnattr_getflags
> > ! # define posix_spawnattr_getflags(a, b) \
Eric Blake byu.net> writes:
> Huh. gl_CHECK_NEXT_HEADERS invokes AC_CHECK_HEADERS under the hood. That
> means several other .m4 file can probably be simplified:
>
Here's what I came up with:
From: Eric Blake
Date: Thu, 31 Dec 2009 14:35:32 -0700
Subject: [PATCH 1/2] spawn: yet more fixes
Eric Blake wrote:
> + * modules/arpa_inet (Makefile.am): Always build replacement
> + header.
> + * modules/ctype (Makefile.am): Likewise.
> + * modules/dirent (Makefile.am): Likewise.
> + * modules/inttypes (Makefile.am): Likewise.
> + * modules/langinfo (Makefi
Bruno Haible clisp.org> writes:
> Some further updates of the gl_REPLACE_*_H macros and comments. I think
> these gl_REPLACE_*_H macros should be kept; we don't know how the idioms
> will evolve in the future.
Nice. In writing my patch, I had noticed that some shell variables (like
WCHAR_H) we
Bruno Haible clisp.org> writes:
>
> Eric Blake wrote:
> > + * m4/sys_select_h.m4 (gl_HEADER_SYS_SELECT): Likewise.
>
> Your patch reordered the statements in such a way that
ac_cv_header_sys_select_h
> can be tested before it is computed. This fixes it.
Thanks for catching that.
Huh.
Eric Blake wrote:
> + * m4/arpa_inet_h.m4 (gl_HEADER_ARPA_INET)
> + (gl_ARPA_INET_H_DEFAULTS): Drop unneeded variable.
> + * m4/ctype.m4 (gl_CTYPE_H_DEFAULTS): Likewise.
> + * m4/isblank.m4 (gl_FUNC_ISBLANK): Likewise.
> + * m4/dirent_h.m4 (gl_REPLACE_DIRENT_H, gl_DIRE
Bruno Haible clisp.org> writes:
> Looks like some part of this patch was misapplied:
posix_spawnattr_getsigdefault
> gets a link warning twice, and some others under the wrong #elif. I'm applying
> this fix:
But your fix is also incomplete. For example:
> --- 306,315
>__THROW _GL
Eric Blake wrote:
> + * m4/sys_select_h.m4 (gl_HEADER_SYS_SELECT): Likewise.
Your patch reordered the statements in such a way that ac_cv_header_sys_select_h
can be tested before it is computed. This fixes it.
2009-12-31 Bruno Haible
* m4/sys_select_h.m4 (gl_HEADER_SYS_SELECT):
Eric Blake wrote:
> + * m4/sys_utsname_h.m4 (gl_SYS_UTSNAME_H)
> + (gl_SYS_UTSNAME_H_DEFAULTS): Likewise.
The patch you committed lacked the modification corresponding to the second
ChangeLog line. I'm adding it:
2009-12-31 Bruno Haible
* m4/sys_utsname_h.m4 (gl_SYS_UTSNA
Bruno Haible clisp.org> writes:
> Eric Blake wrote:
> > + * tests/test-signal.c (main): Enhance test.
>
> One part of this does not look right. OK to remove this?
Yes - I spotted that earlier this morning, and it was already in my queue (one
too many copy-n-paste). But if you push befor
Eric Blake wrote:
> + * tests/test-signal.c (main): Enhance test.
One part of this does not look right. OK to remove this?
*** tests/test-signal.c.origThu Dec 31 22:18:46 2009
--- tests/test-signal.c Thu Dec 31 22:18:31 2009
***
*** 110,118
#ifdef SIGXFSZ
case
Eric Blake wrote:
> * lib/spawn.in.h (posix_spawn, posix_spawnp, posix_spawnattr_init)
> (posix_spawnattr_destroy, posix_spawnattr_getsigdefault)
> (posix_spawnattr_setsigdefault, posix_spawnattr_getsigmask)
> (posix_spawnattr_setsigmask, posix_spawnattr_getflags)
> (posix_spawnattr_setflags, posix
Eric Blake wrote:
> 2009-12-31 Eric Blake
>
> + sys_times, sys_utsname: use include_next
> + * m4/sys_times_h.m4 (gl_SYS_TIMES_H): Support wrapping an existing
> + header.
> + (gl_SYS_TIMES_H_DEFAULTS): Add another variable.
> + * m4/sys_utsname_h.m4 (gl_SYS_UTSNA
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 12/24/2009 1:46 PM:
> Eric Blake wrote:
>> Any objections to a patch that
>> makes replacement of these headers unconditional, so that
>> GNULIB_POSIXCHECK will work better?
>>
>
> modules/spawn and modules/sys_times will
Eric Blake wrote:
> Any objections to a patch that
> makes replacement of these headers unconditional, so that
> GNULIB_POSIXCHECK will work better?
>
> modules/arpa_inet:BUILT_SOURCES += $(ARPA_INET_H)
> modules/ctype:BUILT_SOURCES += $(CTYPE_H)
> modules/dirent:BUILT_SOURCES += $(DIRENT_H)
> mod
Eric Blake wrote:
> I've noticed that several modules use link-warning, but only conditionally
> build the replacement header. The simplest example of this is isblank and
> ctype.in.h - since the only thing in that file that used GL_LINK_WARNING
> was isblank, but glibc includes isblank, the repla
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I've noticed that several modules use link-warning, but only conditionally
build the replacement header. The simplest example of this is isblank and
ctype.in.h - since the only thing in that file that used GL_LINK_WARNING
was isblank, but glibc includ
25 matches
Mail list logo
