Eric Blake wrote: > I've noticed that several modules use link-warning, but only conditionally > build the replacement header. The simplest example of this is isblank and > ctype.in.h - since the only thing in that file that used GL_LINK_WARNING > was isblank, but glibc includes isblank, the replacement ctype.in.h is not > built and you can use isblank on a glibc system without realizing the > portability pitfall, even if you do CFLAGS=-DGNULIB_POSIXCHECK.
This is a fine improvement. Thanks! > Here's the full list of suspect modules. Any objections to a patch that > makes replacement of these headers unconditional, so that > GNULIB_POSIXCHECK will work better? None from me. > modules/arpa_inet:BUILT_SOURCES += $(ARPA_INET_H) > modules/ctype:BUILT_SOURCES += $(CTYPE_H) > modules/dirent:BUILT_SOURCES += $(DIRENT_H) > modules/inttypes:BUILT_SOURCES += $(INTTYPES_H) > modules/spawn:BUILT_SOURCES += $(SPAWN_H) > modules/sys_file:BUILT_SOURCES += $(SYS_FILE_H) > modules/sys_ioctl:BUILT_SOURCES += $(SYS_IOCTL_H) > modules/sys_select:BUILT_SOURCES += $(SYS_SELECT_H) > modules/sys_socket:BUILT_SOURCES += $(SYS_SOCKET_H) > modules/sys_times:BUILT_SOURCES += $(SYS_TIMES_H) > modules/sys_utsname:BUILT_SOURCES += $(SYS_UTSNAME_H) > modules/sys_wait:BUILT_SOURCES += $(SYS_WAIT_H) > modules/wchar:BUILT_SOURCES += $(WCHAR_H)
