Re: gnulib-tool.py: Simplify joining paths.

2024-06-15 Thread Bruno Haible
Hi Collin, > Agreed, I reverted that patch and pushed it before it causes any > trouble [1]. Thanks! > Do you still expect GNULIB_TOOL_IMPL=sh+py to pass by the way? Sure. We need to give users a year, at least, for migrating from the shell to the Python implementation. And when they migrate, i

Re: gnulib-tool.py: Simplify joining paths.

2024-06-15 Thread Collin Funk
Bruno Haible wrote: > Yes, that's my point. Instead of using unnormalized file names nearly > everywhere and normalized file names only in a few places, it is better > to use normalized file names nearly everywhere and unnormalized file names > only in a few places. It causes fewer bugs and less he

Re: gnulib-tool.py: Simplify joining paths.

2024-06-15 Thread Bruno Haible
Collin Funk wrote: > But I am still confused about what the point of 'newtail' is: > > def joinpath(head: str, *tail: str) -> str: > '''Join two or more pathname components, inserting '/' as needed. If any > component is an absolute path, all previous path components will be > discarde

Re: gnulib-tool.py: Simplify joining paths.

2024-06-15 Thread Collin Funk
Bruno Haible wrote: >> I never really looked at the joinpath() function so I just realized it >> essentially does os.path.normpath(os.path.join(...)) unlike what it's >> doc string says. > > "unlike what the doc string says"? What do you mean by that? The doc string > said "This function also repl

Re: gnulib-tool.py: Simplify joining paths.

2024-06-15 Thread Bruno Haible
Hi Collin, > I never really looked at the joinpath() function so I just realized it > essentially does os.path.normpath(os.path.join(...)) unlike what it's > doc string says. "unlike what the doc string says"? What do you mean by that? The doc string said "This function also replaces SUBDIR/../ w

gnulib-tool.py: Simplify joining paths.

2024-06-14 Thread Collin Funk
houldn't cause any issues building. CollinFrom 790206bfe741d1280b0b5734a0d4070b26a885ab Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Fri, 14 Jun 2024 21:55:48 -0700 Subject: [PATCH] gnulib-tool.py: Simplify joining paths. * pygnulib/constants.py (joinpath): Remove function. It is equival