Hi Collin, > Agreed, I reverted that patch and pushed it before it causes any > trouble [1].
Thanks! > Do you still expect GNULIB_TOOL_IMPL=sh+py to pass by the way? Sure. We need to give users a year, at least, for migrating from the shell to the Python implementation. And when they migrate, it should be a no-op for them. > I still think it would be nice to remove the os.path.join() vs. > joinpath() thought. And double check the paths are normalized > everywhere that it matters. Eliminating the few existing cases of unnormalized file names? That sounds reasonable, as long as it doesn't cause confusion to users. > I could just do path normalization everywhere (as long as there are no > Make variables) which would make everything easier. But it would > likely cause small diffs where gnulib-tool.sh doesn't do the same. It depends, on a case-by-case basis, whether such small changes are good / acceptable or not. Bruno
