Re: getloadavg is broken

2011-05-28 Thread Bruno Haible
Jim Meyering wrote: >         getloadavg: trim unused parts and speed up 'configure' >         ... > > removed the code that used to perform an unusual compile-time test: > using using the getloadavg.c from somewhere under $top_srcdir. > *That* was the sole reason for the macro argument you've jus

Re: getloadavg is broken

2011-05-28 Thread Jim Meyering
Bruno Haible wrote: > Eric Blake wrote: >> Looks sane to me. > > Thanks for the review. Jim is silent about it for 4 days. So I'm committing > the > patch now: > > > 2011-05-28 Bruno Haible > > getloadavg: Remove an unreliable safety check. > * m4/getloadavg.m4 (gl_GETLOADAVG): Drop

Re: getloadavg is broken

2011-05-28 Thread Bruno Haible
Eric Blake wrote: > Looks sane to me. Thanks for the review. Jim is silent about it for 4 days. So I'm committing the patch now: 2011-05-28 Bruno Haible getloadavg: Remove an unreliable safety check. * m4/getloadavg.m4 (gl_GETLOADAVG): Drop argument. Remove test whether

Re: getloadavg is broken

2011-05-24 Thread Eric Blake
On 05/24/2011 03:57 PM, Bruno Haible wrote: > Sam Steingold wrote: >> Unless I remove the offending line (see the appended patch), configure >> fails with "../src/src/gllib/getloadavg.c is missing" message. >> apparently $srcdir is "../src" and $1=$gl_source_base="src/gllib" which >> cannot be comb

Re: getloadavg is broken

2011-05-24 Thread Bruno Haible
Sam Steingold wrote: > Unless I remove the offending line (see the appended patch), configure > fails with "../src/src/gllib/getloadavg.c is missing" message. > apparently $srcdir is "../src" and $1=$gl_source_base="src/gllib" which > cannot be combined into anything sensible. This code was meant

getloadavg is broken

2011-05-24 Thread Sam Steingold
Unless I remove the offending line (see the appended patch), configure fails with "../src/src/gllib/getloadavg.c is missing" message. apparently $srcdir is "../src" and $1=$gl_source_base="src/gllib" which cannot be combined into anything sensible. no other module does such a check, so it is not cl