On 05/24/2011 03:57 PM, Bruno Haible wrote: > Sam Steingold wrote: >> Unless I remove the offending line (see the appended patch), configure >> fails with "../src/src/gllib/getloadavg.c is missing" message. >> apparently $srcdir is "../src" and $1=$gl_source_base="src/gllib" which >> cannot be combined into anything sensible. > > This code was meant to simulate what an AC_LIBSOURCES invocation does. > But AC_LIBSOURCES from autoconf was found to be inadequate in the context > of gnulib and therefore has gotten a gnulib specific override (see > gnulib-tool functions func_emit_initmacro_start, func_emit_initmacro_end). > > Most of the gnulib users actually don't even need the AC_LIBSOURCES invocation > normally, because gnulib-tool and a correct module description already > guarantee that source files will be where they are expected. > >> no other module does such a check, so it is not clear why getloadavg should. > > Good point. Here's a proposed patch.
Looks sane to me. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
