Re: warnings.m4: check the compiler, not the preprocessor.

2012-05-04 Thread Akim Demaille
Hi Bruno, Can this patch be installed? I'm depending on it in Bison. Thanks! Le 16 avr. 2012 à 11:28, Akim Demaille a écrit : > The attached patch enhances warnings.m4 in several important > ways: > > - gl_COMPILER_OPTION_IF allows to define more fined > grained tests on the behavior of the co

Re: warnings.m4: check the compiler, not the preprocessor.

2012-04-16 Thread Akim Demaille
Le 16 avr. 2012 à 11:28, Akim Demaille a écrit : > The attached patch enhances warnings.m4 in several important > ways: I was referring to the attachment in the message I was quoting. Attached again for convenience (there are no differences). Akim 0001-warnings.m4-provide-a-means-to-

Re: warnings.m4: check the compiler, not the preprocessor.

2012-04-16 Thread Akim Demaille
The attached patch enhances warnings.m4 in several important ways: - gl_COMPILER_OPTION_IF allows to define more fined grained tests on the behavior of the compiler. Forcing the result to be an assignment to a variable (which is AC_SUBST) does not seem to offer the orthogonal design one w

Re: warnings.m4: check the compiler, not the preprocessor.

2012-04-09 Thread Akim Demaille
Le 30 mars 2012 à 11:55, Akim Demaille a écrit : > Le 30 mars 2012 à 11:18, Bruno Haible a écrit : > >>> 0002-warnings.m4-exhibit-an-if-else-interface.patch >> >> What is the point of this patch? Those who want to assign to a different >> variable than WARN_CFLAGS can already do so through gl_W

Re: warnings.m4: check the compiler, not the preprocessor.

2012-03-30 Thread Akim Demaille
Le 30 mars 2012 à 11:18, Bruno Haible a écrit : > Hi Akim, > >>> This patch appears broken to me: >>> - On one hand it augments CPPFLAGS without ever setting it back. >>> - On the other hand it saves and restores CFLAGS or CXXFLAGS but >>> without temporarily modifying its value. >>> >>> Can

Re: warnings.m4: check the compiler, not the preprocessor.

2012-03-30 Thread Bruno Haible
Hi Akim, > > This patch appears broken to me: > > - On one hand it augments CPPFLAGS without ever setting it back. > > - On the other hand it saves and restores CFLAGS or CXXFLAGS but > >without temporarily modifying its value. > > > > Can you please provide a fix? Gnulib macros should in g

Re: warnings.m4: check the compiler, not the preprocessor.

2012-03-30 Thread Akim Demaille
Hi Bruno! Le 30 mars 2012 à 03:26, Bruno Haible a écrit : > Akim Demaille wrote: >> Currently the macro does >> not depend on the language to store its result > > This patch appears broken to me: > - On one hand it augments CPPFLAGS without ever setting it back. > - On the other hand it saves

Re: warnings.m4: check the compiler, not the preprocessor.

2012-03-29 Thread Bruno Haible
Akim Demaille wrote: > Currently the macro does > not depend on the language to store its result This patch appears broken to me: - On one hand it augments CPPFLAGS without ever setting it back. - On the other hand it saves and restores CFLAGS or CXXFLAGS but without temporarily modifying

Re: warnings.m4: check the compiler, not the preprocessor.

2012-03-29 Thread Eric Blake
On 03/29/2012 07:36 AM, Akim Demaille wrote: > For Bison I would like to test C and C++ warnings > in two different batches. Currently the macro does > not depend on the language to store its result, and > it does not try to compile, just to preprocess. > > * m4/warnings.m4 (gl_WARN_ADD): Use th