Hi Akim, > > This patch appears broken to me: > > - On one hand it augments CPPFLAGS without ever setting it back. > > - On the other hand it saves and restores CFLAGS or CXXFLAGS but > > without temporarily modifying its value. > > > > Can you please provide a fix? Gnulib macros should in general *not* > > have lasting effects on $CPPFLAGS, $CFLAGS, $CXXFLAGS. > > Of course, I'm sorry for this error :/
Thanks, I have applied the correction 0001-warnings.m4-fix-errors.patch, but without the unnecessary removal of double-quotes. > 0002-warnings.m4-exhibit-an-if-else-interface.patch What is the point of this patch? Those who want to assign to a different variable than WARN_CFLAGS can already do so through gl_WARN_ADD. Your patch looks like unneeded complexity to me. Also, what is the point of removing the third argument of the AS_LITERAL_IF invocation? IMO this makes the code harder to understand. Bruno
