Simon Josefsson wrote:
> > Yes, I finally had the same idea. How about this? We don't care much about
> > efficiency at this point in the code.
>
> Seems fine to me, thanks! ...
>
> Stuffing this logic into a separate module might be cleaner though...
> there is some duplicated code now.
There i
Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> Actually, nl_langinfo is documented to need not be thread-safe:
>>
>> http://www.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_09.html
>
> And the same page lists also ecvt(), fcvt(), gcvt() as not being thread-safe.
>
Simon Josefsson wrote:
> Actually, nl_langinfo is documented to need not be thread-safe:
>
> http://www.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_09.html
And the same page lists also ecvt(), fcvt(), gcvt() as not being thread-safe.
Argh.
> Btw, can we use the system's native sprint
Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> Any objections to installing this patch?
>
> Yes. I think it's a shame to return a non-POSIX-compliant result if there
> are better possibilities. The appended patch is in my queue for a few days;
> I'm meaning to test it a littl
Eric Blake wrote:
> 2007-03-26 Eric Blake <[EMAIL PROTECTED]>
>
> * m4/vasnprintf.m4: Fix regression in logic sense of previous
> patch.
Thanks. Of course.
Bruno
Eric Blake byu.net> writes:
> > --- 66,79
> > AC_DEFUN([gl_PREREQ_VASNPRINTF_DIRECTIVE_A],
> > [
> > AC_REQUIRE([gl_PRINTF_DIRECTIVE_A])
> > ! case "$gl_cv_func_printf_directive_a" in
> > ! *yes)
>
> ;;
> *) # You need this, to avoid flipping the sense of
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 3/26/2007 4:23 AM:
> *** 66,77
> AC_DEFUN([gl_PREREQ_VASNPRINTF_DIRECTIVE_A],
> [
> AC_REQUIRE([gl_PRINTF_DIRECTIVE_A])
> ! if ! expr "$gl_cv_func_printf_directive_a" : ".*yes" > /dev/null; then
> --- 66,79
Ralf Wildenhues wrote:
> `if !' is not portable, please use
> if $cmd; then :; else
>
> instead
Thanks for spotting this. I rewrite it like this, remembering the Cygwin
people who count the number of forks and execs that a shell script does.
2007-03-26 Bruno Haible <[EMAIL PROTECTED]>
Hello Bruno,
* Bruno Haible wrote on Mon, Mar 26, 2007 at 04:18:35AM CEST:
> After testing on a few platforms, I applied this patch now.
>
> 2007-03-25 Bruno Haible <[EMAIL PROTECTED]>
>
> * lib/vasnprintf.c: Include langinfo.h.
> (VASNPRINTF): Prefer nl_langinfo over localeconv, si
After testing on a few platforms, I applied this patch now.
2007-03-25 Bruno Haible <[EMAIL PROTECTED]>
* lib/vasnprintf.c: Include langinfo.h.
(VASNPRINTF): Prefer nl_langinfo over localeconv, since it's more
multithread-safe.
* m4/vasnprintf.m4 (gl_PREREQ_VASNP
Simon Josefsson wrote:
> Any objections to installing this patch?
Yes. I think it's a shame to return a non-POSIX-compliant result if there
are better possibilities. The appended patch is in my queue for a few days;
I'm meaning to test it a little more before I commit it.
> I searched a little, b
Simon Josefsson <[EMAIL PROTECTED]> writes:
> In gsasl I have a script that try to help me make sure I don't use
> thread unsafe functions (included below for reference), and after
> updating gnulib for it, it triggers on vasnprintf.c:
>
> ../lib/gl/vasnprintf.c:#include /* localeconv() */
>
12 matches
Mail list logo
