Re: use of thread-unsafe localeconv in vasprintf

[Bruno Haible]

Ralf Wildenhues wrote:
> `if !' is not portable, please use
>   if $cmd; then :; else
> 
> instead

Thanks for spotting this. I rewrite it like this, remembering the Cygwin
people who count the number of forks and execs that a shell script does.


2007-03-26  Bruno Haible  <[EMAIL PROTECTED]>

        * m4/vasnprintf.m4 (gl_PREREQ_VASNPRINTF_DIRECTIVE_A): Don't use
        unportable shell command "if ! ...".
        Reported by Ralf Wildenhues.

*** m4/vasnprintf.m4    26 Mar 2007 02:15:46 -0000      1.14
--- m4/vasnprintf.m4    26 Mar 2007 10:21:25 -0000
***************
*** 66,77 ****
  AC_DEFUN([gl_PREREQ_VASNPRINTF_DIRECTIVE_A],
  [
    AC_REQUIRE([gl_PRINTF_DIRECTIVE_A])
!   if ! expr "$gl_cv_func_printf_directive_a" : ".*yes" > /dev/null; then
!     AC_DEFINE([NEED_PRINTF_DIRECTIVE_A], 1,
!       [Define if the vasnprintf implementation needs special code for
!        the 'a' and 'A' directives.])
!     AC_CHECK_FUNCS([nl_langinfo])
!   fi
  ])
  
  # Prerequisites of lib/asnprintf.c.
--- 66,79 ----
  AC_DEFUN([gl_PREREQ_VASNPRINTF_DIRECTIVE_A],
  [
    AC_REQUIRE([gl_PRINTF_DIRECTIVE_A])
!   case "$gl_cv_func_printf_directive_a" in
!     *yes)
!       AC_DEFINE([NEED_PRINTF_DIRECTIVE_A], 1,
!         [Define if the vasnprintf implementation needs special code for
!          the 'a' and 'A' directives.])
!       AC_CHECK_FUNCS([nl_langinfo])
!       ;;
!   esac
  ])
  
  # Prerequisites of lib/asnprintf.c.