Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-04 Thread Collin Funk
Bruno Haible writes: > The doc looks good, except there's no point in showing the bodies of the > three ChangeLog entries. > > I like in particular that you start the description with > "If you wish to output the @file{ChangeLog} with dates respecting the >time zone each individual commit w

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-04 Thread Bruno Haible
Collin Funk wrote: > I've pushed the attached patch. Mostly the same as the original but the > default behavior is unchanged. Thanks a lot! > The option is now named '--commit-timezone'. I'm not very creative so > feel free to change it if you think of something better. :) I had nothing better t

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-04 Thread Simon Josefsson via Gnulib discussion list
Thanks for the patch! I did not test it, but it looks safe from a backwards compatibility point of view, so +1, and if this gets pushed I will update some project to test it further. /Simon signature.asc Description: PGP signature

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-03 Thread Collin Funk
Bruno Haible writes: >> I can send a version of that patch if that is agreeable to everyone. > > Yes, please. With an added example in the documentation. Thanks! I've pushed the attached patch. Mostly the same as the original but the default behavior is unchanged. The option is now named '--comm

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-03 Thread Bruno Haible
Collin Funk wrote: > > So, can we have > > - 1) with localtime(), as the default behaviour, > > - 2) as implemented by Collin, but enabled through a command-line option, > > and then update the second example in the documentation [2], to remove > > TZ=UTC=0 and use that command-line option inst

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-03 Thread Collin Funk
Hi Bruno, Bruno Haible writes: > Still, it troubles me (and I regret that I had not thought of it earlier) > that > - A list of time points is presented, each occurring in a different > time zone, but without the time zone. > - As a consequence, the dates are not monotonically increasing

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-03 Thread Paul Eggert
On 7/3/24 14:48, Bruno Haible wrote: (Btw, is UTC=0 correct? I thought it should be UTC0 It's not portable, although it happens to work on most systems since they default to UTC if TZ has a bogus value. I installed the attached to fix that, and to improve on other issues I noticed in that d

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-03 Thread Bruno Haible
Simon Josefsson wrote: > > So, can we have > > - 1) with localtime(), as the default behaviour, > > - 2) as implemented by Collin, but enabled through a command-line option, > > and then update the second example in the documentation [2], to remove > > TZ=UTC=0 and use that command-line option

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-03 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: > Hi Simon, > >> > * It drops the localtime() call, with two bad effects: >> > >> > - The principle "Dates and times are always shown relative to the >> > user's >> > time zone, unless stated otherwise" is violated. This principle >> > exists because

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-03 Thread Bruno Haible
Hi Simon, > > * It drops the localtime() call, with two bad effects: > > > > - The principle "Dates and times are always shown relative to the > > user's > > time zone, unless stated otherwise" is violated. This principle > > exists because most users don't want to deal wi

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-03 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: > Hi Collin, > >> and then Paul added: >> >> > Emacs has had the tradition of using UTC for ChangeLog dates, so >> > please support that as well, as an option. > > and Simon did that, through documentation: In >

Re: gitlog-to-changelog: Improve handling of time zones.

2024-07-03 Thread Bruno Haible
Hi Collin, > and then Paul added: > > > Emacs has had the tradition of using UTC for ChangeLog dates, so > > please support that as well, as an option. and Simon did that, through documentation: In he added t