Re: canonicalize-lgpl bug

2009-09-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/18/2009 1:40 AM: > + mkdir subdir removed > + touch regfile > + ln -s regfile link1 > + ln -s subdir link2 > + ln -s missing link3 > + ln -s subdir/missing link4 ... > ++ readlink -f subdir/more > + v=/sh/j/w/co/cu/tests/

Re: canonicalize-lgpl bug

2009-09-18 Thread Jim Meyering
Jim Meyering wrote: > Eric Blake wrote: > >> According to Eric Blake on 9/16/2009 10:10 PM: >>> According to Eric Blake on 9/16/2009 9:11 AM: > I've reached this point in reading the patches. > So far they look fine. > I will read the remainder, and test tomorrow. I'll try and reba

Re: canonicalize-lgpl bug

2009-09-17 Thread Jim Meyering
Eric Blake wrote: > According to Eric Blake on 9/16/2009 10:10 PM: >> According to Eric Blake on 9/16/2009 9:11 AM: I've reached this point in reading the patches. So far they look fine. I will read the remainder, and test tomorrow. >>> I'll try and rebase my series before then. >>

Re: canonicalize-lgpl bug

2009-09-17 Thread Eric Blake
According to Eric Blake on 9/16/2009 10:10 PM: > According to Eric Blake on 9/16/2009 9:11 AM: >>> I've reached this point in reading the patches. >>> So far they look fine. >>> I will read the remainder, and test tomorrow. >> I'll try and rebase my series before then. > > Now rebased: > > git pu

Re: canonicalize-lgpl bug

2009-09-16 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/16/2009 9:11 AM: >> I've reached this point in reading the patches. >> So far they look fine. >> I will read the remainder, and test tomorrow. > > I'll try and rebase my series before then. Now rebased: git pull git://re

Re: canonicalize-lgpl bug

2009-09-16 Thread Eric Blake
Jim Meyering meyering.net> writes: > > [3/11] canonicalize: don't lose errno > > glibc still has a bug in realpath/c_f_n where errno could be inadvertently > > changed by a call to free() during an error return, but canonicalize-lgpl was > > immune, and now canonicalize is fixed. I guess

Re: canonicalize-lgpl bug

2009-09-16 Thread Jim Meyering
Eric Blake wrote: > Jim Meyering meyering.net> writes: >> > Eric Blake (6): >> > canonicalize-lgpl: reject non-directory with trailing slash >> > stdlib: sort witness names >> > canonicalize: leave canonicalize_file_name to canonicalize-lgpl >> > canonicalize-lgpl: use nati

Re: canonicalize-lgpl bug

2009-09-11 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/11/2009 4:35 PM: > [3/11] canonicalize: don't lose errno > glibc still has a bug in realpath/c_f_n where errno could be inadvertently > changed by a call to free() during an error return, but canonicalize-lgpl was >

Re: canonicalize-lgpl bug

2009-09-11 Thread Jim Meyering
Eric Blake wrote: > Jim Meyering meyering.net> writes: > >> > I noticed that glibc has applied some fixes to canonicalize.c that we were >> > missing; and sure enough, was able to enhance the testsuite to trip these >> > bugs. They also applied some assert's proving that their optimization to > a

Re: canonicalize-lgpl bug

2009-09-11 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/10/2009 12:21 PM: > Hmm, on thinking about this more, there are probably existing Linux machines > where glibc canonicalize_file_name is broken (fails to detect ENOTDIR > on "file/"), and therefore we need to replace it.

Re: canonicalize-lgpl bug

2009-09-10 Thread Eric Blake
Jim Meyering meyering.net> writes: > > I noticed that glibc has applied some fixes to canonicalize.c that we were > > missing; and sure enough, was able to enhance the testsuite to trip these > > bugs. They also applied some assert's proving that their optimization to avoid > > strcpy are safe;

Re: canonicalize-lgpl bug

2009-09-10 Thread Jim Meyering
Eric Blake wrote: > I noticed that glibc has applied some fixes to canonicalize.c that we were > missing; and sure enough, was able to enhance the testsuite to trip these > bugs. They also applied some assert's proving that their optimization to > avoid > strcpy are safe; I left the asserts out,

Re: canonicalize-lgpl bug

2009-09-10 Thread Eric Blake
Eric Blake byu.net> writes: > I noticed that glibc has applied some fixes to canonicalize.c that we were > missing; and sure enough, was able to enhance the testsuite to trip these > bugs. They also applied some assert's proving that their optimization to avoid > strcpy are safe; I left the