Jim Meyering wrote: > Eric Blake wrote: > >> According to Eric Blake on 9/16/2009 10:10 PM: >>> According to Eric Blake on 9/16/2009 9:11 AM: >>>>> I've reached this point in reading the patches. >>>>> So far they look fine. >>>>> I will read the remainder, and test tomorrow. >>>> I'll try and rebase my series before then. >>> >>> Now rebased: >>> >>> git pull git://repo.or.cz/gnulib/ericb.git canonicalize
Now that the above is pushed, I've adjusted coreutils locally to use it and ran "make check" on Fedora 11. That shows a new failure in readlink's can-f test. Can you look into it? ====================================================== GNU coreutils 7.6.24-4375e: tests/test-suite.log ====================================================== 1 of 358 tests failed. (36 tests were not run). .. contents:: :depth: 2 ... FAIL: readlink/can-f (exit: 1) ============================== + readlink --version readlink (GNU coreutils) 7.6.24-4375e Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Dmitry V. Levin. + . ./test-lib.sh ++ unset function_test ++ eval 'function_test() { return 11; }; function_test' +++ function_test +++ return 11 ++ test 11 '!=' 11 +++ pwd ++ test_dir_=/sh/j/w/co/cu/tests +++ this_test_ +++ sed 's,.*/,,' +++ echo ././readlink/can-f ++ this_test=can-f +++ /sh/j/w/co/cu/src/mktemp -d --tmp=/sh/j/w/co/cu/tests cu-can-f.XXXXXXXXXX ++ t_=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2 ++ trap remove_tmp_ 0 ++ trap 'Exit $?' 1 2 13 15 ++ cd /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2 ++ diff --version ++ grep GNU ++ pwd + pwd=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2 ++ /sh/j/w/co/cu/src/pwd + my_pwd=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2 + tmp=d + fail=0 + mkdir d + cd d + mkdir subdir removed + touch regfile + ln -s regfile link1 + ln -s subdir link2 + ln -s missing link3 + ln -s subdir/missing link4 + cd /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/removed + fail=0 + rmdir ../removed ++ readlink -e . + v= + test -z '' + cd /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d + for p in '""' '"$pwd/$tmp/"' ++ readlink -f regfile + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile ++ readlink -f ./regfile/ + v= + test -z '' ++ readlink -f regfile/more + v= + test -z '' ++ readlink -f ./regfile/more/ + v= + test -z '' ++ readlink -f subdir + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir ++ readlink -f ./subdir/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir ++ readlink -f subdir/more + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more ++ readlink -f ./subdir/more/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + fail=1 + test -z /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + fail=1 ++ readlink -f missing + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing ++ readlink -f ./missing/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + fail=1 + test -z /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + fail=1 ++ readlink -f missing/more + v= + test -z '' ++ readlink -f ./missing/more/ + v= + test -z '' ++ readlink -f link1 + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile ++ readlink -f ./link1/ + v= + test -z '' ++ readlink -f link1/more + v= + test -z '' ++ readlink -f ./link1/more/ + v= + test -z '' ++ readlink -f link2 + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir ++ readlink -f ./link2/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir ++ readlink -f link2/more + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more ++ readlink -f ./link2/more/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + fail=1 + test -z /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + fail=1 ++ readlink -f link2/more/more2 + v= + test -z '' ++ readlink -f ./link2/more/more2/ + v= + test -z '' ++ readlink -f link3 + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing ++ readlink -f ./link3/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + fail=1 + test -z /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + fail=1 ++ readlink -f link3/more + v= + test -z '' ++ readlink -f ./link3/more/ + v= + test -z '' ++ readlink -f link4 + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/missing + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/missing = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/missing ++ readlink -f ./link4/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/missing + fail=1 + test -z /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/missing + fail=1 ++ readlink -f link4/more + v= + test -z '' + for p in '""' '"$pwd/$tmp/"' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./regfile/ + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile/more + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./regfile/more/ + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./subdir/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./subdir/more/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + fail=1 + test -z /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + fail=1 ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./missing/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + fail=1 + test -z /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + fail=1 ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing/more + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./missing/more/ + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/link1 + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/regfile ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./link1/ + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/link1/more + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./link1/more/ + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/link2 + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./link2/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/link2/more + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./link2/more/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + fail=1 + test -z /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/more + fail=1 ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/link2/more/more2 + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./link2/more/more2/ + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/link3 + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./link3/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + fail=1 + test -z /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/missing + fail=1 ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/link3/more + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./link3/more/ + v= + test -z '' ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/link4 + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/missing + test /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/missing = /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/missing ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/./link4/ + v=/sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/missing + fail=1 + test -z /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/subdir/missing + fail=1 ++ readlink -f /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2/d/link4/more + v= + test -z '' + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /sh/j/w/co/cu/tests + chmod -R u+rwx /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2 + rm -rf /sh/j/w/co/cu/tests/cu-can-f.Y2RpVABkn2 + exit 1
