Re: Problem with sys_select on Cygwin

2016-03-29 Thread Paul Eggert
Ken Brown wrote: Yes, I thought of that too. Someone would have to look at each of them and decide if they apply to newlib in general. I would be willing to take a shot at this. But I would do it as I have time, not necessarily all at once. Would you rather wait until I've finished this and t

Re: Problem with sys_select on Cygwin

2016-03-29 Thread Ken Brown
On 3/29/2016 9:10 PM, Paul Eggert wrote: On 03/29/2016 07:00 AM, Ken Brown wrote: - name" problems on Cygwin. + name" problems on newlib systems.. No double '..'; and maybe the comment could say "newlib systems, including Cygwin", since that is our most common newlib system. Otherwise, I'

Re: Problem with sys_select on Cygwin

2016-03-29 Thread Paul Eggert
On 03/29/2016 07:00 AM, Ken Brown wrote: - name" problems on Cygwin. + name" problems on newlib systems.. No double '..'; and maybe the comment could say "newlib systems, including Cygwin", since that is our most common newlib system. Otherwise, I'm okay with the change. Could someone in

Re: Problem with sys_select on Cygwin

2016-03-29 Thread Ken Brown
On 3/21/2016 6:47 PM, Eric Blake wrote: On 03/21/2016 03:43 PM, Ken Brown wrote: On 3/21/2016 1:32 PM, Paul Eggert wrote: Eric Blake wrote: This feels a bit too broad - it assumes that everyone is compiling with ONLY the latest newlib headers; remember, the cygwin header changes have NOT been

Re: Problem with sys_select on Cygwin

2016-03-21 Thread Eric Blake
On 03/21/2016 03:43 PM, Ken Brown wrote: > On 3/21/2016 1:32 PM, Paul Eggert wrote: >> Eric Blake wrote: >>> This feels a bit too broad - it assumes that everyone is compiling with >>> ONLY the latest newlib headers; remember, the cygwin header changes have >>> NOT been released yet, but are in bet

Re: Problem with sys_select on Cygwin

2016-03-21 Thread Ken Brown
On 3/21/2016 1:32 PM, Paul Eggert wrote: > Eric Blake wrote: >> This feels a bit too broad - it assumes that everyone is compiling with >> ONLY the latest newlib headers; remember, the cygwin header changes have >> NOT been released yet, but are in beta testing to see what else needs to >> change a

Re: Problem with sys_select on Cygwin

2016-03-21 Thread Paul Eggert
Eric Blake wrote: This feels a bit too broad - it assumes that everyone is compiling with ONLY the latest newlib headers; remember, the cygwin header changes have NOT been released yet, but are in beta testing to see what else needs to change at the same time as the cygwin release. As far as I

Re: Problem with sys_select on Cygwin

2016-03-21 Thread Ken Brown
On 3/21/2016 12:04 PM, Eric Blake wrote: Do we even need to wait for a version number from newlib, or can we probe based on one of the other changes going in at the same time? For example, part of the newlib/Cygwin changes was the addition of a new sys/_timespec.h, with a new witness variable _S

Re: Problem with sys_select on Cygwin

2016-03-21 Thread Ken Brown
On 3/21/2016 12:04 PM, Eric Blake wrote: On 03/21/2016 09:47 AM, Eric Blake wrote: Would you mind to follow up with that problem on bug-gnulib? The test should probably look like this, more or less: #!((defined __GLIBC__ \ || (defined __NEWLIB__ \ && ((__NEWLIB__ == 2 && __NEWLIB_MI

Re: Problem with sys_select on Cygwin

2016-03-21 Thread Eric Blake
On 03/21/2016 09:47 AM, Eric Blake wrote: >> >> Would you mind to follow up with that problem on bug-gnulib? The test >> should probably look like this, more or less: >> >> #!((defined __GLIBC__ \ >> || (defined __NEWLIB__ \ >> && ((__NEWLIB__ == 2 && __NEWLIB_MINOR__ >= 4) || __NEWLIB__ >

Re: Problem with sys_select on Cygwin

2016-03-21 Thread Eric Blake
On 03/21/2016 01:50 AM, Paul Eggert wrote: > Ken Brown wrote: >> Treating Cygwin the same as Glibc with respect to inclusion of system >> headers seems to solve the problem: > > Thanks, I installed the attached. > > 0001-sys_select-port-to-new-Cygwin.patch > > +++ b/lib/sys_select.in.h > @@ -81

Re: Problem with sys_select on Cygwin

2016-03-21 Thread Paul Eggert
Ken Brown wrote: Treating Cygwin the same as Glibc with respect to inclusion of system headers seems to solve the problem: Thanks, I installed the attached. >From cfbc1c62a1ea5c5809d11b957ad29cd820db15b8 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 21 Mar 2016 00:49:17 -0700 Subject:

Re: Problem with sys_select on Cygwin

2016-03-20 Thread Ken Brown
On 3/20/2016 7:14 AM, Ken Brown wrote: > On 3/19/2016 10:44 PM, Paul Eggert wrote: >> Ken Brown wrote: >>> Cygwin is changing its headers as of the next release so that >>> sys/types.h >>> includes sys/select.h >>> Can sys_select be changed so that it doesn't try to include other >>> headers b

Re: Problem with sys_select on Cygwin

2016-03-20 Thread Ken Brown
On 3/19/2016 10:44 PM, Paul Eggert wrote: Ken Brown wrote: Cygwin is changing its headers as of the next release so that sys/types.h includes sys/select.h Can sys_select be changed so that it doesn't try to include other headers before it has finished including sys/types.h? Or is there some

Re: Problem with sys_select on Cygwin

2016-03-19 Thread Paul Eggert
Ken Brown wrote: Cygwin is changing its headers as of the next release so that sys/types.h includes sys/select.h Can sys_select be changed so that it doesn't try to include other headers before it has finished including sys/types.h? Or is there some other way to solve this problem? Probabl