On 03/21/2016 01:50 AM, Paul Eggert wrote: > Ken Brown wrote: >> Treating Cygwin the same as Glibc with respect to inclusion of system >> headers seems to solve the problem: > > Thanks, I installed the attached. > > 0001-sys_select-port-to-new-Cygwin.patch >
> +++ b/lib/sys_select.in.h > @@ -81,8 +81,9 @@ > of 'struct timeval', and no definition of this type. > Also, Mac OS X, AIX, HP-UX, IRIX, Solaris, Interix declare select() > in <sys/time.h>. > - But avoid namespace pollution on glibc systems. */ > -# ifndef __GLIBC__ > + But avoid namespace pollution on glibc systems and "unknown type > + name" problems on Cygwin. */ > +# if !(defined __GLIBC__ || defined __CYGWIN__) > # include <sys/time.h> > # endif This feels a bit too broad - it assumes that everyone is compiling with ONLY the latest newlib headers; remember, the cygwin header changes have NOT been released yet, but are in beta testing to see what else needs to change at the same time as the cygwin release. It may be wiser to make the change conditional based on a version string; here's what was said on the cygwin list: > > Would you mind to follow up with that problem on bug-gnulib? The test > should probably look like this, more or less: > > #!((defined __GLIBC__ \ > || (defined __NEWLIB__ \ > && ((__NEWLIB__ == 2 && __NEWLIB_MINOR__ >= 4) || __NEWLIB__ >= 3))) \ > && !defined __UCLIBC__) > > As for the actual version number to test I have to talk to Jeff if we > can change the version to 2.4 or at least 2.3.1. 2.4 would simplify the > test in gnulib, otherwise the test gets a bit more complicated. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
