Re: [PATCH 2/2] hmac-*: refactor to remove repetitive code

On 30/09/18 11:22, Bruno Haible wrote: > Hi Pádraig, > > With this patch, I see a small regression: > >> #include >> - >> -#include "hmac.h" > There is no verification any more that hmac.h is self-contained. > > As mentioned just yesterday, the best practice is to #include the > specification

Re: [PATCH 2/2] hmac-*: refactor to remove repetitive code

Hi Pádraig, With this patch, I see a small regression: > #include > - > -#include "hmac.h" and > --- a/tests/test-hmac-sha1.c > +++ b/tests/test-hmac-sha1.c > @@ -17,43 +17,51 @@ > /* Written by Simon Josefsson. */ > > #include > +#include > +#include > +#include > > #include "hma