Hi Pádraig,

With this patch, I see a small regression:

>  #include <config.h>
> -
> -#include "hmac.h"

and

> --- a/tests/test-hmac-sha1.c
> +++ b/tests/test-hmac-sha1.c
> @@ -17,43 +17,51 @@
>  /* Written by Simon Josefsson.  */
>  
>  #include <config.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
>  
>  #include "hmac.h"

There is no verification any more that hmac.h is self-contained.

As mentioned just yesterday, the best practice is to #include the
specification header right after <config.h>.

Bruno


Reply via email to