atoll: Fix module dependencies

2024-07-29 Thread Bruno Haible
This patch fixes a trivial oversight: 2024-07-29 Bruno Haible atoll: Fix module dependencies. * modules/atoll (Depends-on): Add stdlib. diff --git a/modules/atoll b/modules/atoll index ac5fdcb9b9..8f7c347af5 100644 --- a/modules/atoll +++ b/modules/atoll @@ -6,6 +6,7 @@ lib

[PATCH] gnulib-tool.py: Handle module dependencies that cannot be found.

2024-05-07 Thread Collin Funk
* pygnulib/GLModuleSystem.py (GLModule.getDependenciesWithoutConditions): Filter out None from the module dependencies. An appropriate warning will already be printed by GLModuleSystem.find(). --- ChangeLog | 8 pygnulib/GLModuleSystem.py | 5 - 2 files changed, 12

nstrftime: omit locking code from module dependencies

2024-02-15 Thread Bruno Haible
With the last two patches, nstrftime no longer does any locking while retrieving a locale name. But the locking code is still present, as part of module dependencies. These two patches fix that: The module dependencies are restructured so that nstrftime no longer indirectly depends on the '

lseek: Fix module dependencies

2023-04-24 Thread Bruno Haible
On 2021-11-15 a change was made to optimize the conditions of the module dependencies of 'lseek'. Such optimizations are often hairy, because they assume that the workaround is only needed in the _currently known_ circumstances. In this case, the optimization was also wrong, b

Re: vasnwprintf: Fix module dependencies

2023-03-20 Thread Bruno Haible
Yesterday I did: > 2023-03-19 Bruno Haible > > vasnwprintf: Fix module dependencies. > * modules/vasnwprintf (Depends-on): Add wmemcpy, wmemset. Oops, this produces gnulib-tool warnings: gnulib-tool: warning: module vasnwprintf-posix depends on a module with an

vasnwprintf: Fix module dependencies

2023-03-19 Thread Bruno Haible
The vasnwprintf implementation and tests depend on a few wide-character string functions from . This patch adds the dependencies. It also depends on 'swprintf'; to be added later. 2023-03-19 Bruno Haible vasnwprintf: Fix module dependencies. * modules/vasnwprintf (

posix_spawn_file_actions_* tests: Fix module dependencies

2021-01-25 Thread Bruno Haible
Bruno Haible posix_spawn_file_actions_* tests: Fix module dependencies. * modules/posix_spawn_file_actions_addclose-tests (Depends-on): Add posix_spawn_file_actions_destroy. * modules/posix_spawn_file_actions_addopen-tests (Depends-on): Likewise.

Fix missing module dependencies to 'xalloc'

2020-11-22 Thread Bruno Haible
ause is the change "xalloc-die: Fix link error with Solaris cc (regression 2020-07-27)" from 2020-10-19. Module dependencies to 'xalloc' must now be explicitly stated; a module dependency to 'xalloc-die' no longer implies one to 'xalloc'. This patch fixes it

canonicalize: Trim module dependencies

2020-07-07 Thread Bruno Haible
'hash-triple' module and, in particular, only the part that does not need the 'same' module. 2020-07-07 Bruno Haible canonicalize: Trim module dependencies. * lib/hash-triple.h: Group declarations. * lib/hash-triple-simple.c: New file, extracted

Re: Module dependencies

2020-03-26 Thread Bruno Haible
Hi, > So Case 1 says alloca and alloca-opt are included and tested with > iconv. Case 2 and Case 3 say alloca and alloca-opt are not included > and therefore not tested with iconv. Try ./gnulib-tool --create-testdir --dir="${TEST_DIR}" iconv vs. ./gnulib-tool --create-testdir --dir="${TEST

Module dependencies

2020-03-26 Thread Jeffrey Walton
Hi Everyone, There are 1700+ modules according to --list. At 3 minutes (est.) a test that would take 85 hours to complete. I _think_ a speedup is, if module A uses B and C, then we can scratch three off the list at a time. The problem I am having is, I'm having trouble understand the output from

c-xvasprintf: fix module dependencies

2019-01-04 Thread Bruno Haible
lib/c-xvasprintf includes xalloc.h and invokes xalloc_die(). The module therefore needs to depend on either 'xalloc' or 'xalloc-die'. 2019-01-04 Bruno Haible c-xvasprintf: Fix module dependencies. * modules/c-xvasprintf (Depends-on): Add 'xalloc-die&

bitsetv: fix module dependencies

2019-01-04 Thread Bruno Haible
A module shouldn't rely on internals of another module. bitsetv.c invokes xalloc_die(), therefore it should #include "xalloc.h", regardless whether bitset.h already - indirectly through bitset/base.h - includes xalloc.h. 2019-01-04 Bruno Haible bitsetv: Fix modu

backupfile: fix module dependencies

2019-01-04 Thread Bruno Haible
lib/backup-find.c include xalloc.h and invokes xalloc_die(). Therefore: 2019-01-04 Bruno Haible backupfile: Fix module dependencies. * modules/backupfile (Depends-on): Add 'xalloc'. diff --git a/modules/backupfile b/modules/backupfile index 4ada3f5..5dcf6c7 10

Re: [PATCH] regex: trim module dependencies

2018-07-01 Thread Paul Eggert
x (Depends-on): Add lock, memcmp, memmove, + and wctype back in. lock because regex users shouldn’t + need to know that regex needs locking, and the rest because + gnulib-tool should ordinarily ignore them anyway. + 2018-06-30 Paul Eggert regex: trim module dependencies diff --git a/mo

Re: [PATCH] regex: trim module dependencies

2018-07-01 Thread Bruno Haible
Hi Paul, > * modules/regex (Depends-on): Remove gettext-h and lock, > since the regex code should work OK without these modules, > and Emacs uses it that way. The removal of the gettext-h dependency is fine; regex_internal.h tests ENABLE_NLS and includes . But I object against the removal of the

[PATCH] regex: trim module dependencies

2018-06-30 Thread Paul Eggert
| 5 - 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index e5c1e02c7..e25f5a7d6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2018-06-30 Paul Eggert + + regex: trim module dependencies + * modules/regex (Depends-on): Remove

Re: missing module dependencies for vasnprintf

2010-04-08 Thread Jarno Rajahalme
On Apr 8, 2010, at 5:11 PM, ext Bruno Haible wrote: > > Yup, this is pretty much the situation that I imagined. Probably the patch > that I've just committed will fix it. > Yes it did, thanks. Jarno

Re: missing module dependencies for vasnprintf

2010-04-08 Thread Jarno Rajahalme
On Apr 8, 2010, at 5:02 PM, ext Bruno Haible wrote: > Trying to reproduce Jarno's errors, I added into some package that is > using "gnulib-tool --with-tests" > 1. vasnprintf but not vasnprintf-posix, > 2. round (any one of ceilf, floorf, roundf, round, truncf, trunc), > and got this error afte

Re: missing module dependencies for vasnprintf

2010-04-08 Thread Bruno Haible
Jarno Rajahalme wrote: > thought I have a problem with gnulib, so I did make distclean, git pull on > gnulib, gnulib-tool --import, ./configure. After the gnulib-tool invocation, you likely need to insert an 'autoreconf' invocation. Often it may work without it, but not always. > I have now the

Re: missing module dependencies for vasnprintf

2010-04-08 Thread Bruno Haible
Hi, Trying to reproduce Jarno's errors, I added into some package that is using "gnulib-tool --with-tests" 1. vasnprintf but not vasnprintf-posix, 2. round (any one of ceilf, floorf, roundf, round, truncf, trunc), and got this error after running $ gnulib-tool --import round vasnprintf $ a

Re: missing module dependencies for vasnprintf

2010-04-08 Thread Jarno Rajahalme
I'm trying to compile octave with GCC 4.4, and thought I have a problem with gnulib, so I did make distclean, git pull on gnulib, gnulib-tool --import, ./configure. I have now these defined in config.h, after doing the above: #define NEED_PRINTF_DIRECTIVE_A 1 /* #undef NEED_PRINTF_DIRECTIVE_F *

Re: missing module dependencies for vasnprintf

2010-04-08 Thread Bruno Haible
Hi, Jarno Rajahalme wrote: > modules/vasnprintf is missing dependencies, which results in compile error: > > vasnprintf.c:103:28: error: isnanl-nolibm.h: No such file or directory > vasnprintf.c:104:20: error: fpucw.h: No such file or directory > vasnprintf.c:109:28: error: isnand-nolibm.h: No su

missing module dependencies for vasnprintf

2010-04-08 Thread Jarno Rajahalme
Hi, modules/vasnprintf is missing dependencies, which results in compile error: vasnprintf.c:103:28: error: isnanl-nolibm.h: No such file or directory vasnprintf.c:104:20: error: fpucw.h: No such file or directory vasnprintf.c:109:28: error: isnand-nolibm.h: No such file or directory vasnprintf.c

Re: some missing module dependencies

2006-09-25 Thread Ralf Wildenhues
Hello Jim, * Jim Meyering wrote on Fri, Sep 22, 2006 at 09:13:41AM CEST: > Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > > > > Is this patch ok, or would you rather factor out clock_time.m4 into its > > own module (as it is listed by 3 modules already)? > It's a tiny bit nicer to alphabetize lists

Re: some missing module dependencies

2006-09-22 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > Hello Jim, Paul, all, > > Is this patch ok, or would you rather factor out clock_time.m4 into its > own module (as it is listed by 3 modules already)? > > * modules/fts-lgpl: Depend on openat. > * modules/mkancesdirs: Depend on savewd. >

some missing module dependencies

2006-09-21 Thread Ralf Wildenhues
Hello Jim, Paul, all, Is this patch ok, or would you rather factor out clock_time.m4 into its own module (as it is listed by 3 modules already)? Cheers, Ralf * modules/fts-lgpl: Depend on openat. * modules/mkancesdirs: Depend on savewd. * modules/mkdir-p: Likewise.