Building a testdir for module 'posix_spawn_file_actions_addclose' on Solaris 11.4, I see this warning:
../../gltests/test-posix_spawn_file_actions_addclose.c: In function ‘main’: ../../gltests/test-posix_spawn_file_actions_addclose.c:63:37: warning: passing argument 1 of ‘posix_spawn_file_actions_destroy’ from incompatible pointer type [-Wincompatible-pointer-types] posix_spawn_file_actions_destroy (&actions); ^ In file included from ../gllib/spawn.h:42:0, from ../../gltests/test-posix_spawn_file_actions_addclose.c:19: /usr/include/spawn.h:52:12: note: expected ‘posix_spawn_file_actions_t * {aka struct <anonymous> *}’ but argument is of type ‘rpl_posix_spawn_file_actions_t * {aka struct <anonymous> *}’ extern int posix_spawn_file_actions_destroy( ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This patch fixes it. 2021-01-25 Bruno Haible <br...@clisp.org> posix_spawn_file_actions_* tests: Fix module dependencies. * modules/posix_spawn_file_actions_addclose-tests (Depends-on): Add posix_spawn_file_actions_destroy. * modules/posix_spawn_file_actions_addopen-tests (Depends-on): Likewise. * modules/posix_spawn_file_actions_adddup2-tests (Depends-on): Likewise. * modules/posix_spawn_file_actions_addchdir-tests (Depends-on): Likewise. * modules/posix_spawn_file_actions_addfchdir-tests (Depends-on): Likewise. diff --git a/modules/posix_spawn_file_actions_addchdir-tests b/modules/posix_spawn_file_actions_addchdir-tests index 1c56b1c..e554138 100644 --- a/modules/posix_spawn_file_actions_addchdir-tests +++ b/modules/posix_spawn_file_actions_addchdir-tests @@ -6,6 +6,7 @@ tests/macros.h Depends-on: posix_spawn_file_actions_init +posix_spawn_file_actions_destroy posix_spawnp-tests findprog diff --git a/modules/posix_spawn_file_actions_addclose-tests b/modules/posix_spawn_file_actions_addclose-tests index 848acce..b115e3d 100644 --- a/modules/posix_spawn_file_actions_addclose-tests +++ b/modules/posix_spawn_file_actions_addclose-tests @@ -6,6 +6,7 @@ tests/macros.h Depends-on: getdtablesize posix_spawn_file_actions_init +posix_spawn_file_actions_destroy configure.ac: diff --git a/modules/posix_spawn_file_actions_adddup2-tests b/modules/posix_spawn_file_actions_adddup2-tests index f504892..5e25990 100644 --- a/modules/posix_spawn_file_actions_adddup2-tests +++ b/modules/posix_spawn_file_actions_adddup2-tests @@ -6,6 +6,7 @@ tests/macros.h Depends-on: getdtablesize posix_spawn_file_actions_init +posix_spawn_file_actions_destroy configure.ac: diff --git a/modules/posix_spawn_file_actions_addfchdir-tests b/modules/posix_spawn_file_actions_addfchdir-tests index 45f4230..2f09934 100644 --- a/modules/posix_spawn_file_actions_addfchdir-tests +++ b/modules/posix_spawn_file_actions_addfchdir-tests @@ -6,6 +6,7 @@ tests/macros.h Depends-on: posix_spawn_file_actions_init +posix_spawn_file_actions_destroy posix_spawnp-tests findprog diff --git a/modules/posix_spawn_file_actions_addopen-tests b/modules/posix_spawn_file_actions_addopen-tests index fbe7943..8f0de9e 100644 --- a/modules/posix_spawn_file_actions_addopen-tests +++ b/modules/posix_spawn_file_actions_addopen-tests @@ -6,6 +6,7 @@ tests/macros.h Depends-on: getdtablesize posix_spawn_file_actions_init +posix_spawn_file_actions_destroy configure.ac: