Re: [bug-gnulib] Fixing argp doc strings

2006-09-12 Thread Sergey Poznyakoff
Bruno Haible <[EMAIL PROTECTED]> wrote: > In either case of the 'if' branch, inp_text can end up being NULL. > But it is not allowed to pass a NULL string argument to dgettext. Thank you, I have fixed this. Regards, Sergey 2006-09-12 Sergey Poznyakoff <[EMAIL PROTECTED]> * argp-help.

Re: [bug-gnulib] Fixing argp doc strings

2006-09-11 Thread Bruno Haible
Sergey Poznyakoff wrote: > ! inp_text = __strndup (argp->doc, inp_text_len); > ! } > ! } > ! else > ! inp_text = post ? 0 : argp->doc; > ! trans_text = dgettext (argp->argp_domain, inp_text); In either case of the 'if' branch, inp_text can end up being NULL. B

Re: [bug-gnulib] Fixing argp doc strings

2006-09-09 Thread Sergey Poznyakoff
Bruno Haible <[EMAIL PROTECTED]> wrote: > Sure. But N_(...) does apply to it. One might document this, otherwise > the programmer might think that he needs to fill in the translation himself > into the ->doc field at runtime, not knowing that the argp implementation > does it for him. Ah, yes, in

Re: [bug-gnulib] Fixing argp doc strings

2006-09-09 Thread Bruno Haible
Sergey Poznyakoff wrote: > The 'doc' field of argp_option has a different > semantics, '\v' does not apply to it. Sure. But N_(...) does apply to it. One might document this, otherwise the programmer might think that he needs to fill in the translation himself into the ->doc field at runtime, not

Re: [bug-gnulib] Fixing argp doc strings

2006-09-09 Thread Sergey Poznyakoff
Bruno Haible <[EMAIL PROTECTED]> wrote: > Additionally, how about documenting this > (non-obvious) convention? Something like this: Thank you. I have applied this change. > Also, one could mention the need of N_(...) in the documentation of > the field 'doc' of struct argp_option as well: No,

Re: [bug-gnulib] Fixing argp doc strings

2006-09-09 Thread Bruno Haible
Sergey Poznyakoff wrote: > 2006-09-09 Sergey Poznyakoff <[EMAIL PROTECTED]> > > * argp-help.c (argp_doc): Split the untranslated doc string on > '\v', and translate the two parts separately, instead of > feeding the whole string to gettext. This allows to exclude >

Fixing argp doc strings

2006-09-08 Thread Sergey Poznyakoff
Hello, I have installed the following change: 2006-09-09 Sergey Poznyakoff <[EMAIL PROTECTED]> * argp-help.c (argp_doc): Split the untranslated doc string on '\v', and translate the two parts separately, instead of feeding the whole string to gettext. This allows t