Re: [PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnul

2015-10-18 Thread Jim Meyering
On Sun, Oct 18, 2015 at 10:28 AM, Paul Eggert wrote: > Jim Meyering wrote: >> >> Building coreutils configured with --enable-gcc-warnings and using >> bleeding-edge gcc evoked a build failure due to the time_rz module. >> The attached patch removes the warning/error-evoking test. > > > This patch

Re: [PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnul

2015-10-18 Thread Paul Eggert
Jim Meyering wrote: Building coreutils configured with --enable-gcc-warnings and using bleeding-edge gcc evoked a build failure due to the time_rz module. The attached patch removes the warning/error-evoking test. This patch doesn't look right: if localtime_r fails, the original code returns N

[PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnul

2015-10-18 Thread Jim Meyering
Building coreutils configured with --enable-gcc-warnings and using bleeding-edge gcc evoked a build failure due to the time_rz module. The attached patch removes the warning/error-evoking test. I also tested by running this: ./gnulib-tool --create-testdir --dir=/tmp/x --with-tests --test time_rz