On Sun, Oct 18, 2015 at 10:28 AM, Paul Eggert <[email protected]> wrote: > Jim Meyering wrote: >> >> Building coreutils configured with --enable-gcc-warnings and using >> bleeding-edge gcc evoked a build failure due to the time_rz module. >> The attached patch removes the warning/error-evoking test. > > > This patch doesn't look right: if localtime_r fails, the original code > returns NULL, but the revised code does not. I installed the attached > further patch which fixes that, and which attempts to work around the > compiler warning (though I can't easily test that).
Oh, good catch. Thank you. That too avoids the warning.
