Re: [PATCH] test-sys_socket: avoid set-but-not-used warnings from gcc

2010-06-11 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> @@ -49,5 +49,5 @@ main (void) >>x.ss_family = 42; >>i = 42; >> >> - return 0; >> + return ! (i + x.ss_family); >> } > > This makes is hard to understand that the return value is really 0. (It costs > extra brain cycles to see this.) Wouldn't it be poss

Re: [PATCH] test-sys_socket: avoid set-but-not-used warnings from gcc

2010-06-11 Thread Bruno Haible
Hi Jim, > @@ -49,5 +49,5 @@ main (void) >x.ss_family = 42; >i = 42; > > - return 0; > + return ! (i + x.ss_family); > } This makes is hard to understand that the return value is really 0. (It costs extra brain cycles to see this.) Wouldn't it be possible to write this? (void) x;

[PATCH] test-sys_socket: avoid set-but-not-used warnings from gcc

2010-06-11 Thread Jim Meyering
dc70813756e173cd6b7dd5a1 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 11 Jun 2010 11:26:31 +0200 Subject: [PATCH] test-sys_socket: avoid set-but-not-used warnings from gcc * tests/test-sys_socket.c (main): Use "i" and "x", in order to avoid warning