Re: [PATCH] mountlist: fix local drive detection on cygwin

2010-12-29 Thread Eric Blake
On 12/29/2010 01:41 PM, Paul Eggert wrote: > On 12/29/2010 10:25 AM, Jim Meyering wrote: >> char const drive[3] = { fs_name[0], ':', '\0' }; > > The Microsoft documentation says that a trailing > backslash is required here; see >

Re: [PATCH] mountlist: fix local drive detection on cygwin

2010-12-29 Thread Paul Eggert
On 12/29/2010 10:25 AM, Jim Meyering wrote: > char const drive[3] = { fs_name[0], ':', '\0' }; The Microsoft documentation says that a trailing backslash is required here; see . Also, are pre-C99 compilers are still a po

Re: [PATCH] mountlist: fix local drive detection on cygwin

2010-12-29 Thread Eric Blake
On 12/29/2010 11:25 AM, Jim Meyering wrote: > Eric Blake wrote: >> * lib/mountlist.c (ME_REMOTE) [__CYGWIN__]: Provide implementation >> that works for cygwin. >> + if (fs_name[0] && fs_name[1] == ':') >> +{ >> + char const drive[3] = { fs_name[0], ':' }; > > Hi Eric, > Thanks for doing

Re: [PATCH] mountlist: fix local drive detection on cygwin

2010-12-29 Thread Jim Meyering
Eric Blake wrote: > * lib/mountlist.c (ME_REMOTE) [__CYGWIN__]: Provide implementation > that works for cygwin. > > Signed-off-by: Eric Blake > --- > > Any objections to applying this patch? I used it when building > the official cygwin port of coreutils 8.8. In cygwin's getmntent() > implementa

[PATCH] mountlist: fix local drive detection on cygwin

2010-12-28 Thread Eric Blake
* lib/mountlist.c (ME_REMOTE) [__CYGWIN__]: Provide implementation that works for cygwin. Signed-off-by: Eric Blake --- Any objections to applying this patch? I used it when building the official cygwin port of coreutils 8.8. In cygwin's getmntent() implementation, all mount points are mapped