On 12/29/2010 11:25 AM, Jim Meyering wrote: > Eric Blake wrote: >> * lib/mountlist.c (ME_REMOTE) [__CYGWIN__]: Provide implementation >> that works for cygwin.
>> + if (fs_name[0] && fs_name[1] == ':')
>> + {
>> + char const drive[3] = { fs_name[0], ':' };
>
> Hi Eric,
> Thanks for doing that.
> What do you think about adding an explicit trailing NUL byte there?
>
> char const drive[3] = { fs_name[0], ':', '\0' };
>
> There is probably some rule about partial aggregate initializers
> in C "const" variables that says unspecified elements get 0,
> but it's easy to remove all doubt.
Done, and pushed.
--
Eric Blake ebl...@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
