Re: [PATCH] mktime: systematically normalize tm_isdst comparisons

2011-01-31 Thread Paul Eggert
On 01/31/2011 06:47 AM, Eric Blake wrote: > Is it any more efficient to use short-circuiting operators here (&& > instead of &)? I tried it both ways on x86-64 with GCC 4.5.2, and & generated a few bytes less code than && did. I didn't investigate CPU-time performance, but I expect it's also a bi

Re: [PATCH] mktime: systematically normalize tm_isdst comparisons

2011-01-31 Thread Eric Blake
On 01/30/2011 12:02 AM, Paul Eggert wrote: > +/* Return 1 if the values A and B differ according to the rules for > + tm_isdst: A and B differ if one is zero and the other positive. */ > +static int > +isdst_differ (int a, int b) > +{ > + return (!a != !b) & (0 <= a) & (0 <= b); Is it any more

[PATCH] mktime: systematically normalize tm_isdst comparisons

2011-01-29 Thread Paul Eggert
--- ChangeLog|8 lib/mktime.c | 18 -- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 362c33f..0277dcd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,13 @@ 2011-01-29 Paul Eggert + mktime: systematically