Jim Meyering wrote:
the false positives should be sufficiently rare that it's
worth leaving it on by default. It might catch me doing something
stupid even before I run a test
It might. On the other hand, every warning that -Wduplicated-branches generated
for grep (3 warnings) and for Emacs (4
On Sun, May 21, 2017 at 1:10 PM, Paul Eggert wrote:
> Jim Meyering wrote:
>>
>> two of the three instances it flagged in grep
>> were odd enough that I feel they benefit from the added attention
>
>
> Anybody reading those two instances of the code would already know what's
> going on; it's pretty
Jim Meyering wrote:
two of the three instances it flagged in grep
were odd enough that I feel they benefit from the added attention
Anybody reading those two instances of the code would already know what's going
on; it's pretty obvious, it's already commented, and to my mind the extra
attenti
On Sun, May 21, 2017 at 12:18 PM, Paul Eggert wrote:
> Jim Meyering wrote:
>>
>>- -Wduplicated-branches complained about three false positives,
>
> In Emacs, I found -Wduplicated-branches to be useless and I disabled it.
> Since it's finding only false alarms in grep, too, I suggest that we di
Jim Meyering wrote:
- -Wduplicated-branches complained about three false positives,
In Emacs, I found -Wduplicated-branches to be useless and I disabled it. Since
it's finding only false alarms in grep, too, I suggest that we disable it by
default at the Gnulib level. My impression is that
