Jim Meyering wrote:
two of the three instances it flagged in grep were odd enough that I feel they benefit from the added attention
Anybody reading those two instances of the code would already know what's going on; it's pretty obvious, it's already commented, and to my mind the extra attention gets in the way more than it helps.
I agree that it would be better to advise the compiler directly about the optimization that's needed there, if GCC etc. ever get around to doing that. (I'm pretty sure the optimization advice is still needed, by the way: static compilers typically don't have enough information, and even dynamic ones would have troubles with those two.)
