Re: bug#77800: grep-3.12: write-error-msg test failure on fedora rawhide (f43)

On Mon, Apr 21, 2025 at 12:20 AM Jaroslav Škarvada wrote: > > $ { env printf %4095s; env printf %4096s; } > /dev/full > > printf: write error: Broken pipe > > printf: write error > > > Guys, thanks for the analysis and quick actions. BTW is the Fedora > help patch which uncovered this

Re: fts: Fix redefinition of __THROW.

On Sun, May 11, 2025 at 3:38 PM Bruno Haible wrote: ... > What I propose is to have fts.in.h being preprocessed into fts_.h. > So that > - we follow the naming scheme *.in.h of other header files in gnulib, > - packages like coreutils and findutils are not broken. Fine with me.

Re: bug#77800: grep-3.12: write-error-msg test failure on fedora rawhide (f43)

On Thu, Apr 17, 2025 at 11:15 PM Grisha Levit wrote: > > On Fri, Apr 18, 2025 at 1:51 AM Jim Meyering wrote: > > > > Surprised to find that coreutils-9.5 (fedora 41 stock) works fine: > > > > $ { /bin/printf %4095s; /bin/printf %4096s; } > /dev/full > &g

Re: bug#77800: grep-3.12: write-error-msg test failure on fedora rawhide (f43)

On Tue, Apr 15, 2025 at 9:17 PM Jim Meyering wrote: ... > We're going to have to revise that code. > The difference I see is that before rawhide, that fclose would fail. > It's perfectly fine for fclose to succeed in this case, as now happens > on rawhide (because with 4k BU

Re: bug#77800: grep-3.12: write-error-msg test failure on fedora rawhide (f43)

On Thu, Apr 17, 2025 at 10:35 PM Grisha Levit wrote: > On Fri, Apr 18, 2025, 01:18 Jim Meyering wrote: > > > > On Tue, Apr 15, 2025 at 9:17 PM Jim Meyering wrote: > > ... > > > We're going to have to revise that code. > > > The difference I see is

Re: new snapshot available: grep-3.11.68-05f8

On Tue, Apr 8, 2025 at 9:47 AM Bruno Haible wrote: > Hi Jim, > > > > > On Windows platforms and on AIX in 32-bit mode, grep now supports > > > > Unicode characters outside the Basic Multilingual Plane. > > > > > > I wouldn't claim this, since the support is not yet complete. ... > > ... > > Pa

Re: new snapshot available: grep-3.11.68-05f8

On Sat, Apr 5, 2025 at 10:47 AM Bruno Haible wrote: > Hi Jim, > > Among the news for grep 3.12: > > > On Windows platforms and on AIX in 32-bit mode, grep now supports > > Unicode characters outside the Basic Multilingual Plane. > > I wouldn't claim this, since the support is not yet complete.

Re: announce-gen project link and mirrors

On Thu, Feb 6, 2025 at 3:06 PM Simon Josefsson via Gnulib discussion list wrote: > Announce-gen generate this snippet: > > > Here is the GNU libtasn1 home page: > > https://gnu.org/s/libtasn1/ > > Why? Shouldn't we use the canonical URL in the announcement? I think > the above just looks ugl

Re: tests: Don't use module 'getcwd' as dependency

On Sun, Jan 5, 2025 at 4:36 AM Bruno Haible via Gnulib discussion list wrote: > Building a recent diffutils snapshot on FreeBSD 5.2.1, I see this > compilation error: > > CCLD diff > ../lib/libdiffutils.a(libdiffutils_a-save-cwd.o): In function `save_cwd': > /usr/home/bruno/diffutils-3.10.24

Re: style of reference API documentation

On Sat, Jan 4, 2025 at 12:22 AM Bruno Haible wrote: > Hi Jim, Hi again :-) > > I'm surprised that you would use "more sources use Y" as a rationale > > for using Y. > > I do so for language-related topics. Because language gets defined by > how people use it in their majority. > > Like you, I'm

Re: style of reference API documentation

On Fri, Jan 3, 2025 at 8:04 PM Bruno Haible via Gnulib discussion list wrote: > > Paul Eggert wrote: > > I'm more familiar with the longstanding tradition of Emacs, where the > > manual says "This function returns X." and the doc strings (which is > > closer to what we're talking about here) say "

Re: [PATCH] git-version-gen: Support git-archive tarballs.

On Sat, Dec 28, 2024 at 11:26 AM Simon Josefsson wrote: > > Jim Meyering writes: > > > On Sat, Dec 28, 2024 at 10:01 AM Simon Josefsson > > wrote: > >> Jim Meyering writes: > >> > >> >> if test "x$v" = xUNKNOWN \ > >> &g

Re: [PATCH] git-version-gen: Support git-archive tarballs.

On Sat, Dec 28, 2024 at 10:01 AM Simon Josefsson wrote: > Jim Meyering writes: > > >> if test "x$v" = xUNKNOWN \ > >> && test -f ${tarball_version_file}-git \ > >> && head -1 ${tarball_version_file}-git \ > >>

Re: [PATCH] git-version-gen: Support git-archive tarballs.

Oops. Thank you. Hmm... it shouldn't be hard to make vc-dwim do the right thing by default for projects like gnulib that VC their ChangeLog file. On Sat, Dec 28, 2024 at 9:46 AM Bruno Haible wrote: > > Jim Meyering wrote: > > I've fixed that and cleaned up via this just-p

Re: [PATCH] git-version-gen: Support git-archive tarballs.

On Fri, Dec 27, 2024 at 3:35 AM Simon Josefsson wrote: > Hi Jim, all, Hi Simon, > If I run git-version-gen in a snapshot of a git repository it will > return UNKNOWN because it cannot find out the version. > > Git has a .gitattribute mechanism to mark some files as 'export-subst' > which makes g

Re: Use the translation domain "gnulib"

On Tue, Dec 17, 2024 at 9:25 AM Bruno Haible via Gnulib discussion list wrote: ... > 2024-12-17 Bruno Haible > > xstdopen: Improve error message. > * lib/xstdopen.c (xstdopen): Improve error message. Ignore the errno > value. > > diff --git a/lib/xstdopen.c b/lib/xstdope

Re: GNU Emacs and the translation domain "gnulib"

On Wed, Dec 11, 2024 at 8:05 AM Bruno Haible via Gnulib discussion list wrote: > Paul Eggert wrote: > > Although Emacs uses some Gnulib modules, it doesn't use translations or > > the gettext function so it won't use the "gnulib" translation domain. > > Also, Emacs developers prefer using less Gnu

Re: [PATCH] crc: Add PCLMUL implementation

Jim, would you be willing to be the maintainer for this in gnulib? If so then > I can fix the autoconf this week and get it ready to go > > On Fri, Dec 13, 2024, 19:29 Jim Meyering wrote: >> >> As soon as this is added to gnulib, I'll be happy to prepare for a new &g

Re: [PATCH] crc: Add PCLMUL implementation

As soon as this is added to gnulib, I'll be happy to prepare for a new gzip release that includes it. On Fri, Dec 13, 2024 at 9:45 AM Sam Russell wrote: > > I should also add that I'm planning long term to try and get the major open > source tools (e.g. gzip) using the most efficient algorithms

Re: announce-gen: Show an SHA256 sum that can be verified more easily

On Sun, Dec 1, 2024 at 6:04 AM Simon Josefsson via Gnulib discussion list wrote: > Bruno Haible via Gnulib discussion list writes: > > > The 'announce-gen' script shows SHA256 sums in a way that are hard to verify > > and understand for the users: > > - Verifying requires a special command that

Re: relicense module 'eealloc' under LGPLv2+

Hi Bruno, relicensing like that is fine with me.

Re: Adding slice-by-4 and slice-by-8 to CRC32

On Mon, Oct 14, 2024 at 6:53 AM Bruno Haible via Gnulib discussion list wrote: > Hi Sam, > > Thanks for the contribution offer! > > > I've noticed that GZIP trails behind zlib in performance and part of this > > is down to the fact that zlib is using a more efficient CRC32 > > implementation. > >

crc.h: declare each function with _GL_ATTRIBUTE_PURE

gzip has the same tables/code as gnulib's crc module, so while scoping out the gzip change (to use gnulib's crc), I hit this: crc.c: In function 'crc32_update_no_xor': crc.c:77:1: error: function might be candidate for attribute 'pure' [-Werror=sugge st-attribute=pure] 77 | crc32_update_no_xor

Re: CI with clang 18 ?

On Sat, Jul 13, 2024 at 12:16 AM Bruno Haible wrote: > I wrote: > > so I can know why the CI did not report it within three weeks > > That was because the compilation error occurred only with clang 18, > which was released in March 2024 and is therefore not yet present > in the *BSD distros. > > I

Re: maint.mk: RELEASE leaking into VERSION

On Wed, Jul 3, 2024 at 12:16 PM Jim Meyering wrote: > > Hi Simon, thanks for diagnosing and reporting that. Did you consider > whether using GNU make's $(origin VAR) function will be sufficient? > I.e., use VERSION only if it's specified on the command line, not > me

Re: maint.mk: RELEASE leaking into VERSION

Hi Simon, thanks for diagnosing and reporting that. Did you consider whether using GNU make's $(origin VAR) function will be sufficient? I.e., use VERSION only if it's specified on the command line, not merely if it appears in the environment? On Wed, Jul 3, 2024 at 10:50 AM Simon Josefsson via Gn

Re: bootstrap-funclib.sh: shrink or split too-long lines

On Sat, Jun 29, 2024 at 5:11 PM Bruno Haible wrote: > 2024-06-29 Bruno Haible > > bootstrap-funclib.sh: Restore readability. > * top/bootstrap-funclib.sh (prepare_GNULIB_SRCDIR): Add a line break > instead of removing spaces. > * build-aux/bootstrap: Regenerated.

Re: considering L1 cache

You might be interested in this implementation: https://engineering.fb.com/2019/04/25/developer-tools/f14/ On Mon, May 13, 2024 at 4:24 PM Bruno Haible wrote: > > Paul Eggert wrote: > > I installed the > > attached. This probably a win (over de Bruijn too), at least for some > > apps and platform

Re: [PATCH] announce-gen: Mention git commit in release announcement.

I like it. Wording and placement are spot on. Thanks. On Sun, May 12, 2024, 08:42 Simon Josefsson via Gnulib discussion list < bug-gnulib@gnu.org> wrote: > All, > > Our release announcements does not mention the git commit hash that was > used to prepare the release. While SHA1 is broken, I sti

Re: syntax-check rule to silence -Winclude-next-absolute-path warning

On Mon, Feb 19, 2024 at 12:45 AM Simon Josefsson wrote: > Bruno Haible writes: > > --- a/top/maint.mk > > +++ b/top/maint.mk > > @@ -503,6 +503,7 @@ sc_prohibit_have_config_h: > > # Nearly all .c files must include . However, we also permit > > this > > # via inclusion of a package-specific h

Re: syntax-check rule to silence -Winclude-next-absolute-path warning

On Mon, Feb 19, 2024 at 10:11 AM Collin Funk wrote: > Jim Meyering writes: > > Thank you both. I've just pushed an improvement. > > The new version runs grep only once rather than many times, and seems > > simpler. > > Thanks. This one seems much better. It also

Re: syntax-check rule to silence -Winclude-next-absolute-path warning

On Sun, Feb 18, 2024 at 12:33 PM Bruno Haible wrote: > Collin Funk wrote: > > I attached a patch that seems to work alright. I'm not the greatest with > > GNU Make so it isn't very pretty. Feel free to modify it as much as you > > would like. > > > > Here is some sample output from Coreutils. On

Re: test-argp and clang's ASAN

On Sun, Dec 3, 2023 at 4:58 AM Bruno Haible wrote: > In a testdir of module 'argp', built with clang 17 and -fsanitize=address, > I see this test failure: > > $ cat test-argp-2.sh.log > --- expected2023-12-03 12:52:58.892318895 +0100 > +++ out 2023-12-03 12:52:58.904318928 +0100 > @@ -27,9 +27

Re: [PATCH] announce-gen: Allow using local git user.name.

On Mon, Jul 17, 2023 at 1:12 PM Simon Josefsson via Gnulib discussion list wrote: > Hi. I think announce-gen should use the username provided by the > per-repo .git/config rather than the global ~/.gitconfig. > > I hit this corner on build farms where I don't want to modify files > outside of the

Re: From wchar_t to char32_t

On Sat, Jul 1, 2023 at 7:35 AM Bruno Haible wrote: > > Here is a proposed patch to overcome the wchar_t limitation in the 'dfa' > module. > > Jim: The background is explained in > > The plan was exposed in >

Re: uses of xinmalloc and xpmalloc triggered make syntax-check failure

On Fri, Jun 9, 2023 at 3:39 AM Pádraig Brady wrote: > On 07/06/2023 05:34, Jim Meyering wrote: > > I noticed some syntax-check failures in diffutils. > > Its uses of relatively new xinmalloc and xpmalloc functions triggered a > > "make syntax-check" failure cla

Re: uses of xinmalloc and xpmalloc triggered make syntax-check failure

On Wed, Jun 7, 2023 at 1:38 AM Bruno Haible wrote: > Jim Meyering wrote: > > regenerate regex to reflect new functions in xalloc.h > > How did you do that? By hand, or using some of the techniques from [1] or [2]? Hi Bruno, the comments just above include the commands I ra

uses of xinmalloc and xpmalloc triggered make syntax-check failure

nt list of functions. I expect to regenerate other syntax-checked header regexps and may find time to automate the update process. >From 1496e1fbe5bd7a9302d9168e9dc1864f1e435547 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 6 Jun 2023 20:49:22 -0700 Subject: [PATCH] maint.mk: regene

Re: error: Support the compiler's control flow analysis better (was: copy-file: Silence gcc warnings)

On Wed, May 31, 2023 at 9:12 AM Pádraig Brady wrote: > On 30/05/2023 22:29, Paul Eggert wrote: > > On 5/28/23 06:07, Pádraig Brady wrote: > >> There still is a gotcha (hit in dd.c in coreutils) > >> where if you define an error macro yourself > >> you get a macro redefinition error, > > > > I see

Re: [PATCH] file-has-acl: avoid warning from bleeding-edge GCC

On Sun, May 28, 2023 at 10:44 AM Bruno Haible wrote: > How about adding -Wno-suggest-attribute to the list of warning options that > are part of the GL_CFLAG_GNULIB_WARNINGS variable, no that such warnings > function might be candidate for attribute 'pure' > or > function might be candidate fo

Re: [PATCH] file-has-acl: avoid warning from bleeding-edge GCC

On Sun, May 28, 2023 at 10:08 AM Bruno Haible wrote: > > Hi Jim, > > Jim Meyering wrote: > > FYI, just pushed, to avoid this: > > > > lib/file-has-acl.c: In function 'have_xattr': > > lib/file-has-acl.c:54:1: error: function might be candida

[PATCH] file-has-acl: avoid warning from bleeding-edge GCC

char const *listbuf, ssize_t listsize) >From 2bd4c8dc13de3121d76dad755a255c8e92fd46a7 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 28 May 2023 09:41:08 -0700 Subject: [PATCH] file-has-acl: avoid warning from bleeding-edge GCC * lib/file-has-acl.c: Include attribute.h. (have_xattr): Decl

Re: [bug-diffutils] bug#63333: [PATCH] Add hurd-amd64 support

On Sat, May 6, 2023 at 8:34 PM Samuel Thibault wrote: > This adds SIGSEGV_FAULT_STACKPOINTER for the hurd-amd64 case > > --- ./lib/sigsegv.c.original2023-05-05 10:45:54.673751100 + > +++ ./lib/sigsegv.c 2023-05-05 10:48:47.903577554 + > @@ -351,6 +351,17 @@ > "old esp, if trapp

Re: FYI: disable gnulib's strtoull and strtoll tests

On Wed, May 3, 2023 at 1:34 AM Bruno Haible wrote: > Hi Jim, > ! It smells like you are using an old config.cache ? > > Or possibly there is a 'config.site' file? The configure output should > show if one is loaded. Thanks for looking, Bruno. I think you must be right about it being due to an old

Re: FYI: disable gnulib's strtoull and strtoll tests

On Sun, Apr 30, 2023 at 11:14 PM Jim Meyering wrote: > > On Sun, Apr 30, 2023, 22:54 Bruno Haible wrote: >> >> Hi Jim, >> >> > We've seen gnulib's new strtoll and strtoull tests for 0x and 0b failing >> > on too many systems >> >> C

Re: FYI: disable gnulib's strtoull and strtoll tests

On Sun, Apr 30, 2023, 22:54 Bruno Haible wrote: > Hi Jim, > > > We've seen gnulib's new strtoll and strtoull tests for 0x and 0b failing > > on too many systems > > Can you please name one (or some of) these systems? So that I can > reproduce the problem. And, if you have it readily available, >

FYI: disable gnulib's strtoull and strtoll tests

dora 38. >From 2ea921979769dc49865931f82f5e1d75b957ee83 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 30 Apr 2023 02:55:16 -0700 Subject: [PATCH] tests: temporarily omit gnulib's strtoll and strtoull tests * bootstrap.conf (avoided_gnulib_modules): Omit strtoll and strtoull tests, because the edge-case 0[b

[PATCH] tests: set executable bit in test-trim[1-3].sh

I tried latest gnulib with grep and saw three easily-fixed failures, so I've pushed this: >From d7e034a02c4ede22045be9165e68cea1990cfd6a Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 3 Apr 2023 12:27:46 -0700 Subject: [PATCH] tests: set executable bit in test-trim[1-3].sh This

[PATCH] gnu-web-doc-update: don't use host alias, cvs.sv.gnu.org

The usual post-release command to update grep-3.10's web docs failed for me. This fixed it. >From 78f594f7ac9315c655f663976da1d42a4ccb9b21 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 22 Mar 2023 19:51:12 -0700 Subject: [PATCH] gnu-web-doc-update: don't use host alias, c

Re: bug#62267: grep-3.9 bug: \d matches multibyte digits

On Sun, Mar 19, 2023 at 4:12 PM Paul Eggert wrote: > On 2023-03-19 13:44, Jim Meyering wrote: > > I've pushed your change along with the attached. > > I'll probably create another snapshot today. > > Thanks. I also installed a minor dfa.c change in Gnulib yeste

Re: removing permissions for long unused accounts, take 2

On Thu, Mar 9, 2023 at 8:49 AM Paul Smith wrote: > > On Thu, 2023-03-09 at 15:54 +0100, Bruno Haible wrote: > > If you have a checkout of GNU gnulib, in order to successfully do a > > "git pull" again, you will have to change the .git/config file, > > Is it better to suggest Git's CLI interface fo

Re: [PATCH] bootstrap: remove code that accommodated RHEL5's old autoreconf

On Thu, Mar 9, 2023 at 9:14 AM Bruno Haible wrote: > Hi Jim, > > $ /gnu-inst-autoconf/2.59/bin/autoreconf --help | grep no-recursive > $ /gnu-inst-autoconf/2.60/bin/autoreconf --help | grep no-recursive > --no-recursive don't rebuild sub-packages > $ /gnu-inst-autoconf/2.71/bin/autorec

[PATCH] bootstrap: remove code that accommodated RHEL5's old autoreconf

FYI, I've just pushed this: >From 074cf4b3753f2f37927eebdad8ebb1dd74ba057f Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 9 Mar 2023 08:41:07 -0800 Subject: [PATCH] bootstrap: remove code that accommodated RHEL5's old autoreconf * top/bootstrap-funclib.sh (autogen) [AU

Re: License of module "Perl" seems wrong

On Mon, Feb 27, 2023 at 6:05 AM Bruno Haible wrote: > Hi Reuben, > > Reuben Thomas wrote: > > The perl module has a GPL license, but its only file, m4/perl.m4, has an > > "unlimited" license. > > The license of a module, in the module description, cannot be "wrong" since > that's the authoritative

Re: FYI: announce-gen: add more info to the auto-generated announce template

On Sat, Feb 25, 2023 at 11:56 PM Bruno Haible wrote: > Jim Meyering wrote: > > from coreutils-9.2 or openBSD's cksum since 2007. > > It's the first time I see OpenBSD spelled this way. Why not use an > uppercase 'O', like they do themselves [1] ? Thanks. Corrected.

FYI: announce-gen: add more info to the auto-generated announce template

in the 55 weeks since 3.7. See the NEWS below for a brief summary. Thanks to everyone who has contributed! The following people contributed changes to this release: Carlo Marcelo Arenas Belón (2) Helge Kreutzmann (1) Jim Meyering (27) Ondřej Fiala (1) Paul Eggert (71) Ulrich Eckhardt (

Re: fts: Document this module

On Thu, Jan 19, 2023 at 7:05 PM Paul Eggert wrote: > > On 1/19/23 15:41, Bruno Haible wrote: > > Jim or Paul, what should we state > > — either in the 'fts' module description, or in the .texi documentation? > > The quick thing is to say in both that the description/documentation is > incomplete,

Re: RFC: git-commit based mtime-reproducible tarballs

On Mon, Jan 16, 2023, 12:41 AM Simon Josefsson via Gnulib discussion list < bug-gnulib@gnu.org> wrote: > Bruno Haible writes: > > > Paul Eggert wrote: > >> some users want to "trust but verify" and a reproducible > >> tarball is easier to audit than a non-reproducible one, so for these > >> users

Re: FYI: update-copyright: also work with two or more updatable lines

On Tue, Jan 10, 2023 at 8:37 PM Jim Meyering wrote: > FYI, I've just pushed this fix. > I noticed this bug when attempting to update gzip's copyright dates. > It has a few files with two copyright lines. > The old version of this script would update only the first one. Fo

FYI: update-copyright: also work with two or more updatable lines

@@ -1,3 +1,10 @@ +2023-01-10 Jim Meyering + + update-copyright: also work with two or more updatable lines in a file + * build-aux/update-copyright: Replace every occurrence of the copyright + line, not just the first one. + * tests/test-update-copyright.sh: Add a test case for this. + 2023-01-10

Re: [PATCH] vc-list-files-tests: Avoid OpenPGP private key operations.

On Sun, Nov 13, 2022 at 3:00 AM Simon Josefsson via Gnulib discussion list wrote: > Hi. I had a background job doing 'make check' in a project that > triggered a GnuPG private key operation PIN prompt... this was > surprising to me, and the attached fix should avoid that happening. If > my PIN h

Re: maint.mk: public-submodule-commit rule is broken

On Mon, Sep 12, 2022 at 3:32 AM Simon Josefsson wrote: > Btw, see my concerns with this code earlier here: > > https://lists.gnu.org/archive/html/bug-gnulib/2022-08/msg00040.html > https://lists.gnu.org/archive/html/bug-gnulib/2022-08/msg00044.html > > Instead of the patch, I have merely disabled

Re: Fix a couple of ShellCheck warnings

On Sat, Jul 23, 2022 at 1:57 PM Bruno Haible wrote: > The other issues reported by ShellCheck are pretty harmless. Still, fixing > some of them can improve security or code clarity. > > 2022-07-23 Bruno Haible > > Fix a couple of ShellCheck warnings. > * MODULES.html.sh (sed_esc

Re: removing permissions for long unused accounts, take 2

On Tue, Jul 12, 2022 at 10:18 PM Bruno Haible wrote: > Hi, > > I started this topic in 2021, in [1]: a proposal to remove write > permissions from accounts who haven't pushed in a long while. > There was agreement [2] that contributors who had not directly pushed > a commit in a year could be revo

Re: announce-gen usage feedback

On Sat, Jul 9, 2022 at 6:29 AM Simon Josefsson via Gnulib discussion list wrote: > > Bruno Haible writes: > > > Hi Simon, > > > > Two remarks regarding 'announce-gen': > > > > 1) I used the command > >$ $GNULIB_SRCDIR/build-aux/announce-gen --release-type stable \ > >--package-name li

FYI, fix the hash.h inclusion-not-needed syntax-check rule

FYI, I've just pushed this fix for the hash.h syntax-check rule: >From fc555c0a4bf23b3418e0e9cc3a0800172b716b90 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 23 Jun 2022 08:12:44 -0700 Subject: [PATCH] maint.mk: fix syntax-check for unnecessary hash.h header use * top/

Re: [PATCH 2/3] dfa: new option DFA_STRAY_BACKSLASH_WARN

On Mon, Jun 6, 2022 at 3:06 PM Paul Eggert wrote: > On 6/6/22 12:37, Jim Meyering wrote: > > Once you push that (and assuming you have nothing else pending), I'll > > prepare another pre-release snapshot. > > Thanks, I pushed it into grep master, after fixing the comm

Re: Drop Gnulib support for ecvt, fcvt, gcvt, getw, putw?

On Sun, Jun 12, 2022, 1:11 PM Paul Eggert wrote: > The functions ecvt, fcvt, gcvt, getw, putw are no longer in POSIX and > the glibc manual pretty much recommends against them. How about if we > drop Gnulib support for them? This would speed up 'configure' a bit, > among other things. As far as I

Re: [PATCH 2/3] dfa: new option DFA_STRAY_BACKSLASH_WARN

On Sun, Jun 5, 2022 at 10:45 AM Paul Eggert wrote: > On 6/4/22 18:45, Bruno Haible wrote: > > And maybe some people find it OK to get the "stray \ before -" warning for > >grep -e '\-x' FILE > > and to inhibit it only when the option -e or the marker '--' is not used? > > Yes, thanks, this nar

Re: "grep '\]'" warnings suggest a Gnulib DFA patch

On Fri, Jun 3, 2022 at 8:09 PM Bruno Haible wrote: > Paul Eggert asked: > > So, what do you think of the idea of not warning for this particular > > stray backslash? Proposed Gnulib patch attached, with the idea of > > propagating this into GNU grep before its upcoming release. I haven't > > insta

Re: [platform-testers] Test failures for grep-3.7.62-9a668

On Sat, Apr 30, 2022 at 1:14 PM Bruno Haible wrote: > Nelson H. F. Beebe wrote: > > I did builds of grep-3.7.62-9a668 on 29 systems today ... > > > > On Solaris 11.4 x86_64: > > > > ../build-aux/test-driver: line 112: 14630: Memory fault > > ../build-aux/test-driver: line 112: 15129: M

Re: [PATCH 2/2] xstrtol: simplify integer overflow checking

xstrtol: remove unnecessary else after return * lib/xstrtol.c (bkm_scale): Drop "else" after return. diff --git a/ChangeLog b/ChangeLog index 2ea372b0e3..ff78fda8f3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2022-01-17 Jim Meyering + + xstrtol: remove un

Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints

On Wed, Jan 5, 2022 at 9:46 AM Bruno Haible wrote: ... > 2022-01-05 Bruno Haible > > gnulib-tool: Avoid known warnings that reflect Gnulib's coding style. > * m4/gnulib-common.m4 (gl_CC_GNULIB_WARNINGS): New macro. > * gnulib-tool (func_emit_lib_Makefile_am): Add the >

Re: Some generated header files are messed up on Alpine

On Sat, Jan 1, 2022 at 12:15 PM Bruno Haible wrote: > Paul, > > I suggest the attached patch. Objections? Looks fine to me. Thanks for the speedy fix.

Re: makefile rules

On Tue, Dec 21, 2021 at 5:21 PM Paul Eggert wrote: > On 12/21/21 12:23, Jim Meyering wrote: > > Even with `mv -f` support, one must still either remove $@-t or otherwise > > ensure that it is writable. The read-only temporary may have been left > > behind > > from a pr

Re: makefile rules

On Tue, Dec 21, 2021 at 12:12 PM Paul Eggert wrote: > On 12/21/21 11:50, Jim Meyering wrote: > > One must delete $@ and the potential $@-t temporary file in any rule > > that creates a generated file and marks it (as I prefer always to do) as > > read-only by using ch

Re: makefile rules

On Tue, Dec 21, 2021 at 11:41 AM Paul Eggert wrote: ... > If you run 'make' sometimes as one user and sometimes as another, you > can have problems like that no matter what. We don't put 'rm -f $@' at > the start of every other makefile recipe to work around those problems; > why are these recipes

Re: Accommodate non-recursive Automake in a less hacky way

On Wed, Dec 15, 2021 at 11:38 AM Ben Pfaff wrote: > On Wed, Dec 15, 2021 at 11:31 AM Bruno Haible wrote: > > With the attached patches, 'gnulib-tool' gains the functionality to > > generate a "non-recursive" Automake Makefile.am snippet, similar to > > what the 'non-recursive-gnulib-prefix-hack'

Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints

On Wed, Dec 8, 2021 at 7:48 AM Bruno Haible wrote: > > > especially given it's in the gcc -Wextra set, not some random flag > > Warnings in the '-Wall' category are typically worth eliminating: they > regularly point to real bugs. > > Eliminating '-Wsign-compare' warnings, OTOH, is usually a waste

Re: [PATCH] maint: Avoid syntax-check failure for empty gnulib submodule.

On Mon, Sep 20, 2021 at 12:49 AM Simon Josefsson via Gnulib discussion list wrote: > Hi, > > Some syntax-check rules have a really poor failure mode (it prints all > source code files to stdout) when the 'gnulib_dir' points to an empty > git submodule checkout, see for example: > > https://storage

Re: #include on Android clang causes an error

On Thu, Sep 9, 2021 at 12:27 PM Lucy Phipps wrote: > > -- Forwarded message - > From: Lucy Phipps > Date: Thu, Sep 9, 2021 at 11:25 AM > Subject: Re: #include on Android clang causes an error > To: Paul Eggert > > it works perfectly now! and yeah i was planning on applying this

Re: [PATCH] maintainer-makefile: Add indentation syntax-check rule.

On Fri, Sep 3, 2021 at 10:06 PM Simon Josefsson via Gnulib discussion list wrote: > Hi. I realized the main reason I don't consistenly enforce code > indentation in the projects I work on is that it isn't tested before > releases (or via CICD builds). The syntax-check framework to the > rescue!

Re: buildbot failure in OpenCSW Buildbot on ggrep-solaris10-i386

gt;> Buildslave for this Build: unstable10x > >>> > >>> Build Reason: The SingleBranchScheduler scheduler named > >>> 'schedule-ggrep-solaris10-i386' triggered this build > >>> Build Source Stamp: [branch master] > >>> 6aaef3b8a7f109ab8f39

Re: buildbot failure in OpenCSW Buildbot on ggrep-solaris10-i386

uildbot URL: https://buildfarm.opencsw.org/buildbot/ > > Buildslave for this Build: unstable10x > > Build Reason: The SingleBranchScheduler scheduler named > 'schedule-ggrep-solaris10-i386' triggered this build > Build Source Stamp: [branch master] 6aaef3b8a7f109ab8f39fd46ede01aebbd9f82

Re: announce-gen and OpenPGP key servers

On Tue, Aug 3, 2021 at 12:25 PM Paul Eggert wrote: > On 8/3/21 12:20 PM, Simon Josefsson via Gnulib discussion list wrote: > > + print "\nThe SHA256 checksum is base64 encoded and not hexadecimal,\n"; > > + print "which is the default for most checksum tools.\n\n"; > > Perhaps this? > >print

Re: announce-gen and OpenPGP key servers

On Tue, Aug 3, 2021 at 8:40 AM Simon Josefsson wrote: > Jim Meyering writes: > > > Feel free to make the script generate a full fingerprint and even > > (though it feels a little like giving up) add a checksum or two. > > I think checksums still serve a purpose. > >

Re: any pending fixes? preparing for diffutils release

On Sun, Aug 1, 2021 at 10:36 PM Paul Eggert wrote: > One minor problem I just discovered with the now-released diffutils 3.8, > a problem that was caused by my recent Gnulib changes, is that building > diffutils on RHEL 8.4 results in diagnostics like the following: > > In file included from dirna

Re: any pending fixes? preparing for diffutils release

On Sun, Aug 1, 2021 at 3:15 PM Paul Eggert wrote: > I've recently been improving some GCC-based static analysis in Gnulib, Welcome changes. Thanks! > and syncing from Gnulib to diffutils meant that you have a bit of a > work-in-progress there. I plan to make further such changes soon. No proble

any pending fixes? preparing for diffutils release

I am ready to release diffutils-3.8, but in order to get it to compile warning-free with configure's --enable-gcc-warnings and GCC 11.2.1, I had to push another -fanalyze-pacification patch to regex_internal.c, just minutes ago. Given that this made diffutils pull in gnulib changes since the snapsh

Re: fts in gnulib behave different than glibc

On Thu, Jul 29, 2021 at 3:22 AM Simon Josefsson wrote: > > Jim Meyering writes: > > > On Wed, Jul 28, 2021 at 1:08 AM Simon Josefsson via Gnulib discussion > > list wrote: > >> Hi. I replaced GNU InetUtils' old custom fts implementation with the > >

Re: fts in gnulib behave different than glibc

On Wed, Jul 28, 2021 at 1:08 AM Simon Josefsson via Gnulib discussion list wrote: > Hi. I replaced GNU InetUtils' old custom fts implementation with the > one from gnulib, but self-tests started failing. Looking at the code, > it seems gnulib's fts implementation has diverged compared to glibc,

Re: [PATCH] maintainer-makefile: Fix announcement mail CC's.

On Wed, Jul 28, 2021 at 1:50 AM Simon Josefsson via Gnulib discussion list wrote: > Simon Josefsson via Gnulib discussion list writes: > > > Hi. I noticed some typos causing the Cc line in mail announcements to > > be empy where that (most likely) wasn't the intention. > > It seems some packages

Re: announce-gen and OpenPGP key servers

On Tue, Jul 27, 2021 at 2:38 AM Simon Josefsson via Gnulib discussion list wrote: > Hi. Our announce-gen contains: > > If that command fails because you don't have the required public key, > then run this command to import it: > gpg --keyserver keys.gnupg.net --recv-keys $gpg_key_id > > Giv

Re: warnings in unit tests

On Mon, Jun 7, 2021 at 7:41 PM Bruno Haible wrote: > Hi Jim, > > > > > > @@ -183,6 +183,9 @@ main () > > > > >*(volatile int *) (page + 0x678) = 42; > > > > >break; > > > > > case 3: > > > > > +#if 6 < __GNUC__ > > > > > +# pragma GCC diagnostic ignored "-Wnull-dereference" >

Re: new module 'sigsegv'

On Mon, Jun 7, 2021 at 3:29 AM Dmitry V. Levin wrote: > Hi, > On Mon, Jun 07, 2021 at 02:49:35AM +0200, Bruno Haible wrote: > [...] [...] > > > @@ -183,6 +183,9 @@ main () > > >*(volatile int *) (page + 0x678) = 42; > > >break; > > > case 3: > > > +#if 6 < __GNUC__ > > > +# pr

Re: test suite failure caused by check-copyright script

On Sun, May 23, 2021, 8:05 AM Bruno Haible wrote: > Does everyone still agree > - to put into the source files a license header that is consistent > with the module description, and > - to remove the statement from the documentation > "The source files always say "GPL", but the real l

Re: error, getprogname: Relicense under LGPLv2+

> https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=f29814b96c9737abc8193d57d630697700feebeb > Paul Eggert > for > https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=aad5573e2e307ba42eea5b6b76b0b9788a5eaaec > > For lib/getprogname.c we would need the approval of &g

Re: removing permissions for long unused accounts?

On Sun, Feb 21, 2021 at 10:36 AM Jeffrey Walton wrote: > > On Sun, Feb 21, 2021 at 1:20 PM Bruno Haible wrote: > > > > On another GNU mailing list, someone is writing: > > > > Since I no longer work on I give > > you permission to remove my git server access (the key). If I ever > > change

Re: different CFLAGS for gnulib code?

On Fri, Jan 15, 2021 at 12:55 AM Bruno Haible wrote: > Jeffrey Walton wrote: > > Perhaps it would be a good idea to filter-out the options that you > > don't want present for Gnulib. ... > It is an interesting idea. Leaving the question aside how it is implemented > (through an AC_SUBSTed variable

Re: syntax-checks with names containing the letter w not invoked

On Mon, Jan 4, 2021 at 2:44 PM Jim Meyering wrote: > > On Mon, Jan 4, 2021 at 2:22 PM Simon Josefsson via Gnulib discussion > list wrote: > > Hi. I noticed that 'make syntax-check' never ran syntax checks whose > > name contained 'w' on my loc

  1   2   3   4   5   6   7   8   9   10   >