re` argument ought to override
Gnulib's decision to supply a replacement.
--
Colin Watson (he/him) [cjwat...@debian.org]
* users.txt: Add libpipeline.
---
users.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/users.txt b/users.txt
index c8382ace28..c57ec59365 100644
--- a/users.txt
+++ b/users.txt
@@ -58,6 +58,7 @@ The following packages appear to be using gnulib and
gnulib-tool:
libidn https://
, sizeof state);
state.root_argp = argp;
_help (argp, &state, stream, flags, name);
}
As a result it was possible at the time to encounter the case where
state was non-NULL but state->pstate was NULL. However, this seems to
have been fixed differently some time ago:
https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=14a582531c
So I think it's probably fine to drop this patch from GRUB.
--
Colin Watson (he/him) [cjwat...@ubuntu.com]
nge my default
use of language here.
However, I'm sorry I got it wrong in this case. When somebody has told
me what pronouns they use then I always try to use those instead of a
placeholder, so I will of course refer to you using "he" etc. pronouns
in future.
Regards,
--
Colin W
the quick response. I can confirm that this fixes the
original problem I saw.
--
Colin Watson (he/him) [cjwat...@debian.org]
IX[_STDLIB_H_MODULE_INDICATOR_DEFAULTS])".
And indeed, when I back out that commit, things work again; but it was
tagged as a regression fix, so evidently something else breaks. CCing
Bruno since this was their commit and they might want to have a look.
Thanks,
--
Colin Watson (he/him) [cjwat...@debian.org]
; Can we be friends again?
Of course. Thanks for clarifying your position!
--
Colin Watson [cjwat...@debian.org]
hat really feels like an interface omission;
I'd be happy to put together a patch for that if I thought it might be
accepted. I see that you may have a different view, though. (Of course
gl_list doesn't need this because gl_list_search returns a node rather
than the element itself, while gl_set_search returns a bool; the
asymmetry is a bit surprising to someone learning the interface, but
understandable enough.)
Thanks,
--
Colin Watson [cjwat...@debian.org]
It's sometimes convenient to have a map whose values may be NULL, but in
that case it's a little awkward to determine whether a key exists in the
map: gl_map_get returns NULL for both "key not found" and "value is
NULL", so one needs a local variable just for the purpose of passing its
address to g
Without this, we get "error: 'CHAR_BIT' undeclared".
* tests/test-array_map.c: Include .
* tests/test-hash_map.c: Likewise.
* tests/test-linkedhash_map.c: Likewise.
---
tests/test-array_map.c | 1 +
tests/test-hash_map.c | 1 +
tests/test-linkedhash_map.c | 1 +
3 files changed, 3 inse
ootstrap rather than keeping generated files in git).
--
Colin Watson [cjwat...@debian.org]
On Wed, Jul 18, 2018 at 02:26:03PM +0100, Colin Watson wrote:
> Previously, we created files such as $pobase/Makefile.in.in and then the
> subsequent rsync would immediately delete them.
>
> * build-aux/bootstrap (po_download_command_format): Avoid deleting
> non-.po files in t
On Wed, Jul 18, 2018 at 02:26:03PM +0100, Colin Watson wrote:
> diff --git a/build-aux/bootstrap b/build-aux/bootstrap
You'll probably want to update scriptversion here too, but this felt
like something more readily done by the maintainer applying the commit.
--
Coli
Previously, we created files such as $pobase/Makefile.in.in and then the
subsequent rsync would immediately delete them.
* build-aux/bootstrap (po_download_command_format): Avoid deleting
non-.po files in target directory when rsyncing translations.
* gnulib-tool (func_import): Likewise.
* pygnuli
On Sun, May 27, 2018 at 10:17:40PM +0200, Bruno Haible wrote:
> I've pushed both patches in your name now.
>
> Had to adapt them a bit because the file 'build-aux/bootstrap' had been
> reindented meanwhile.
Thanks!
--
Colin Watson [cjwat...@debian.org]
There are many possibilities for how Gnulib sources are fetched, and
they're rather hard to figure out without reading the code.
* build-aux/bootstrap (usage): Document how Gnulib sources are fetched.
Signed-off-by: Colin Watson
---
build-aux/bootstrap
f my
previous patch in
https://lists.gnu.org/archive/html/bug-gnulib/2018-04/msg00029.html,
which is unchanged.
Sorry for taking so long to get back to this!
--
Colin Watson [cjwat...@debian.org]
the things that you can already control by way of .gitmodules,
except without having to use git submodules with all their little
oddities.
If something I did led you to believe these were intended as
command-line options or as environment variables, then please tell me
what.
The question "Which
onour GNULIB_URL and GNULIB_REVISION in
bootstrap.conf when fetching gnulib using "git clone" or via
GNULIB_SRCDIR.
Signed-off-by: Colin Watson
---
build-aux/bootstrap | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/build-aux/bootstrap b/build-aux/
sing the fallback.
OK. The existing gl_cv_func_futimens_works test already spots the
problem, but it's in m4/futimens.m4, which is one module layer up from
lib/utimens.c. Duplicating that code would seem suboptimal. What would
you advise here?
Thanks,
--
Colin Watson
On Wed, Sep 24, 2014 at 12:37:58PM +0100, Pádraig Brady wrote:
> Sounds like it would come under the few line change "trivial" criteria,
> so please send the path on.
OK, thanks. Attached here.
--
Colin Watson [cjwat...@d
ore
calling futimens, fdutimens must check whether UTIME_NOW or UTIME_OMIT
was used (i.e. adjustment_needed > 0). If so, it should resolve them to
real times.
Thanks,
--
Colin Watson [cjwat...@debian.org]
mebody with more experience comment?
Thanks,
--
Colin Watson [cjwat...@ubuntu.com]
On Wed, Jun 05, 2013 at 06:59:24AM -0600, Eric Blake wrote:
> On 06/05/2013 06:36 AM, Colin Watson wrote:
> > Eric Blake wrote:
> >> clearenv() is non-standard (it is a glibc extension); but yes, glibc
> >> documents that "environ = NULL" is a portable alter
On Wed, Jun 05, 2013 at 06:13:50AM -0600, Eric Blake wrote:
> On 06/05/2013 03:10 AM, Colin Watson wrote:
> > I've had multiple reports (https://savannah.nongnu.org/bugs/?36848,
> > https://bugs.gentoo.org/show_bug.cgi?id=244517) telling me that FreeBSD
> > is missing t
t;
portable, or does it need something cleverer?
Thanks,
--
Colin Watson [cjwat...@debian.org]
: warning: '__leaf__' attribute has no effect on unit local
functions [-Wattributes]
These are from uses of __THROW on static functions. Is it perhaps worth
using (and defining if necessary) __THROWNL instead, which I think would
pacify these warnin
... not segfault.
I've tracked this down to a bug in Gnulib. It's reproducible using the
attached test file in a scratch project with the argp module.
I suggest the following patch:
>From 5171cd55e535fef406e8f170f648723655933e53 Mon Sep 17 00:00:00 2001
From: Colin Watson
Date: Thu
On Sat, Dec 04, 2010 at 12:09:22PM +, Reuben Thomas wrote:
> On 4 December 2010 11:07, Colin Watson wrote:
> > On Fri, Dec 03, 2010 at 08:15:23PM +, Reuben Thomas wrote:
> >> Is the spacing of the --help for --no-justification a joke? It
> >> backfires rather
uld a Gnulib maintainer send an updated POT file to the TP robot?
Thanks,
--
Colin Watson [cjwat...@debian.org]
On Sun, Feb 14, 2010 at 03:02:14PM +0100, Jim Meyering wrote:
> Colin Watson wrote:
> > I looked at converting man-db to use Gnulib's hash implementation rather
> > than its own. One obstacle seems to be that there is one place where
> > man-db cares about the differen
raw; most high-level languages' built-in hash implementations allow you
to ask whether a key exists without testing the truth of its value.
The attached patch adds this feature.
Thanks,
--
Colin Watson [cjwat...@debian.org]
diff --git a/ChangeLog b/Chan
ing bits of gnulib. :-)
> The proper way to go would be to update the upstream gnulib.pot, which
> has not happened for one and a half years. That, however, is out of my
> reach.
Indeed, http://translationproject.org/POT-files/gnulib-1.1.pot is
looking a bit stale. Could someb
On Tue, Mar 17, 2009 at 01:14:33AM +0100, Bruno Haible wrote:
> Colin Watson wrote:
> > I would find it more elegant to install all the files separately and
> > have a defined ordering between them
>
> It may work for you. For the general developer, I think it opens too
>
rg/msg01896.html.
Beyond the gettext compatibility issue, there are many files in gnulib
that have serial lines in a format not recognised by aclocal that have
nothing to do with gettext. Is there a good reason for these? I'd list
them here but there seem to be over 300 of them.
Thanks,
--
Colin Watson [cjwat...@debian.org]
4, and so gettext's macros always end up preferred
over gnulib's for me, regardless of serial numbers.
Could the "foo.m4" bit at the start of the serial line in these files
please be removed, or else moved after the serial number?
Thanks,
--
Colin Watson [cjwat...@debian.org]
lly-installed
versions of tools all the time; I much prefer to have my
maintainer-dependencies all packaged if possible because as a Debian
developer that's what I'm used to. If a newer version of gnulib doesn't
work for me, well then I just hold back the last version t
uld it be controlled by a command-line option to
autoreconf? I prefer to run 'gnulib-tool --update' every time I
regenerate my autotools files, but I have a feeling some people follow
different practices.
I understand I'd need to send this to bug-autoconf, but wanted to run it
by thi
ing short options.
The --regex option is enabled by default.
Report bugs to [EMAIL PROTECTED]
The attached patch fixes this.
2008-08-06 Colin Watson <[EMAIL PROTECTED]>
* lib/argp-help.c (argp_doc): Don't translate the empty string.
Thanks,
--
Colin Watson
e to
avoid tripping source code checkers.
2008-08-06 Colin Watson <[EMAIL PROTECTED]>
Merge some glibc changes into lib/argp-help.c.
* lib/argp-help.c: Include for uint8_t, required by
changes below.
2006-05-09 Ulrich Drepper <[EMAIL PROTECTED]>
d instead.
However, on reflection, I'm not certain that this is correct;
arguably it needs to walk up the tree until it finds a domain to
use. This depends on whether you think that argp_domain == NULL
means "use default program domain" or "use same domain as paren
On Mon, Jan 14, 2008 at 11:45:17PM +0100, Bruno Haible wrote:
> The mention of a file "strsignal.h" is wrong; I'm fixing it like this:
A vestige of an earlier version of the module. Thanks for spotting it.
--
Colin Watson [EMAIL PROTECTED]
fluent in Autoconf than I am.
Is it sufficient to test a single value? It's been some time since I had
convenient access to either Solaris or AIX systems.
Cheers,
--
Colin Watson [EMAIL PROTECTED]
diff --git a/lib/string.in.h b/lib/string.in.h
On Mon, Jan 14, 2008 at 11:37:03PM +0100, Bruno Haible wrote:
> Hi Colin,
> > It looks like argp_error and argp_failure should declare themselves as
> > requiring the c-format flag. This patch implements that.
> >
> > 2008-01-14 Colin Watson <[EMAIL PROTECTED]>
Hi,
It looks like argp_error and argp_failure should declare themselves as
requiring the c-format flag. This patch implements that.
2008-01-14 Colin Watson <[EMAIL PROTECTED]>
* modules/argp: Add a notice recommending to change XGETTEXT_OPTIONS.
Invoke AM_GETTEXT_OPTION
On Wed, Jan 09, 2008 at 10:52:01AM +0100, Bruno Haible wrote:
> Colin Watson wrote:
> > The attached updated patches address your concerns and Paul's
>
> Thanks; looks better now. Two points still:
>
> - This code will not compile with C89 compilers on platforms without
I happened to notice a typo in canonicalize-lgpl.c. Patch attached.
Thanks,
--
Colin Watson [EMAIL PROTECTED]
diff --git a/lib/canonicalize-lgpl.c b/lib/canonicalize-lgpl.c
index e8d2b65..2aebbc6 100644
--- a/lib/canonicalize-lgpl.c
+++ b/lib/canonicalize
On Tue, Jan 08, 2008 at 02:42:24AM +0100, Bruno Haible wrote:
> Colin Watson wrote:
> > Do you happen to know whether I was overdoing it by adding in #ifdefs
> > for SIGHUP, SIGINT, etc.? I decided better safe than sorry, but didn't
> > know whether there was some
On Tue, Jan 08, 2008 at 01:56:55AM +0100, Bruno Haible wrote:
> Colin Watson wrote:
> > I use strsignal in man-db, and would like a Gnulib module to cope with
> > its portability problems. Here's one which seems to be doing the right
> > thing for me so far. This is my
does actually matter here. I may be able to simplify it, though.
Do you happen to know whether I was overdoing it by adding in #ifdefs
for SIGHUP, SIGINT, etc.? I decided better safe than sorry, but didn't
know whether there was some basic set of signals that Gnulib's supported
platforms
an't really use asprintf because the glibc
version writes into a static buffer and I'd like to behave the same way.
Does anyone have any suggestions?
This implementation is based on glibc's. I've attached the diff against
current CVS for the files in q
https://svn.sourceforge.net/svnroot/miktex/miktex/trunk
msmtp http://msmtp.cvs.sourceforge.net/msmtp/msmtp/
newts http://svn.arete.cc/newts/trunk/
Thanks,
--
Colin Watson [EMAIL PROTECTED]
[dropped [EMAIL PROTECTED] from CC]
On Fri, Jan 04, 2008 at 01:15:15AM +0100, Bruno Haible wrote:
> Colin Watson wrote:
> > I decided to write some documentation for this (diff attached), which I
> > hope you can review and add to Gnulib.
>
> Many thanks for this! I changed
ption in its gnulib-tool invocations.
I decided to write some documentation for this (diff attached), which I
hope you can review and add to Gnulib. What do you think? If you require
a copyright assignment for this, I can certainly do that, though there
may be a short delay in getting a signature
d you consider this patch?
(I don't see the need to do the same for xmemdup, since you have to pass
it the size of the memory region so it makes sense that that should have
to be non-NULL. Though __attribute__ (__nonnull__) might be nice ...)
2007-10-20 Colin Watson <[EMAIL PROTECTED]>
On Thu, Oct 18, 2007 at 12:57:17PM +0200, Bruno Haible wrote:
> Thanks for reporting all this. I'm applying the appended patch to fix
> all this.
Thanks.
> Colin Watson wrote:
> > Fourthly, gcc complains:
> >
> > trim.c: In function ‘trim2’:
> >
;;
}
}
diff --git a/modules/trim b/modules/trim
index 27cdefc..7cd1a7c 100644
--- a/modules/trim
+++ b/modules/trim
@@ -12,6 +12,7 @@ mbiter
configure.ac:
Makefile.am:
+lib_SOURCES += trim.h trim.c
Include:
#include "trim.h"
Thanks,
--
Colin Watson [EMAIL PROTECTED]
'malloc' and 'nonnull (1)' attributes. 'malloc' requires gcc 2.96,
'nonnull' requires gcc 3.3, and 'warn_unused_result' requires gcc 3.4.
Could Gnulib do the same for its x* wrappers?
Thanks,
--
Colin Watson [EMAIL PROTECTED]
: warning: shadowed declaration is here
The declaration here looks spurious, so this patch removes it.
2007-10-15 Colin Watson <[EMAIL PROTECTED]>
* lib/glob.c (glob_in_dir): Remove duplicate declaration of "save".
diff --git a/lib/glob.c b/lib/glob.c
index e8b79ff..a98a
their AC_REPLACE_FUNCS
reimplementations?
Thanks,
--
Colin Watson [EMAIL PROTECTED]
On Sun, Oct 14, 2007 at 11:07:28PM +0200, Bruno Haible wrote:
> Colin Watson wrote:
> > I made this change and it now works correctly.
>
> Thanks for checking. That's important to know.
>
> How exactly did you invoke gnulib-tool? With or without a --makefile-name
>
On Sun, Oct 14, 2007 at 07:37:35PM +0100, Colin Watson wrote:
> On Sun, Oct 14, 2007 at 05:41:06PM +0200, Bruno Haible wrote:
> > The expected behaviour is that __getwcd expands to getcwd which in turns
> > expands to rpl_getcwd. If getcwd does not expand to rpl_getcwd, you need
On Sun, Oct 14, 2007 at 05:41:06PM +0200, Bruno Haible wrote:
> Colin Watson wrote:
> > I'm in the process of making my man-db package use Gnulib. Upon
> > importing the xgetcwd module and using it
>
> Have you done a "make distclean" and reconfigured after doi
char *getcwd.
I'm working with the gnulib package in Debian unstable (last commit
dated 2007-09-18), but inspection of a current git checkout suggests
that it has the same problem.
Thanks,
--
Colin Watson [EMAIL PROTECTED]
64 matches
Mail list logo
