Bruno Haible writes:
> Please hold off for the moment. The patch looks quite strange. Need to
> think through it all. Will do that tomorrow.
Sure, will do.
Collin
Hi Collin,
> I prefer just changing this to an *.in.h file and replacing the variable
> like you suggest. Could you double check the attached patch before I
> push the change?
Please hold off for the moment. The patch looks quite strange. Need to
think through it all. Will do that tomorrow.
Brun
Somehow I missed that this patch
* produces compilation errors in the gnulib tests:
../../gltests/test-string-buffer-reversed.c:113:32: error: passing
'rw_string_desc_t' (aka 'struct rw_string_desc_t') to parameter of incompatible
type 'string_desc_t' (aka 'struct string_desc_t')
113 | sb
Hi Bruno,
Bruno Haible writes:
> #if @HAVE_SYS_CDEFS_H@
> # include
> #endif
>
> It would be good to use the same idiom in fts_.h. The idea is that
> things are more robust if the value of some HAVE_* macro is taken
> directly from config.status, rather than from config.h (where it
> comes from
Hi Collin,
> like in getopt-cdefs.in.h
getopt-cdefs.in.h does this:
#if @HAVE_SYS_CDEFS_H@
# include
#endif
It would be good to use the same idiom in fts_.h. The idea is that
things are more robust if the value of some HAVE_* macro is taken
directly from config.status, rather than from config.
In a testdir of fts and the GCC 15 warnings from HACKING I see:
$ cat ../output.txt
CC fts.o
In file included from /usr/include/features.h:524,
from /usr/include/sys/types.h:25,
from ./sys/types.h:46,
from fts_.h:8
Bruno Haible writes:
>> I have attached two patches that seem to fix the issue, but have not
>> pushed them in case I am misunderstanding the error.
>
> While your fix is correct, I prefer to stick to the principle
> "keep related things nearby together": since the attribute is about
> the argume
On 2025-05-10 05:46, Bruno Haible wrote:
Here, after the qcopy-acl change yesterday, the following modules need
to link with $(FILE_HAS_ACL_LIB), at least conditionally:
* qcopy-acl
* The dependents of qcopy-acl:
$ ./gnulib-tool --extract-dependents qcopy-acl
acl
copy-f
> $ gcc --version | sed 1q
> gcc (GCC) 15.1.1 20250425 (Red Hat 15.1.1-1)
And the error is reproducible also with other compiler versions.
gcc 13:
In file included from ../../gllib/string-desc.c:20:
../config.h:1361:28: error: attributes should be specified before the
declarator in a fu
Hi Collin,
> However, when doing the following commands in gettext:
>
> $ ./autopull.sh
> $ ./autogen.sh
> $ ./configure && make
>
> I see the following error:
>
> $ gcc --version | sed 1q
> gcc (GCC) 15.1.1 20250425 (Red Hat 15.1.1-1)
> $ make
> [...]
> gcc -DHA
Hi Paul,
> * modules/acl-tests (test_copy_acl_LDADD): Add
> $(FILE_HAS_ACL_LIB), since qcopy-acl depends on file-has-acl.
> Although this suggests that QCOPY_ACL_LIB should contain
> FILE_HAS_ACL_LIB, I’m not sure whether that’s the right course of
> action
Yes, when a unit test has a link error,
The macro gl_FUNC_ACL determines the prerequisites of module 'acl-permissions',
in particular the value of $(LIB_ACL).
The macro gl_FILE_HAS_ACL determines the prerequisites of module 'file-has-acl'.
Since 'file-has-acl' depends on 'acl-permissions', it is perfectly OK for
gl_FILE_HAS_ACL to requi
12 matches
Mail list logo
