Bruno Haible <br...@clisp.org> writes: >> I have attached two patches that seem to fix the issue, but have not >> pushed them in case I am misunderstanding the error. > > While your fix is correct, I prefer to stick to the principle > "keep related things nearby together": since the attribute is about > the argument list, it's irritating to see it mentioned long before > the argument list. I prefer the attached patch.
Thanks! I disliked the placement of the attributes in my patch as well, but did not see a way around it. Your patch works for me. >> gettext still fails to build afterwards, but it seems like changing to >> rw_string_desc_t where applicable will fix it. > > Yes. I just hadn't gotten around to pushing these changes. Cool. I didn't even bother making the changes since I assumed you were developing this module alongside gettext. >> $ gcc --version | sed 1q >> gcc (GCC) 15.1.1 20250425 (Red Hat 15.1.1-1) > > And the error is reproducible also with other compiler versions. Thanks for the info. I shared that output thinking that maybe your system used an older GCC version where it worked. Collin
