Re: Android API 8 compilation errors

2025-04-20 Thread Po Lu
Paul Eggert writes: > On 2025-04-20 18:45, Po Lu wrote: > >> -# if !defined (LDAV_DONE) && (defined __linux__ || defined __ANDROID__) >> +# if !defined (LDAV_DONE) && (defined __linux__ || defined __ANDROID__) \ >> + && (!defined __ANDROID__ || __ANDROID_API__ >= 13) > > Wouldn't the following b

Re: Android API 8 compilation errors

2025-04-20 Thread Paul Eggert
On 2025-04-20 18:45, Po Lu wrote: -# if !defined (LDAV_DONE) && (defined __linux__ || defined __ANDROID__) +# if !defined (LDAV_DONE) && (defined __linux__ || defined __ANDROID__) \ + && (!defined __ANDROID__ || __ANDROID_API__ >= 13) Wouldn't the following be simpler, and work as well? #if

Re: vasnprintf: Consider the grouping rule

2025-04-20 Thread Collin Funk
Hi Bruno, Bruno Haible via Gnulib discussion list writes: > This patch fixes it, by considering the 'grouping' sequence of numbers. On FreeBSD 15.0 (cfarm427) I see the following warnings: In file included from unistdio/u16-u16-vasnprintf.c:57: ./vasnprintf.c:5224:77: warning: incompat

Re: C++ std::

2025-04-20 Thread Collin Funk
Hi Bruno, Bruno Haible writes: > I try to avoid the C++ Standard Library, because Thanks for the detailed response. I certainly agree regarding the unreadability of the C++ standard library. Collin

Re: Android API 8 compilation errors

2025-04-20 Thread Po Lu
Po Lu writes: > Bruno Haible writes: > >> Po Lu wrote: >>> The latest Gnulib getloadavg.c does not compile on Android API 8, with >>> the NDK r10c: >>> >>> CC getloadavg.o >>> getloadavg.c: In function 'rpl_getloadavg': >>> getloadavg.c:509:5: error: implicit declaration of function 'sy

Re: Android API 8 compilation errors

2025-04-20 Thread Po Lu
Bruno Haible writes: > Po Lu wrote: >> The latest Gnulib getloadavg.c does not compile on Android API 8, with >> the NDK r10c: >> >> CC getloadavg.o >> getloadavg.c: In function 'rpl_getloadavg': >> getloadavg.c:509:5: error: implicit declaration of function 'sysinfo' >> [-Werror=implic

Re: C++ std::

2025-04-20 Thread Bruno Haible via Gnulib discussion list
Hi Collin, > Out of curiosity though, why not use std::unordered_map [1]? Is C++ > standard library not portable enough? > > [1] https://en.cppreference.com/w/cpp/container/unordered_map I try to avoid the C++ Standard Library, because * My general experience with C++ is that the more feature

Re: Update users.txt

2025-04-20 Thread Collin Funk
Bruno Haible via Gnulib discussion list writes: > GNU gperf now uses Gnulib: A 30% speedup of gperf is realized through the > gnulib module 'hash-map'. Nice improvement and congrats on the new release. Out of curiosity though, why not use std::unordered_map [1]? Is C++ standard library not port

Re: test-frexp-nolibm failure

2025-04-20 Thread Bruno Haible via Gnulib discussion list
> > > * This version still fails the tests on Debian unstable for i386, > > > I think that glibc may have something to do with that: > > > > > > ../build-aux/test-driver: line 119: 18250 Aborted (core > > > dumped) "$@" >> "$log_file" 2>&1 > > > FAIL: test-frexp-nolibm > > > > Br

Re: Android API 8 compilation errors

2025-04-20 Thread Bruno Haible via Gnulib discussion list
Po Lu wrote: > The latest Gnulib getloadavg.c does not compile on Android API 8, with > the NDK r10c: > > CC getloadavg.o > getloadavg.c: In function 'rpl_getloadavg': > getloadavg.c:509:5: error: implicit declaration of function 'sysinfo' > [-Werror=implicit-function-declaration] >

Android API 8 compilation errors

2025-04-20 Thread Po Lu
The latest Gnulib getloadavg.c does not compile on Android API 8, with the NDK r10c: CC getloadavg.o getloadavg.c: In function 'rpl_getloadavg': getloadavg.c:509:5: error: implicit declaration of function 'sysinfo' [-Werror=implicit-function-declaration] if (sysinfo (&info) < 0)