Re: test-sprintf-posix and test-snprintf-posix test failures

2024-04-26 Thread Collin Funk
Hi Bruno, On 4/26/24 10:51 PM, Bruno Haible wrote: > welcome to the daily business of Gnulib test failures and workarounds! Thanks for the welcome! I would have worked a bit harder and tried to come up with a patch, but I am not very familiar with the wide character and multibyte string function

Re: test-sprintf-posix and test-snprintf-posix test failures

2024-04-26 Thread Bruno Haible
Hi Collin, welcome to the daily business of Gnulib test failures and workarounds! > backtrace from test-sprintf-posix: > == > #4 0x004090cd in test_function (my_sprintf=) at > /home/collin/.local/src/gnulib/testdir/gltests/test-sprintf-posix.h:3174 >

test-sprintf-posix and test-snprintf-posix test failures

2024-04-26 Thread Collin Funk
I see two similar test failures for test-sprintf-posix and test-sprintf-posix on Fedora 40, gcc 14, glibc 2.39. Using: $ ./gnulib-tool --create-testdir --dir testdir sprintf-posix snprintf-posix $ cd testdir $ ./configure $ make check The following tests fail: ./../build-aux/test-driver: line 1

login_tty tests: Avoid gcc warnings

2024-04-26 Thread Bruno Haible
Compiling a testdir on Ubuntu 24.04, I see these gcc 13.2 warnings: ../../gltests/test-login_tty.c:66:11: warning: ignoring return value of 'freopen' declared with attribute 'warn_unused_result' [-Wunused-result] ../../gltests/test-login_tty.c:79:17: warning: ignoring return value of 'freopen' d

Re: gnulib-tool: Use the Python implementation by default

2024-04-26 Thread Bruno Haible
Hi Collin, > Should Python 3.7 be added to DEPENDENCIES or > should we hold off on that for a bit? Since gnulib-tool.sh can still > be used. Good point. Done like this: 2024-04-26 Bruno Haible Document prerequisite for gnulib-tool. Suggested by Collin Funk in

Re: gnulib-tool: Use the Python implementation by default

2024-04-26 Thread Collin Funk
Hi Bruno, On 4/26/24 2:48 AM, Bruno Haible wrote: > I committed this patch, which activates the Python rewrite of gnulib-tool > for all users who have Python installed, without the need to set any > environment variable. I'll make announcements to info-gnu and planet.gnu.org > soon. Looks good, t

GNU gnulib: gnulib-tool has become much faster

2024-04-26 Thread Bruno Haible
If you are developer on a package that uses GNU gnulib as part of its build system: gnulib-tool has been known for being slow for many years. We have listened to your complaints. We have rewritten gnulib-tool in another programming language (Python). It is between 8 times and 100 times faster than

gnulib-tool: Use the Python implementation by default

2024-04-26 Thread Bruno Haible
I committed this patch, which activates the Python rewrite of gnulib-tool for all users who have Python installed, without the need to set any environment variable. I'll make announcements to info-gnu and planet.gnu.org soon. Also I couldn't resist pushing a tag named 'v1.0'. We don't make release

Re: gnulib-tool.py: Remove some unused instance variables.

2024-04-26 Thread Collin Funk
Hi Bruno, On 4/26/24 2:20 AM, Bruno Haible wrote: > However, please hold pushing patches for the next 3 days. I will be > posting the announcement of the faster gnulib-tool in the next few > hours; therefore I expect that several GNU package maintainers will > give it a try for the first time in y

Re: WIP patch to reduce rewrite_filename duplication

2024-04-26 Thread Bruno Haible
Collin Funk wrote: > > Correct. Feel free to add tests for --copy-file, if you like. > > I didn't spend time on it, since --copy-file is simple enough. > > Sure, I can have a look at adding some. I see it is part of the Gnulib > Savannah group so I can commit changes there. I assume same rules go

Re: gnulib-tool.py: Remove some unused instance variables.

2024-04-26 Thread Bruno Haible
Hi Collin, > Most of the instance variables in GLMegaTestDir are unused. This makes > sense since GLMegaTestDir pretty much just calls GLTestDir functions > on a list of modules and then does some extra work afterwards. > > I committed this patch removing them. Looks good. Thanks. However, plea

gnulib-tool.py: Remove some unused instance variables.

2024-04-26 Thread Collin Funk
Most of the instance variables in GLMegaTestDir are unused. This makes sense since GLMegaTestDir pretty much just calls GLTestDir functions on a list of modules and then does some extra work afterwards. I committed this patch removing them. CollinFrom f306be627b5b2a45b829c9a7cb406c20d4d35198 Mon