Most of the instance variables in GLMegaTestDir are unused. This makes
sense since GLMegaTestDir pretty much just calls GLTestDir functions
on a list of modules and then does some extra work afterwards.
I committed this patch removing them.
Collin
From f306be627b5b2a45b829c9a7cb406c20d4d35198 Mon Sep 17 00:00:00 2001
From: Collin Funk <[email protected]>
Date: Fri, 26 Apr 2024 01:58:09 -0700
Subject: [PATCH] gnulib-tool.py: Remove some unused instance variables.
* pygnulib/GLTestDir.py (GLMegaTestDir.__init__): Don't define instance
variables that are never used.
---
ChangeLog | 6 ++++++
pygnulib/GLTestDir.py | 4 ----
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 276258b885..4a2f0601bb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-04-26 Collin Funk <[email protected]>
+
+ gnulib-tool.py: Remove some unused instance variables.
+ * pygnulib/GLTestDir.py (GLMegaTestDir.__init__): Don't define instance
+ variables that are never used.
+
2024-04-25 Collin Funk <[email protected]>
gnulib-tool.py: Reduce code duplication in file name transformations.
diff --git a/pygnulib/GLTestDir.py b/pygnulib/GLTestDir.py
index 8534e19254..758a65168e 100644
--- a/pygnulib/GLTestDir.py
+++ b/pygnulib/GLTestDir.py
@@ -861,11 +861,7 @@ def __init__(self, config: GLConfig, megatestdir: str) -> None:
os.mkdir(self.megatestdir)
except Exception as exc:
raise GLError(19, self.megatestdir) from exc
- self.emitter = GLEmiter(self.config)
- self.filesystem = GLFileSystem(self.config)
self.modulesystem = GLModuleSystem(self.config)
- self.assistant = GLFileAssistant(self.config)
- self.makefiletable = GLMakefileTable(self.config)
def execute(self) -> None:
'''Create a mega scratch package with the given modules one by one
--
2.44.0
