Re: gnulib-tool --extract-filelist whitespace diff fix

2024-03-19 Thread Bruno Haible
Collin Funk wrote: > I am hesitant to change the GLModule.getFiles() function to include an > empty string just so that joining the lines emits an empty line. > > This solution should work. This solution is too much of a hack. It would be better to define a method getFiles_Raw -> str, similarly

Re: Problems with directory trees "confdir-14B---" and "confdir3"

2024-03-19 Thread Paul Eggert
Also, what happens if you run 'configure' this way? ./configure gl_cv_func_getcwd_succeeds_beyond_4k=no If that works around the Mac OS X 'rm' bug, that may be good enough.

gnulib-tool --extract-filelist whitespace diff fix

2024-03-19 Thread Collin Funk
When looking at the gnulib-tool test suite I noticed that the '--extract-filelist' tests fail because of this whitespace difference: $ env GNULIB_TOOL_IMPL=sh gnulib-tool --extract-filelist warnings m4/warnings.m4 m4/00gnulib.m4 m4/zzgnulib.m4 m4/gnulib-common.m4 $ env GNULIB_TOOL_IMPL=py gnulib

Re: a test suite for gnulib-tool

2024-03-19 Thread Collin Funk
Hi Bruno, On 3/19/24 4:33 PM, Bruno Haible wrote: > In > I outlined how a test suite for gnulib-tool could look like. Thanks! I wanted to get started on something but got caught up with working on gnulib-tool.py itself. Your te

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 68.

2024-03-19 Thread Bruno Haible
> This patch patch should apply cleanly for you. Thanks. Applied. Bruno

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 68.

2024-03-19 Thread Collin Funk
Hi Bruno, On 3/19/24 4:55 PM, Bruno Haible wrote: > I think this should be 'or', not 'and'? Cf. gnulib-tool.sh line 1667. Yes... That is my mistake, sorry. This patch patch should apply cleanly for you. CollinFrom 2536a3973c33cf0e036c0f956daee8939862b280 Mon Sep 17 00:00:00 2001 From: Collin Fun

Re: Problems with directory trees "confdir-14B---" and "confdir3"

2024-03-19 Thread Paul Eggert
On 3/19/24 15:32, Peter Dyballa wrote: My guess is that this old Mac OS X "rm" has corrupted internal memory somehow. Let's not waste more time on it. /bin/rm is not involved because the test programme is not using it but rmdir() when cleaning up… I was analyzing the trace you sent here: ht

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 68.

2024-03-19 Thread Bruno Haible
Hi Collin, > Here is two patches. The first adds '--automake-subdir-tests' which is > used by GNU Bison. In GLImport.py: # Determine whether --automake-subdir/--automake-subdir-tests are supported. if self.config['automake_subdir'] and self.config['automake_subdir_tests']: I t

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 67.

2024-03-19 Thread Bruno Haible
Collin Funk wrote: > $ diff -u python.help shell.help > --- python.help 2024-03-19 10:09:46.255348603 -0700 > +++ shell.help 2024-03-19 10:09:37.986334838 -0700 > @@ -79,6 +79,8 @@ > directory. >--local-dir=DIRECTORY Specify a local override directory where t

a test suite for gnulib-tool

2024-03-19 Thread Bruno Haible
In I outlined how a test suite for gnulib-tool could look like. Now I created such a test suite. You find it in the maint-tools repository [1] (use the 'git clone' command of gnulib, replacing gnulib.git with gnulib/maint-to

Re: gnulib-tool: Add undocumented option --gnulib-dir

2024-03-19 Thread Bruno Haible
I did: > 2024-03-17 Bruno Haible > > gnulib-tool: Add undocumented option --gnulib-dir. Two more tweaks are needed for the test suite: 2024-03-19 Bruno Haible gnulib-tool: Make it work in the test suite. * gnulib-tool.sh (gnulib_dir): Make absolute. (func_cr

Re: Problems with directory trees "confdir-14B---" and "confdir3"

2024-03-19 Thread Peter Dyballa
> Am 19.03.2024 um 22:52 schrieb Paul Eggert : > > None of the traces you've sent reproduce the originally-reported problem of > "No space left on device". The latest trace instead shows: Because *I* could not reproduce the circumstances. The confdir-14B-- tree might have had the same depth a

Re: Forwarded: Segmentation Fault via recursive loop in Gawk

2024-03-19 Thread Bruno Haible
Paul Eggert wrote: > In glibc (and Gnulib) the regular-expression code has long been > maintained under the philosophy that the code cannot handle arbitrary > regular expressions. Any code that lets the user specify an arbitrary > regular expression is suspect, and this includes Awk scripts. (Th

Re: Forwarded: Segmentation Fault via recursive loop in Gawk

2024-03-19 Thread Paul Eggert
In glibc (and Gnulib) the regular-expression code has long been maintained under the philosophy that the code cannot handle arbitrary regular expressions. Any code that lets the user specify an arbitrary regular expression is suspect, and this includes Awk scripts. (This is also true for C libr

Re: Problems with directory trees "confdir-14B---" and "confdir3"

2024-03-19 Thread Paul Eggert
None of the traces you've sent reproduce the originally-reported problem of "No space left on device". The latest trace instead shows: 1. 337 successful sequences of the form 'fd = open("confdir-14B---", ...); fchdir (fd); close (fd);'. 2. 179 successful sequences of the form 'chdir(".."); r

[PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 68.

2024-03-19 Thread Collin Funk
Here is two patches. The first adds '--automake-subdir-tests' which is used by GNU Bison. With just this patch, when trying to bootstrap GNU Bison: # GNU Bison needs this first. Not sure why. $ git submodule update --init $ env GNULIB_TOOL_IMPL=py ./bootstrap ... lib/gnulib.mk:26: error: comment f

Re: Problems with directory trees "confdir-14B---" and "confdir3"

2024-03-19 Thread Peter Dyballa
> Am 19.03.2024 um 00:38 schrieb Paul Eggert : > > export LC_ALL=C > ktrace rm -rf confdir-14B--- > kdump Hello Paul! I've produced binary file -rw--- 1 root admin 732074 19. Mär 18:26 ktrace.out Can you work with it? Or would you like -rw-r--r-- 1 root admin 521560 19. M

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 67.

2024-03-19 Thread Collin Funk
Hi Bruno, On 3/19/24 8:47 AM, Bruno Haible wrote: > Tom Dickey's packages (GNU ncurses, lynx, etc.) and GNU clisp still use > configure.in. Interesting, good to know. It seems working on gnulib-tool is a good way for me to explore all the GNU packages. Speaking of which, I was working on '--auto

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 67.

2024-03-19 Thread Bruno Haible
Collin Funk wrote: > I forgot about the existence of the 'configure.in' file. ... > The only reason I know that it exists is because I looked through some > 4.4BSD sources at one point. It had some GNU software that used that > name. Tom Dickey's packages (GNU ncurses, lynx, etc.) and GNU clisp st

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 67.

2024-03-19 Thread Collin Funk
Bruno Haible writes: > In common talk, "I made an error" and "I made a mistake" are synonymous. > But when talking about a program, there's a difference between "an error" > and "a mistake". I agree, that would be a more accurate description. I didn't put too much thought into it. I was in "commo

Forwarded: Segmentation Fault via recursive loop in Gawk

2024-03-19 Thread arnold
Hello. Please see this report sent to the gawk list concerning regcomp.c. I have attached his "POCFILE". Thanks, Arnold > From: ttfish > Date: Tue, 19 Mar 2024 21:48:34 +0800 > Subject: Segmentation Fault via recursive loop in Gawk > To: bug-g...@gnu.org > Cc: secur...@gnu.org > > Content-Type

Re: [PATCH] gnulib-tool.py: Don't emit empty Automake snippets.

2024-03-19 Thread Collin Funk
Hi Bruno, Bruno Haible writes: > ... which tests whether the combination of the two snippets contains some > character that is not newline, not space, and not tab. Oops... That is embarrassing. I wrote that right before going to sleep. I think I ended up imagining it was: grep '^[^

Re: Problems with directory trees "confdir-14B---" and "confdir3"

2024-03-19 Thread Peter Dyballa
> Am 19.03.2024 um 12:42 schrieb Bruno Haible : > > Peter Dyballa wrote: >> On Leopard I could run dtruss, which outputs around 200 K chars… Do you know >> how to filter just that what you need? > > Just compress it (gzip will be sufficient) and attach it. Thanks. Command used as root was: dtr

Re: Problems with directory trees "confdir-14B---" and "confdir3"

2024-03-19 Thread Bruno Haible
Peter Dyballa wrote: > On Leopard I could run dtruss, which outputs around 200 K chars… Do you know > how to filter just that what you need? Just compress it (gzip will be sufficient) and attach it. Thanks. Bruno

Re: Problems with directory trees "confdir-14B---" and "confdir3"

2024-03-19 Thread Peter Dyballa
> Am 19.03.2024 um 00:38 schrieb Paul Eggert : > > export LC_ALL=C > ktrace rm -rf confdir-14B--- > kdump Hello Paul! Today by chance I am a bit busy with other things, so I asked "the community" to try ktrace/kdump on their Tiger systems. On Leopard I could run dtruss, which outputs around

Re: [PATCH] gnulib-tool.py: Don't emit empty Automake snippets.

2024-03-19 Thread Bruno Haible
Hi Collin, > The shell script checks if an Automake snippet is non-empty by doing this: > > if grep '[^]' "$tmp"/amsnippet1 "$tmp"/amsnippet2 > /dev/null ; then ... which tests whether the combination of the two snippets contains some character that is not newline, not space, and not tab. >

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 67.

2024-03-19 Thread Bruno Haible
Hi Collin, > Two simple patches. This just makes it so that the library Makefile > is output after gnulib-comp.m4. > ... > but the removal of the temporary file is done inside of the parent, > outside of the loop. Therefore only the second temporary file would be > deleted. Thanks! Both patches a

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 66.

2024-03-19 Thread Bruno Haible
Hi Collin, Thanks; applied as well. > Also, I am aware that the conditional that I changed in > GLTestDir.execute() can be simplified to: > > # Determine final file list. > if not single_configure: > main_modules = modules > tests_modules = [ module >

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 65.

2024-03-19 Thread Bruno Haible
Hi Collin, The patch is mostly good; I've applied it. One point needs attention, still: In gnulib-tool.sh the code looks at configure.ac and, if that does not exist, at configure.in: # Prefer configure.ac to configure.in. if test -f "$destdir"/configure.ac; then configure_ac="$dest