Hi Collin, Thanks; applied as well.
> Also, I am aware that the conditional that I changed in > GLTestDir.execute() can be simplified to: > > # Determine final file list. > if not single_configure: > main_modules = modules > tests_modules = [ module > for module in modules > if module.repeatModuleInTests() ] > > main_filelist, tests_filelist = \ > moduletable.filelist_separately(main_modules, tests_modules) > filelist = sorted(set(main_filelist + tests_filelist)) > > But shell script requires the > 'if $single_configure; then ... else ... fi' because the function > messes with variables. > > I figured that simplifying it might just make it harder to cross > reference Yes, for the moment, the ability to cross-reference between the two implementations is still important. Also, this code which manipulates sets of modules requires thought in every possible code branch; therefore even simple code simplifications might make the code hard to follow. Bruno
